search for: libnbd_have_nbd_add_free_callback

...ot;typedef void (*nbd_free_callback) (void *ptr);\n"; + pr "extern int nbd_add_free_callback (struct nbd_handle *h,\n"; + pr " nbd_free_callback cb,\n"; + pr " void *ptr);\n"; + pr "#define LIBNBD_HAVE_NBD_ADD_FREE_CALLBACK 1\n"; + pr "\n"; print_closure_typedefs (); List.iter ( fun (name, { args; optargs; ret }) -> @@ -4005,6 +4012,45 @@ C<E<lt>errno.hE<gt>>. List.iter print_api handle_calls; pr "\ +=head1 FREE CALLBACKS + +B<Note:> The API described...

...d_free_callback) (void *ptr);\n"; > + pr "extern int nbd_add_free_callback (struct nbd_handle *h,\n"; > + pr " nbd_free_callback cb,\n"; > + pr " void *ptr);\n"; > + pr "#define LIBNBD_HAVE_NBD_ADD_FREE_CALLBACK 1\n"; > + pr "\n"; Would this change the signature of callbacks? With this in place, you no longer need the VALID|FREE parameter, but can defer the free action to an added free callback. How would you actually track when to call the free callback? I guess each time a pointer li...

...xtern int nbd_add_free_callback (struct nbd_handle *h,\n"; + pr " void *ptr,\n"; + pr " nbd_free_callback cb,\n"; + pr " void *user_data);\n"; + pr "#define LIBNBD_HAVE_NBD_ADD_FREE_CALLBACK 1\n"; + pr "\n"; print_closure_typedefs (); List.iter ( fun (name, { args; optargs; ret }) -> @@ -4005,6 +4013,55 @@ C<E<lt>errno.hE<gt>>. List.iter print_api handle_calls; pr "\ +=head1 FREE CALLBACKS + +B<Note:> The API described...

As proposed here: https://www.redhat.com/archives/libguestfs/2019-August/msg00130.html I didn't actually read Eric's replies to that yet because I've been concentrating on writing these patches all day. Anyway here they are and I'll look at what Eric said about the proposal next. Rich.