search for: libguestfs_tmpdir

This test has been broken for a while. It is meant to test that when the appliance cachedir is empty, two simultaneous runs of libguestfs (both rebuilding the full appliance) will not cause conflicts, because (eg) the locking in either supermin or libguestfs is not working. However the test only set $TMPDIR, but the ./run script sets $LIBGUESTFS_CACHEDIR which overrides $TMPDIR, so it was simply

...files changed, 97 insertions(+), 5 deletions(-) diff --git a/fish/guestfish.pod b/fish/guestfish.pod index c6f5663..bbeea82 100644 --- a/fish/guestfish.pod +++ b/fish/guestfish.pod @@ -1519,6 +1519,17 @@ about kernel selection, see L<supermin(1)>. See L</LIBGUESTFS_CACHEDIR>, L</LIBGUESTFS_TMPDIR>. +=item XDG_RUNTIME_DIR + +This directory represents a user-specific directory for storing +non-essential runtime files. + +If it is set, then is used to store temporary sockets. Otherwise, +F</tmp> is used. + +See also L</get-sockdir>, +L<http://www.freedesktop.org/wiki/Speci...

Introduce an internal helper to create paths for sockets -- will be useful for changing later the logic for placing sockets. Futhermore, check that the length of sockets won't overflow the buffer for their filenames. --- src/guestfs-internal.h | 1 + src/launch-direct.c | 4 +++- src/launch-libvirt.c | 10 ++++++---- src/launch.c | 17 +++++++++++++++++ 4 files changed, 27

...ME_DIR or one of the tmpdirs or cachedir is set to a non-existent directory, improve the error message that the user will see so that (where possible) it includes the environment variable or API call. This is still not bullet-proof because it's hard to display the environment variable if it is LIBGUESTFS_TMPDIR or LIBGUESTFS_CACHEDIR, but the main problem is with XDG_RUNTIME_DIR (because of systemd bugs). Thanks: Hilko Bengen for identifying the bug. --- src/guestfs-internal.h | 4 ++-- src/handle.c | 4 ++-- src/tmpdirs.c | 30 ++++++++++++++++++++---------- 3 files changed, 24 ins...

...008.html [2] https://www.redhat.com/archives/libguestfs/2020-April/msg00010.html Since the problem is "let's find out what to clean on failure", I propose a different approach, as also looking at this patch pointed out to me: - create a single virt-v2v.XXXXXX temporary directory in LIBGUESTFS_TMPDIR for small files, like the vmx file, the rhv-upload Python scripts, etc - create a single virt-v2v.XXXXXX temporary directory in LIBGUESTFS_CACHEDIR for big files Advantages: - no more need for the various Mkdtemp.temp_dir all around - only two well-defined names for temporary stuff that virt-v2...

...patch is to allow more reliable cleanup of > > temporary files by an external process, as described in the updated > > documentation. > > --- > > I do not understand the motivation behind this, which adds yet another > location with temporary files in addition to: > - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by > default) > - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID > subdirectory for the appliance) > > Before this patch, almost all the temporary files are stored directly > or in subdirectories of $TMPDIR, except b...

...files changed, 88 insertions(+), 4 deletions(-) diff --git a/fish/guestfish.pod b/fish/guestfish.pod index c6f5663..bbeea82 100644 --- a/fish/guestfish.pod +++ b/fish/guestfish.pod @@ -1519,6 +1519,17 @@ about kernel selection, see L<supermin(1)>. See L</LIBGUESTFS_CACHEDIR>, L</LIBGUESTFS_TMPDIR>. +=item XDG_RUNTIME_DIR + +This directory represents a user-specific directory for storing +non-essential runtime files. + +If it is set, then is used to store temporary sockets. Otherwise, +F</tmp> is used. + +See also L</get-sockdir>, +L<http://www.freedesktop.org/wiki/Speci...

...ry files by an external process, as described in the updated > > > > documentation. > > > > --- > > > > > > I do not understand the motivation behind this, which adds yet another > > > location with temporary files in addition to: > > > - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by > > > default) > > > - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID > > > subdirectory for the appliance) > > > > > > Before this patch, almost all the temporary files are stored direc...

Introduce an internal helper to create paths for sockets; will be useful for changing later the logic for placing sockets. --- src/guestfs-internal.h | 1 + src/launch-direct.c | 4 +++- src/launch-libvirt.c | 10 ++++++---- src/launch.c | 15 +++++++++++++++ 4 files changed, 25 insertions(+), 5 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index

...t a/src/guestfs-internal.h b/src/guestfs-internal.h > index 5ecd322..5575aff 100644 > --- a/src/guestfs-internal.h > +++ b/src/guestfs-internal.h > @@ -438,6 +438,11 @@ struct guestfs_h > char *env_tmpdir; /* $TMPDIR (NULL if not set) */ > char *int_tmpdir; /* $LIBGUESTFS_TMPDIR or guestfs_set_tmpdir or NULL */ > char *int_cachedir; /* $LIBGUESTFS_CACHEDIR or guestfs_set_cachedir or NULL */ > + /* Optional socket directory - this is created on demand only when > + * creating a socket whose absolute path in tmpdir would not fit > + * into sockaddr_un::su...

...published by > @@ -32,6 +32,9 @@ exit 77 if $ENV{SKIP_TEST_LAUNCH_RACE_PL}; > my $tmpdir = tempdir (CLEANUP => 1); > $ENV{TMPDIR} = $tmpdir; > > +# Unset LIBGUESTFS_CACHEDIR (set by ./run) since that will override TMPDIR. > +delete $ENV{LIBGUESTFS_CACHEDIR}; > + Should $LIBGUESTFS_TMPDIR be unset too, just to not rely solely on that being overridden by $TMPDIR? Anyway, patches LGTM. -- Pino Toscano

...> Another motivation for this patch is to allow more reliable cleanup of > temporary files by an external process, as described in the updated > documentation. > --- I do not understand the motivation behind this, which adds yet another location with temporary files in addition to: - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by default) - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID subdirectory for the appliance) Before this patch, almost all the temporary files are stored directly or in subdirectories of $TMPDIR, except big files such as overlays and...

...anup of > > > temporary files by an external process, as described in the updated > > > documentation. > > > --- > > > > I do not understand the motivation behind this, which adds yet another > > location with temporary files in addition to: > > - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by > > default) > > - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID > > subdirectory for the appliance) > > > > Before this patch, almost all the temporary files are stored directly > > or in subdi...

...ry files by an external process, as described in the updated > > > > documentation. > > > > --- > > > > > > I do not understand the motivation behind this, which adds yet another > > > location with temporary files in addition to: > > > - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by > > > default) > > > - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID > > > subdirectory for the appliance) > > > > > > Before this patch, almost all the temporary files are stored direc...

...s, as described in the updated > > > > > documentation. > > > > > --- > > > > > > > > I do not understand the motivation behind this, which adds yet another > > > > location with temporary files in addition to: > > > > - LIBGUESTFS_TMPDIR - $TMPDIR by default (which itself is /tmp by > > > > default) > > > > - LIBGUESTFS_CACHEDIR - /var/tmp by default (with a .guestfs-$UID > > > > subdirectory for the appliance) > > > > > > > > Before this patch, almost all the tempora...

...(+), 6 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 5ecd322..5575aff 100644 --- a/src/guestfs-internal.h +++ b/src/guestfs-internal.h @@ -438,6 +438,11 @@ struct guestfs_h char *env_tmpdir; /* $TMPDIR (NULL if not set) */ char *int_tmpdir; /* $LIBGUESTFS_TMPDIR or guestfs_set_tmpdir or NULL */ char *int_cachedir; /* $LIBGUESTFS_CACHEDIR or guestfs_set_cachedir or NULL */ + /* Optional socket directory - this is created on demand only when + * creating a socket whose absolute path in tmpdir would not fit + * into sockaddr_un::sun_path. + */ + ch...

Previously we placed large files in g#get_cachedir () (usually /var/tmp). However the problem is this ties the libguestfs appliance and the virt-v2v overlay files to the same location. When virt-v2v is run in a container, or any other situation where local storage is limited, it's helpful to be able to put the overlay files on an externally mounted PVC, which might be using NFS and shared

Error out early if the path to the socket will not fit into sockaddr_un::sun_path, as we will not be able to connect to it. --- src/launch-unix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/launch-unix.c b/src/launch-unix.c index 740c554..973e14b 100644 --- a/src/launch-unix.c +++ b/src/launch-unix.c @@ -47,6 +47,12 @@ launch_unix (guestfs_h *g, void *datav, const char

https://bugzilla.redhat.com/show_bug.cgi?id=1175196 Currently if you write something like LIBGUESTFS_DEBUG=0 or LIBGUESTFS_DEBUG=true then it doesn't do what you probably expect. This patch series fixes that. Rich.

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still