search for: libguestfs_jni_la_libadd

...> java/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/java/Makefile.am b/java/Makefile.am > index 81c20f266..1bad9a853 100644 > --- a/java/Makefile.am > +++ b/java/Makefile.am > @@ -122,7 +122,8 @@ libguestfs_jni_la_CFLAGS = \ > libguestfs_jni_la_LIBADD = \ > $(top_builddir)/common/structs/libstructs.la \ > $(top_builddir)/common/utils/libutils.la \ > - $(top_builddir)/lib/libguestfs.la > + $(top_builddir)/lib/libguestfs.la \ > + $(top_builddir)/gnulib/lib/libgnu.la Hmm what's the exact error in this case? On which platform...

.../Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/java/Makefile.am b/java/Makefile.am index 06d0fc7..ea64f55 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -115,7 +115,9 @@ libguestfs_jni_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(JNI_CFLAGS) -libguestfs_jni_la_LIBADD = $(top_builddir)/lib/libguestfs.la +libguestfs_jni_la_LIBADD = \ + $(top_builddir)/common/utils/libutils.la \ + $(top_builddir)/lib/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared -- 2.9.3

...s(+), 1 deletion(-) > > diff --git a/java/Makefile.am b/java/Makefile.am > index 06d0fc7..ea64f55 100644 > --- a/java/Makefile.am > +++ b/java/Makefile.am > @@ -115,7 +115,9 @@ libguestfs_jni_la_CFLAGS = \ > $(WARN_CFLAGS) $(WERROR_CFLAGS) \ > $(JNI_CFLAGS) > > -libguestfs_jni_la_LIBADD = $(top_builddir)/lib/libguestfs.la > +libguestfs_jni_la_LIBADD = \ > + $(top_builddir)/common/utils/libutils.la \ > + $(top_builddir)/lib/libguestfs.la > > libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared > > -- > 2.9.3 > > ________________...

Hi, this patch series fixes some issues discovered by Coverity. Most of them are memory leaks, usually on error; there are also invalid memory access issues. Thanks, Pino Toscano (11): java: link libguestfs_jni against libutils java: fix invalid memory access for FBuffer in struct lists daemon: tsk: properly use GUESTFS_MAX_CHUNK_SIZE edit: fix small memory leak on error java: fix

Avoids the warning: libtoolize: Remember to add 'LT_INIT' to configure.ac. This is the new name for AC_PROG_LIBTOOL, so I removed that. However to use this macro we must enable AC_USE_SYSTEM_EXTENSIONS. (AC_GNU_SOURCE was removed back in 2011). --- configure.ac | 5 +++++ m4/guestfs-progs.m4 | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac

--- java/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/java/Makefile.am b/java/Makefile.am index 81c20f266..1bad9a853 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -122,7 +122,8 @@ libguestfs_jni_la_CFLAGS = \ libguestfs_jni_la_LIBADD = \ $(top_builddir)/common/structs/libstructs.la \ $(top_builddir)/common/utils/libutils.la \ - $(top_builddir)/lib/libguestfs.la + $(top_builddir)/lib/libguestfs.la \ + $(top_builddir)/gnulib/lib/libgnu.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared -- 2.18.0

...; 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/java/Makefile.am b/java/Makefile.am > > index 81c20f266..1bad9a853 100644 > > --- a/java/Makefile.am > > +++ b/java/Makefile.am > > @@ -122,7 +122,8 @@ libguestfs_jni_la_CFLAGS = \ > > libguestfs_jni_la_LIBADD = \ > > $(top_builddir)/common/structs/libstructs.la \ > > $(top_builddir)/common/utils/libutils.la \ > > - $(top_builddir)/lib/libguestfs.la > > + $(top_builddir)/lib/libguestfs.la \ > > + $(top_builddir)/gnulib/lib/libgnu.la > > Hmm what's the exact er...

From: Hilko Bengen <bengen at hilluzination.de> --- erlang/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/erlang/Makefile.am b/erlang/Makefile.am index f336375..2c9e359 100644 --- a/erlang/Makefile.am +++ b/erlang/Makefile.am @@ -32,7 +32,7 @@ erlang_bindir = $(libdir)/erlang/lib/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/ebin erlang_bin_DATA = guestfs.beam

Patch 1/5 is a repost. Only change is title update. These fix parallel make on my machine, and additionally make building from subdirectories more correct.

...LAGS) libguestfs_gobject_1_0_la_LIBS = $(GOBJECT_LIBS) libguestfs_gobject_1_0_la_LDFLAGS = $(LDFLAGS) -L$(top_builddir)/src diff --git a/java/Makefile.am b/java/Makefile.am index 449f40b..5f6499b 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -79,7 +79,7 @@ libguestfs_jni_la_SOURCES = \ libguestfs_jni_la_LIBADD = $(top_builddir)/src/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared libguestfs_jni_la_CFLAGS = \ - -DGUESTFS_PRIVATE_FUNCTIONS=1 \ + -DGUESTFS_PRIVATE=1 \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ -I$(top_srcdir)/src -I$(top_builddir)/src \ $(JNI_CFLAGS) diff -...

...-DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ + -I$(top_srcdir)/common/structs -I$(top_builddir)/common/structs \ -I$(top_srcdir)/lib -I$(top_builddir)/lib libguestfs_jni_la_CFLAGS = \ @@ -116,6 +117,7 @@ libguestfs_jni_la_CFLAGS = \ $(JNI_CFLAGS) libguestfs_jni_la_LIBADD = \ + $(top_builddir)/common/structs/libstructs.la \ $(top_builddir)/common/utils/libutils.la \ $(top_builddir)/lib/libguestfs.la diff --git a/lib/Makefile.am b/lib/Makefile.am index 1a736e4bd..da4b592be 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -58,7 +58,7 @@ libguestfs_la_SOURCE...

...URCES = \ libguestfs_jni_la_CPPFLAGS = \ -DGUESTFS_PRIVATE=1 \ + -I$(top_srcdir)/common/cleanups -I$(top_builddir)/common/cleanups \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib @@ -117,6 +118,7 @@ libguestfs_jni_la_CFLAGS = \ libguestfs_jni_la_LIBADD = \ $(top_builddir)/common/utils/libutils.la \ + $(top_builddir)/common/cleanups/libcleanups.la \ $(top_builddir)/lib/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared diff --git a/lib/Makefile.am b/lib/Makefile.am index 360ce9c92..90c657514 100644 --- a/lib...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid