search for: libfishcommon

Create a new libfishcommon convenience static library to build just once (instead of 12 times!) the majority of the guestfish sources used in the rest of the C tools (mostly for command line stuff, inspection, and mount). The notable exceptions not using libfishcommon are guestfish itself, and virt-rescue: both need to buil...

Some of the C tools were building also config.c as part of the shared sources from guestfish, and thus bringing a dependency on libconfig. Since none of them actually read the libguestfs configuration at all, then exclude fish/config.c from their build, and stop linking to libconfig. --- align/Makefile.am | 3 --- df/Makefile.am | 3 --- edit/Makefile.am | 3 ---

...)/src \ -I$(top_srcdir)/df \ -I$(top_srcdir)/fish \ @@ -52,7 +53,7 @@ virt_alignment_scan_CFLAGS = \ $(LIBVIRT_CFLAGS) virt_alignment_scan_LDADD = \ - $(top_builddir)/src/libutils.la \ + $(top_builddir)/common/utils/libutils.la \ $(top_builddir)/src/libguestfs.la \ $(top_builddir)/fish/libfishcommon.la \ $(LIBXML2_LIBS) \ diff --git a/builder/Makefile.am b/builder/Makefile.am index 2a9f89b..85c754f 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -100,6 +100,7 @@ virt_builder_CPPFLAGS = \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ -I$(shell $(OCAMLC) -where) \...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

Nothing new in the virt-tail command itself, but the second commit includes a simple test. Rich.

...r)/src -I$(top_builddir)/src \ + -I$(top_srcdir)/fish \ + -I$(srcdir)/../gnulib/lib -I../gnulib/lib + +virt_tail_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(LIBXML2_CFLAGS) + +virt_tail_LDADD = \ + $(top_builddir)/src/libutils.la \ + $(top_builddir)/src/libguestfs.la \ + $(top_builddir)/fish/libfishcommon.la \ + $(LIBXML2_LIBS) \ + $(LIBVIRT_LIBS) \ + $(LTLIBINTL) \ + ../gnulib/lib/libgnu.la + # Manual pages and HTML files for the website. -man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-ls.1 +man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-ls.1 virt-tail.1 noinst_DATA = \ $(...

This adds a new tool which does a follow operation (ie. tail -f) on one or more log/text files inside the guest. I've only done limited testing, but it works for me for tailing various long-running builds inside guests which I'm doing at the moment. There are no tests at present. Rich.

...r)/src -I$(top_builddir)/src \ + -I$(top_srcdir)/fish \ + -I$(srcdir)/../gnulib/lib -I../gnulib/lib + +virt_tail_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(LIBXML2_CFLAGS) + +virt_tail_LDADD = \ + $(top_builddir)/src/libutils.la \ + $(top_builddir)/src/libguestfs.la \ + $(top_builddir)/fish/libfishcommon.la \ + $(LIBXML2_LIBS) \ + $(LIBVIRT_LIBS) \ + $(LTLIBINTL) \ + ../gnulib/lib/libgnu.la + # Manual pages and HTML files for the website. -man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-ls.1 +man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-ls.1 virt-tail.1 noinst_DATA = \ $(...

...ish \ > + -I$(srcdir)/../gnulib/lib -I../gnulib/lib > + > +virt_tail_CFLAGS = \ > + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ > + $(LIBXML2_CFLAGS) > + > +virt_tail_LDADD = \ > + $(top_builddir)/src/libutils.la \ > + $(top_builddir)/src/libguestfs.la \ > + $(top_builddir)/fish/libfishcommon.la \ > + $(LIBXML2_LIBS) \ > + $(LIBVIRT_LIBS) \ > + $(LTLIBINTL) \ > + ../gnulib/lib/libgnu.la > + > # Manual pages and HTML files for the website. > -man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-ls.1 > +man_MANS = virt-cat.1 virt-filesystems.1 virt-log.1 virt-...

Since v2: - Fix the things that Pino mentioned, except the recursion. - Implement Windows support. For Windows support to be sane, I had to inline the add_and_mount code. Rich.