search for: lguest_desc

Hello Rusty, while playing with your virtio descriptor code, I realized that the desc_pages data structure is not 64 bit safe. struct lguest_desc desc[NUM_DESCS] can be smaller than a page, as struct lguest_desc is 24 bytes on 64bit systems. Lets add a char padding to make the next page really page aligned. Btw. the new_io_desc.patch does not apply on current git. What base should I use? --- lguest_virtio.c.old 2007-08-17 10:15:05.000...

Hello Rusty, while playing with your virtio descriptor code, I realized that the desc_pages data structure is not 64 bit safe. struct lguest_desc desc[NUM_DESCS] can be smaller than a page, as struct lguest_desc is 24 bytes on 64bit systems. Lets add a char padding to make the next page really page aligned. Btw. the new_io_desc.patch does not apply on current git. What base should I use? --- lguest_virtio.c.old 2007-08-17 10:15:05.000...

...t needs to read the descriptor entries and the "pending" ring buffer, and write to the "used" ring buffer. We can use page protection to share these if we arrange things carefully, like so: struct desc_pages { /* Page of descriptors. */ struct lguest_desc desc[NUM_DESCS]; /* Next page: how we tell other side what buffers are available. */ unsigned int avail_idx; unsigned int available[NUM_DESCS]; char pad[PAGE_SIZE - (NUM_DESCS+1) * sizeof(unsigned int)]; /* Third page: how other side te...

...t needs to read the descriptor entries and the "pending" ring buffer, and write to the "used" ring buffer. We can use page protection to share these if we arrange things carefully, like so: struct desc_pages { /* Page of descriptors. */ struct lguest_desc desc[NUM_DESCS]; /* Next page: how we tell other side what buffers are available. */ unsigned int avail_idx; unsigned int available[NUM_DESCS]; char pad[PAGE_SIZE - (NUM_DESCS+1) * sizeof(unsigned int)]; /* Third page: how other side te...