search for: lgtmed

...quot;must have" to "suggested" and add something like "can be transformed to official status earlier if there is enough support from LLVM maintainers". We can even formalize what "enough support" means -- say, at least three maintainers employed by other companies LGTMed this. Yours, Andrey -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160729/3500a1d5/attachment.html>

...ingSet for symbol patterns which do not contain regex > metacharacters. There would still be a regex for any other patterns, > which would have anchors added automatically. > I think that it's fine to add anchors automatically to implement the behavior described in the docs (I've LGTMed that patch). Do you want to avoid adding anchors for dfsan SpecialCaseList? > > Thoughts? > > Thanks, > -- > Peter > > [1] https://code.google.com/p/address-sanitizer/wiki/AddressSanitizer > [2] https://code.google.com/p/thread-sanitizer/wiki/Flags > -- Alexey Sa...

On 29 Jul 2016 12:00 p.m., "Andrey Bokhanko" <andreybokhanko at gmail.com> wrote: > ...and this requirement pushes conversion of Lanai back-end to an official target status to Sep 28th as earliest. Just saying. > > [Personally, I believe that given the level of support, Lanai is already ready for an official status. But if we codify "must have" rules, they should

...quot; to "suggested" and add something > like "can be transformed to official status earlier if there is enough > support from LLVM maintainers". We can even formalize what "enough support" > means -- say, at least three maintainers employed by other companies LGTMed > this. A bit too specific, but I think we can make this work... I'll try again. cheers, --renato

Hi, I need to be able to use a special case list file containing thousands of entries (namely, a list of libc symbols, to be used when using DFSan with an uninstrumented libc). Initially I built the symbol list like this: fun:sym1=uninstrumented fun:sym2=uninstrumented fun:sym3=uninstrumented ... fun:sym6000=uninstrumented What I found was that, despite various bits of documentation [1,2], the

...opriate amount of time to wait before committing in this case." What I want to avoid is me (UK timezone) making some suggestions on a patch proposed by someone e.g. in the US, then a reviewer from the US getting into an active discussion, proposing a counter-suggestion, which gets adopted and LGTMed by that reviewer, resulting in a commit before I've had a chance to follow up on my comments etc. Obviously I can make post-commit requests, but sometimes it feels like the bar for suggestions post-commit is higher, and therefore my comments might not reach that level etc. James On Sat, 16 No...

Re-cap, after reviews. Main changes: * Making it clear that the "active community" behaviour is expected to continue throughout the target's lifetime. * Making it clear that only a reduced set of violation will be allowed in the experimental phase, providing the maintainers are taking the cost to move it to full compliance. * Trust, but verify: If the target's community

...mount of time to wait before committing in this case." > > What I want to avoid is me (UK timezone) making some suggestions on a patch proposed by someone e.g. in the US, then a reviewer from the US getting into an active discussion, proposing a counter-suggestion, which gets adopted and LGTMed by that reviewer, resulting in a commit before I've had a chance to follow up on my comments etc. Obviously I can make post-commit requests, but sometimes it feels like the bar for suggestions post-commit is higher, and therefore my comments might not reach that level etc. > > > I agre...

Hi, everyone, I've been fielding an increasing number of questions about how our code-review process in LLVM works from people who are new to our community, and it's been pointed out to me that our documentation on code reviews is both out of date and not as helpful as it could be to new developers.   http://llvm.org/docs/DeveloperPolicy.html#code-reviews I would like to compose a