search for: lewicka

On Thursday 12 February 2015 18:58:17 Margaret Lewicka wrote: > On 12 February 2015 at 18:50, Pino Toscano <ptoscano@redhat.com> wrote: > [...] > > We import gnulib as git submodule from the upstream gnulib.git, so > > this should be sent to its mailing list; see also > > https://www.gnu.org/software/gnulib/ > > &g...

On Mon, Feb 09, 2015 at 11:06:16AM +0000, Margaret Lewicka wrote: > gnulib's error.c requires program_name to be externally defined > for !_LIBC systems. This defines program_name for Darwin only. > --- > configure.ac | 3 +++ > src/Makefile.am | 6 ++++++ > src/program_name.c | 4 ++++ > 3 files changed, 13 insertions(+)...

On Wed, Feb 11, 2015 at 07:20:33PM +0000, Margaret Lewicka wrote: > On 11 February 2015 at 13:46, Richard W.M. Jones <rjones@redhat.com> wrote: > [...] > > On non-glibc, error.c says: > > > > /* The calling program should define program_name and set it to the > > name of the executing program. */ > > exte...

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

On Wed, Feb 11, 2015 at 09:52:59PM +0000, Margaret Lewicka wrote: > On 11 February 2015 at 19:23, Richard W.M. Jones <rjones@redhat.com> wrote: > > On Wed, Feb 11, 2015 at 07:20:33PM +0000, Margaret Lewicka wrote: > [...] > >> Proposing a patch to gnulib, even should they accept it, does not fix > >> the underlying issue...

On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: > On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > > Hello, > > > > I'm attempting to create a Homebrew formula to get libguestfs to > > compile on Mac OS X. I've managed to achieve success with several > > monkey patches, but since Homebrew's policy is to contact maintainers > > about prope...

On Mon, Feb 09, 2015 at 02:55:58PM +0000, Margaret Lewicka wrote: > On 9 February 2015 at 13:10, Daniel P. Berrange <berrange@redhat.com> wrote: > > On Mon, Feb 09, 2015 at 11:06:16AM +0000, Margaret Lewicka wrote: > >> gnulib's error.c requires program_name to be externally defined > >> for !_LIBC systems. This defines...

----- Forwarded message from Margaret Lewicka ----- Date: Sat, 16 Jul 2016 23:56:39 +0100 From: Margaret Lewicka To: "Richard W.M. Jones" Subject: Patch for hivex ruby library extension Hi, Attaching a patch that fixes hivex ruby bindings on Mac, if you're interested. Wasn't sure if it belonged on the libguestfs list, so m...

On Monday 09 February 2015 11:06:17 Margaret Lewicka wrote: > On JDK 8, doclint is enabled by default with strict validation of HTML > tags, which causes the build to fail. See > http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html > --- > java/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g...

On Thu, Feb 12, 2015 at 07:09:41PM +0000, Margaret Lewicka wrote: > On 12 February 2015 at 19:01, Pino Toscano <ptoscano@redhat.com> wrote: > > On Thursday 12 February 2015 18:58:17 Margaret Lewicka wrote: > [...] > >> This was requested by Richard in <20150211220126.GV11603@redhat.com>; > >> the hack^Wsolution is...

--- src/inspect-apps.c | 13 ++++++++++++- src/inspect-fs-windows.c | 6 ++++++ src/journal.c | 5 +++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 20cf00a..8fbae9c 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -35,11 +35,22 @@ #include <sys/endian.h> #endif -/* be32toh is usually a macro

On Thursday 12 February 2015 17:39:45 Margaret Lewicka wrote: > --- > lib/error.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/error.c b/lib/error.c > index 6683197..36a3db7 100644 > --- a/lib/error.c > +++ b/lib/error.c > @@ -113,9 +113,13 @@ int strerror_r (); > # endif > # endif > > +...

Including sys/un.h for sockaddr_un and sys/fcntl.h for O_CLOEXEC/O_NONBLOCK. --- src/launch-libvirt.c | 1 + src/launch-unix.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index 1649884..ad07210 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -52,6 +52,7 @@ /* Fixes for Mac OS X */ #if defined __APPLE__ &&

On 4 November 2015 at 12:37, Pino Toscano <ptoscano@redhat.com> wrote: [...] > NACK, these OS-specific blocks are hard to maintain, and it makes no > sense to enclose POSIX headers in them. > > Can you please try the attached patch? I see Rich already pushed your > patch, but IMHO that should be reverted and this one should go... Happy to. However, these same header files

Hello, I'm attempting to create a Homebrew formula to get libguestfs to compile on Mac OS X. I've managed to achieve success with several monkey patches, but since Homebrew's policy is to contact maintainers about proper fixes in upstream, I would like to ask if there are any plans to fix these issues. I'm afraid I don't know C well enough to propose decent solutions myself.

Hello, Are there any chances of next stable release appearing soonish? I'm getting pushback from Homebrew maintainers about the massive amount of patching required to build the current stable on Mac, since all the patches have been merged in after last stable. (I'm also getting pushback about the 4GB download of virtual appliance, but as I understand that one is non-optional. Don't

On Wednesday 04 November 2015 12:05:31 Margaret Lewicka wrote: > Including sys/un.h for sockaddr_un and sys/fcntl.h for > O_CLOEXEC/O_NONBLOCK. > --- > src/launch-libvirt.c | 1 + > src/launch-unix.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c > index 1649884.....

On Wed, Nov 04, 2015 at 12:43:31PM +0000, Margaret Lewicka wrote: > On 4 November 2015 at 12:37, Pino Toscano <ptoscano@redhat.com> wrote: > [...] > > > NACK, these OS-specific blocks are hard to maintain, and it makes no > > sense to enclose POSIX headers in them. > > > > Can you please try the attached patch? I see...

[Let's keep the replies on the mailing list] On Fri, Feb 06, 2015 at 11:06:45AM +0000, Margaret Lewicka wrote: > https://gist.github.com/shulima/981973b7500b2adaac88 Just a note that the the file which is patched here is actually generated, so the source file in git is `generator/java.ml'. In Fedora, we have something called java-1.8.0-openjdk-headless. Is that the same as Java[doc] 8? Rich...

On Mon, Feb 09, 2015 at 10:56:54AM +0100, Pino Toscano wrote: > On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote: > > On Thu, Feb 05, 2015 at 10:53:06PM +0000, Margaret Lewicka wrote: > > > +/* Fixes for Mac OS X */ > > > +#if defined __APPLE__ && defined __MACH__ > > > +#include <sys/un.h> > > > +#endif > > > +#ifndef SOCK_CLOEXEC > > > +# define SOCK_CLOEXEC O_CLOEXEC > > > +#endif > > &g...