search for: let's

I have the following vector of strings (shown only the first 3 elements) > desc[1:3] [1] "hsa-let-7a MIMAT0000062 Homo sapiens let-7a" [2] "hsa-let-7a* MIMAT0004481 Homo sapiens let-7a*" [3] "hsa-let-7a-2* MIMAT0010195 Homo sapiens let-7a-2*" > is.vector(desc) [1] TRUE > A <- unlist(strsplit(desc[1:3], " ")) > A [1] "hsa-let-7a MIM...

...output_rhev.ml | 4 +- v2v/output_vdsm.ml | 2 +- v2v/test-harness/v2v_test_harness.ml | 2 +- v2v/utils.ml | 16 +-- v2v/v2v.ml | 2 +- 39 files changed, 246 insertions(+), 239 deletions(-) diff --git a/builder/checksums.ml b/builder/checksums.ml index 5663832..31d3cb3 100644 --- a/builder/checksums.ml +++ b/builder/checksums.ml @@ -49,7 +49,7 @@ let verify_checksum csum filename = | [] -> error (f_"%s did not return any output") prog | line :: _ ->...

--- sysprep/sysprep_operation.mli | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sysprep/sysprep_operation.mli b/sysprep/sysprep_operation.mli index 61dde72..eb89db4 100644 --- a/sysprep/sysprep_operation.mli +++ b/sysprep/sysprep_operation.mli @@ -16,14 +16,16 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *) -(** Structure used to d...

...sysprep/sysprep_operation_udev_persistent_net.ml | 7 +++++-- sysprep/sysprep_operation_utmp.ml | 7 +++++-- sysprep/sysprep_operation_yum_uuid.ml | 8 ++++++-- sysprep/utils.ml | 4 ++++ 18 files changed, 92 insertions(+), 32 deletions(-) diff --git a/sysprep/main.ml b/sysprep/main.ml index d06b0d2..7d3ce5e 100644 --- a/sysprep/main.ml +++ b/sysprep/main.ml @@ -29,7 +29,7 @@ let () = Sysprep_operation.bake () (* Command line argument parsing. *) let prog = Filename.basename Sys.executable_name -let debug_gc, operations,...

Through converting a miRNAs file from FASTA to character format I get a vector which looks like the following: > nml [1] "hsa-let-7a MIMAT0000062 Homo sapiens let-7a" [2] "hsa-let-7b MIMAT0000063 Homo sapiens let-7b" [3] "hsa-let-7c MIMAT0000064 Homo sapiens let-7c" [4] "hsa-let-7d MIMAT0000065 Homo sapiens let-7d" [5] "hsa-let-7e...

Hide/prevent the use of bad string functions like String.lowercase. These are replaced by safe functions that won't break UTF-8 strings. Other miscellaneous refactoring. Rich.

v2 -> v3: - Renamed List.assoc_ -> List.assoc_lbl. - Rebased on top of current master branch. Rich.

In Std_utils we already extend Char and String. These commits take it a little further by extending List and adding a new Option submodule. All basically simple refactoring. Rich.

...e. --- po/POTFILES-ml | 1 + v2v/Makefile.am | 2 + v2v/bootloaders.ml | 317 +++++++++++++++++++++++++++++++++++++++++++++++++++ v2v/bootloaders.mli | 44 +++++++ v2v/convert_linux.ml | 284 ++------------------------------------------- 5 files changed, 376 insertions(+), 272 deletions(-) create mode 100644 v2v/bootloaders.ml create mode 100644 v2v/bootloaders.mli diff --git a/po/POTFILES-ml b/po/POTFILES-ml index b7b39fa..35325d9 100644 --- a/po/POTFILES-ml +++ b/po/POTFILES-ml @@ -105,6 +105,7 @@ sysprep/sysprep_operation_utmp.ml sysprep/sysprep_operation_yum_uuid.ml v...

This time including the first commit ...

...ep/sysprep_operation_ssh_hostkeys.ml | 2 +- > sysprep/sysprep_operation_ssh_userdir.ml | 2 +- > sysprep/sysprep_operation_sssd_db_log.ml | 2 +- > sysprep/sysprep_operation_tmp_files.ml | 2 +- > 25 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/get-kernel/get_kernel.ml b/get-kernel/get_kernel.ml > index 812138f..6f26ca4 100644 > --- a/get-kernel/get_kernel.ml > +++ b/get-kernel/get_kernel.ml > @@ -149,7 +149,7 @@ let rec do_fetch ~transform_fn ~outputdir g root = > > g#umount_all () &g...

...++++------------------------------------------- generator/utils.mli | 64 +----------------- mllib/common_utils.ml | 126 ++++++++++++++++++++++++++++++---- mllib/common_utils.mli | 76 ++++++++++++++++++--- v2v/convert_windows.ml | 3 +- 25 files changed, 373 insertions(+), 364 deletions(-) diff --git a/.gitignore b/.gitignore index 633b39d..da59e44 100644 --- a/.gitignore +++ b/.gitignore @@ -255,8 +255,11 @@ Makefile.in /fuse/test-guestunmount-fd /generator/.depend /generator/bytes.ml +/generator/common_utils.ml +/generator/common_utils.mli /generator/files-generated.txt...

A couple of patches cleaning up the -i ova code. These are both just refactoring (or should be at any rate). The second patch is best viewed with 'git show -w' to exclude whitespace changes. Rich.

...| 2 +- sysprep/sysprep_operation_ssh_hostkeys.ml | 2 +- sysprep/sysprep_operation_ssh_userdir.ml | 2 +- sysprep/sysprep_operation_sssd_db_log.ml | 2 +- sysprep/sysprep_operation_tmp_files.ml | 2 +- 25 files changed, 25 insertions(+), 25 deletions(-) diff --git a/get-kernel/get_kernel.ml b/get-kernel/get_kernel.ml index 812138f..6f26ca4 100644 --- a/get-kernel/get_kernel.ml +++ b/get-kernel/get_kernel.ml @@ -149,7 +149,7 @@ let rec do_fetch ~transform_fn ~outputdir g root = g#umount_all () -and pick_kernel_files_linux g root = +a...

...much see the point versus an implementation which used a type Bootloader.t declared as: type t = Grub1 of <any local data grub1 needs> | Grub2 of <any local data grub2 needs> (and not exposed through the mli file). As this is to some extent my personal preference, I'll let it slide. I checked all of the code and it appears to be correct and there is nothing omitted from the current implementation. Rich. > +(* Helper type used in detect_bootloader. *) > +type bootloader_type = > + | Grub1 > + | Grub2 > + > +(* Helper function for SUSE: remove (h...

...a commits to almost finish the job of replacing Str everywhere possible (note it's not possible to replace Str in common/mlstdutils or the generator because those are pure OCaml). As before there is an outstanding question: > I wonder if there was a deep reason why we had this? > > let unix2dos s = > String.concat "\r\n" (Str.split_delim (Str.regexp_string "\n") s) > > I replaced it with what I think should be (nearly) equivalent: > > let unix2dos s = > String.concat "\r\n" (String.nsplit "\n" s) Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html This is a more complete evolution of the earlier patch. It replaces most important uses of Str with PCRE throughout the code. It also extends the bindings with some useful features like case-insensitive regexps. The main places I *didn't* touch are the generator (GObject uses Str extensively); and common/mlstdutil...

...s with multiple results. --- common/mltools/xpath_helpers.ml | 9 +++++++ common/mltools/xpath_helpers.mli | 4 +++ v2v/output_libvirt.ml | 11 ++------ v2v/test-harness/v2v_test_harness.ml | 51 +++++++++++------------------------- 4 files changed, 30 insertions(+), 45 deletions(-) diff --git a/common/mltools/xpath_helpers.ml b/common/mltools/xpath_helpers.ml index 3afee8b21..d2bfd3fb9 100644 --- a/common/mltools/xpath_helpers.ml +++ b/common/mltools/xpath_helpers.ml @@ -40,3 +40,12 @@ let xpath_eval parsefn xpathctx expr = let xpath_string = xpath_eval identity let...

When importing from VMware via the libvirt driver, the libvirt driver can add an empty source bridge name: <interface type='bridge'> <mac address='00:01:02:03:04:05:06'/> <source bridge=''/> </interface> Replicate what we do on the -i ova path, and map these to "eth0", "eth1" etc. This also includes a bunch

...ge. --- po/POTFILES-ml | 1 + v2v/Makefile.am | 2 + v2v/bootloaders.ml | 317 +++++++++++++++++++++++++++++++++++++++++++++++++++ v2v/bootloaders.mli | 44 +++++++ v2v/convert_linux.ml | 274 ++------------------------------------------ 5 files changed, 375 insertions(+), 263 deletions(-) create mode 100644 v2v/bootloaders.ml create mode 100644 v2v/bootloaders.mli diff --git a/po/POTFILES-ml b/po/POTFILES-ml index 00a9d63..a9b0b59 100644 --- a/po/POTFILES-ml +++ b/po/POTFILES-ml @@ -97,6 +97,7 @@ sysprep/sysprep_operation_utmp.ml sysprep/sysprep_operation_yum_uuid.ml v2v...