search for: lesokhin

On Sun, Oct 29, 2017 at 02:34:56PM +0000, Ilya Lesokhin wrote: > > -----Original Message----- > > From: Michael S. Tsirkin [mailto:mst at redhat.com] > > Sent: Sunday, October 29, 2017 4:22 PM > > To: Ilya Lesokhin <ilyal at mellanox.com> > > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-founda...

On Sun, Oct 29, 2017 at 02:34:56PM +0000, Ilya Lesokhin wrote: > > -----Original Message----- > > From: Michael S. Tsirkin [mailto:mst at redhat.com] > > Sent: Sunday, October 29, 2017 4:22 PM > > To: Ilya Lesokhin <ilyal at mellanox.com> > > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-founda...

If you do this whats the point of the id? Just use descriptor offset like virtio 0 did. On Sun, Oct 29, 2017 at 09:05:01AM +0000, Ilya Lesokhin wrote: > My point was that if the driver is not required to change the IDs, > it can initialized the ID's in all the descriptors when the ring is created > and never write the ID field again. > > A simple allocator for the IDs can solve the problem I presented but it is still mo...

If you do this whats the point of the id? Just use descriptor offset like virtio 0 did. On Sun, Oct 29, 2017 at 09:05:01AM +0000, Ilya Lesokhin wrote: > My point was that if the driver is not required to change the IDs, > it can initialized the ID's in all the descriptors when the ring is created > and never write the ID field again. > > A simple allocator for the IDs can solve the problem I presented but it is still mo...

On Sun, Oct 08, 2017 at 06:16:44AM +0000, Ilya Lesokhin wrote: > > > -----Original Message----- > > > From: virtualization-bounces at lists.linux-foundation.org > > > [mailto:virtualization-bounces at lists.linux-foundation.org] On Behalf > > > Of Michael S. Tsirkin > > > > > > This is an update from...

On Sun, Oct 08, 2017 at 06:16:44AM +0000, Ilya Lesokhin wrote: > > > -----Original Message----- > > > From: virtualization-bounces at lists.linux-foundation.org > > > [mailto:virtualization-bounces at lists.linux-foundation.org] On Behalf > > > Of Michael S. Tsirkin > > > > > > This is an update from...

> -----Original Message----- > From: Michael S. Tsirkin [mailto:mst at redhat.com] > Sent: Monday, October 30, 2017 4:09 AM > To: Ilya Lesokhin <ilyal at mellanox.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org > Subject: Re: packed ring layout proposal v3 > > On Sun, Oct 29, 2017 at 02:34:56PM +0000, Ilya Lesokhin wrote: > > > -----Original Message----- > > >...

On Thu, Nov 02, 2017 at 11:40:36AM +0000, Ilya Lesokhin wrote: > Hi, > I've noticed that the virtio-net uses skb->cb. > > I don't know all the detail by my understanding is it caused problem with the mlx5 driver > and was fixed here: > https://github.com/torvalds/linux/commit/34802a42b3528b0e18ea4517c8b23e1214a09332 > &...

On Thu, Nov 02, 2017 at 11:40:36AM +0000, Ilya Lesokhin wrote: > Hi, > I've noticed that the virtio-net uses skb->cb. > > I don't know all the detail by my understanding is it caused problem with the mlx5 driver > and was fixed here: > https://github.com/torvalds/linux/commit/34802a42b3528b0e18ea4517c8b23e1214a09332 > &...

...field again. A simple allocator for the IDs can solve the problem I presented but it is still more expensive then not doing ID allocation at all. > -----Original Message----- > From: Michael S. Tsirkin [mailto:mst at redhat.com] > Sent: Wednesday, October 25, 2017 7:20 PM > To: Ilya Lesokhin <ilyal at mellanox.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org > Subject: Re: packed ring layout proposal v3 > > On Sun, Oct 08, 2017 at 06:16:44AM +0000, Ilya Lesokhin wrote: > > > > -----Original Message----- > >...

> -----Original Message----- > From: Michael S. Tsirkin [mailto:mst at redhat.com] > Sent: Sunday, October 29, 2017 4:22 PM > To: Ilya Lesokhin <ilyal at mellanox.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org > Subject: Re: packed ring layout proposal v3 > > If you do this whats the point of the id? Just use descriptor offset like virtio 0 did. > I agree that ID is point...

Hi, I have a concern about the portability of offloading the new VIRTIO packed ring format to hardware. According to the PCIe rev 2.0, paragraph 2.4.2. Update Ordering and Granularity Observed by a Read Transaction" " if a host CPU writes a QWORD to host memory, a Requester reading that QWORD from host memory may observe a portion of the QWORD updated and another portion of it

On Wed, Nov 01, 2017 at 03:52:12PM +0000, Ilya Lesokhin wrote: > On Wednesday, November 01, 2017 4:59 PM, Michael S. Tsirkin wrote: > > > On Sun, Oct 29, 2017 at 01:52:25PM +0100, Jens Freimann wrote: > > > Ilya: - you might have more completions than descriptors available > > > - partial descriptor chains are a problem fo...

On Wed, Nov 01, 2017 at 06:12:09PM +0000, Ilya Lesokhin wrote: > On Wednesday, November 1, 2017 7:35 PM, Michael S. Tsirkin wrote: > > > You have to either use and additional descriptor for metadata per chain. > > > Or putting it in one of the buffers and forcing the lifetime of the metadata > > and data to be the same. > &...

Virtio BoF minutes KVM Forum 2017 Attendees: Amnon Ilan, Maxime Coqueline, Vlad Yasevich, Malcolm Crossley, David Vrabel, Ilya Lesokhin, Cunming Lian, Jens Freimann Topics: packed ring layout with respect to hardware implementations References: https://lists.oasis-open.org/archives/virtio-dev/201702/msg00010.html https://lists.oasis-open.org/archives/virtio-dev/201709/msg00013.html Malcolm Crossley, David Vrabel: - keep in min...

Virtio BoF minutes KVM Forum 2017 Attendees: Amnon Ilan, Maxime Coqueline, Vlad Yasevich, Malcolm Crossley, David Vrabel, Ilya Lesokhin, Cunming Lian, Jens Freimann Topics: packed ring layout with respect to hardware implementations References: https://lists.oasis-open.org/archives/virtio-dev/201702/msg00010.html https://lists.oasis-open.org/archives/virtio-dev/201709/msg00013.html Malcolm Crossley, David Vrabel: - keep in min...

On Wednesday, November 01, 2017 4:59 PM, Michael S. Tsirkin wrote: > On Sun, Oct 29, 2017 at 01:52:25PM +0100, Jens Freimann wrote: > > Ilya: - you might have more completions than descriptors available > > - partial descriptor chains are a problem for hardware because you > > might have to read a bunch of conscriptors twice - how would you do > > deal with a big

On Wednesday, November 01, 2017 4:59 PM, Michael S. Tsirkin wrote: > On Sun, Oct 29, 2017 at 01:52:25PM +0100, Jens Freimann wrote: > > Ilya: - you might have more completions than descriptors available > > - partial descriptor chains are a problem for hardware because you > > might have to read a bunch of conscriptors twice - how would you do > > deal with a big

On Wednesday, November 1, 2017 7:35 PM, Michael S. Tsirkin wrote: > > You have to either use and additional descriptor for metadata per chain. > > Or putting it in one of the buffers and forcing the lifetime of the metadata > and data to be the same. > > That's true. It would be easy to make descriptors e.g. 32 bytes each, so > you can add extra data in there. Or if we

On Wednesday, November 1, 2017 7:35 PM, Michael S. Tsirkin wrote: > > You have to either use and additional descriptor for metadata per chain. > > Or putting it in one of the buffers and forcing the lifetime of the metadata > and data to be the same. > > That's true. It would be easy to make descriptors e.g. 32 bytes each, so > you can add extra data in there. Or if we