search for: leonro

On Thu, Jan 26, 2023 at 09:15:03PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro at nvidia.com> > > In netdev common pattern, xxtack pointer is forwarded to the drivers ~~~~~~ extack > to be filled with error message. However, the caller can easily > overwrite the filled message. > > Instead of addi...

On Fri, 27 Jan 2023 00:32:13 +0200 Vladimir Oltean wrote: > On Thu, Jan 26, 2023 at 09:15:03PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro at nvidia.com> > > > > In netdev common pattern, xxtack pointer is forwarded to the drivers > ~~~~~~ > extack > > > to be filled with error message. However, the caller can easily > > overwrite the fille...

From: Leon Romanovsky <leonro at nvidia.com> In netdev common pattern, xxtack pointer is forwarded to the drivers to be filled with error message. However, the caller can easily overwrite the filled message. Instead of adding multiple "if (!extack->_msg)" checks before any NL_SET_ERR_MSG() call, which appears...

From: Leon Romanovsky <leonro at nvidia.com> Changelog: v1: * Renamed _mlx5_rescan_driver to be mlx5_rescan_driver_locked like in other parts of the mlx5 driver. * Renamed MLX5_INTERFACE_PROTOCOL_VDPA to tbe MLX5_INTERFACE_PROTOCOL_VNET as a preparation to coming series from Eli C. * Some small naming renames in ml...

...e the filled message. Instead of adding multiple "if (!extack->_msg)" checks before any NL_SET_ERR_MSG() call, which appears after call to the driver, let's add new macro to common code. [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal Signed-off-by: Leon Romanovsky <leonro at nvidia.com> --- Changelog: v2: * Removed () brackets around msg to fix compilation error. v1: https://lore.kernel.org/all/d4843760219f20367c27472f084bd8aa729cf321.1674995155.git.leon at kernel.org * Added special *_WEAK() macro instead of embedding same check in NL_SET_ERR_MSG_MOD/NL_SET...

...stead of adding multiple "if (!extack->_msg)" checks before any > NL_SET_ERR_MSG() call, which appears after call to the driver, let's > add new macro to common code. > > [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal > Signed-off-by: Leon Romanovsky <leonro at nvidia.com> I'm sorry for nit-picking, but checkpatch complains the author (leon at kernel.org) does not match the SoB tag. A v3 with a suitable From: tag should fix that. Thanks, Paolo

On Fri, Jan 27, 2023 at 12:32:13AM +0200, Vladimir Oltean wrote: > On Thu, Jan 26, 2023 at 09:15:03PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro at nvidia.com> > > > > In netdev common pattern, xxtack pointer is forwarded to the drivers > ~~~~~~ > extack > > > to be filled with error message. However, the caller can easily > > overwrite the filled...

...irst' Signed-off-by: Randy Dunlap <rdunlap at infradead.org> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: virtualization at lists.linux-foundation.org Cc: Saeed Mahameed <saeedm at nvidia.com> Cc: Leon Romanovsky <leonro at nvidia.com> Cc: netdev at vger.kernel.org --- v2: change from select to depends (Saeed) drivers/vdpa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200917/drivers/vdpa/Kconfig @@ -31,7 +31,7 @@ config IFCV...

On Mon, Nov 02, 2020 at 05:07:59AM +0000, Parav Pandit wrote: > > > > From: Leon Romanovsky <leon at kernel.org> > > Sent: Monday, November 2, 2020 1:46 AM > > > > From: Leon Romanovsky <leonro at nvidia.com> > > > > Remove exposed driver version as it was done in other drivers, so module > > version will work correctly by displaying the kernel version for which it is > > compiled. > > > > And move mlx5_core module name to general include, so auxilia...

...irst' Signed-off-by: Randy Dunlap <rdunlap at infradead.org> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: virtualization at lists.linux-foundation.org Cc: Saeed Mahameed <saeedm at nvidia.com> Cc: Leon Romanovsky <leonro at nvidia.com> Cc: netdev at vger.kernel.org --- Note: This patch may not be the right thing, but it fixes the build errors. drivers/vdpa/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200917/drivers/vdpa/Kconfig @@ -32,6 +3...

...irst' Signed-off-by: Randy Dunlap <rdunlap at infradead.org> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: virtualization at lists.linux-foundation.org Cc: Saeed Mahameed <saeedm at nvidia.com> Cc: Leon Romanovsky <leonro at nvidia.com> Cc: netdev at vger.kernel.org --- v2: change from select to depends on VHOST (Saeed) v3: change to depends on VHOST_IOTLB (Jason) drivers/vdpa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200...

...at infradead.org> > > Cc: "Michael S. Tsirkin" <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Cc: virtualization at lists.linux-foundation.org > > Cc: Saeed Mahameed <saeedm at nvidia.com> > > Cc: Leon Romanovsky <leonro at nvidia.com> > > Cc: netdev at vger.kernel.org > > --- > > v2: change from select to depends on VHOST (Saeed) > > v3: change to depends on VHOST_IOTLB (Jason) > > > > drivers/vdpa/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) &g...