search for: len_r

...| ^~~~~~~~~~~~~~~ | | | size_t * {aka unsigned int *} test-mech.c:195:77: note: expected ?long unsigned int *? but argument is of type ?size_t *? {aka ?unsigned int *?} 195 | test_mech_construct_apop_challenge(unsigned int connect_uid, unsigned long *len_r) | ~~~~~~~~~~~~~~~^~~~~ But the unit test still fails after a commit like: diff --git a/src/auth/test-mech.c b/src/auth/test-mech.c index cf05370..90c2215 100644 --- a/src/auth/test-mech.c +++ b/src/auth/test-mech.c @@ -192,7 +192,7 @@ static void test_mech_handle_challenge(struct auth_req...

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

These patches first make src/ warning free, and then turn on the strict warning options. 75 0001-build-suppress-an-ignored-write-return-value-warning.patch 38 0002-build-suppress-an-ignored-dup-return-value-warning.patch 27 0003-generator.ml-suppress-signed-unsigned-compare-warnin.patch 48 0004-build-don-t-perform-arithmetic-on-void-pointers.patch 30

...loc (g, ctx->chunks, - sizeof (guestfs_chunk) * (ctx->count+1)); + sizeof (guestfs_chunk) * (ctx->count+1)); ctx->chunks[ctx->count] = chunk; ctx->count++; } @@ -2448,7 +2448,7 @@ receive_file_data_sync (guestfs_h *g, void **buf, size_t *len_r) if (buf) { *buf = safe_realloc (g, *buf, len + ctx.chunks[i].data.data_len); memcpy (*buf+len, ctx.chunks[i].data.data_val, - ctx.chunks[i].data.data_len); + ctx.chunks[i].data.data_len); } len += ctx.chunks[i].data.data_len; } @@ -2462,7 +2462,7...