search for: legacy_on

legacy_only flag is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index d666bcb..d09e093 100644 --...

legacy_only flag is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index d666bcb..d09e093 100644 --...

...2,7 @@ int virtio_device_restore(struct virtio_device *dev); * @feature_table_size: number of entries in the feature table array. * @feature_table_legacy: same as feature_table but when working in legacy mode. * @feature_table_size_legacy: number of entries in feature table legacy array. + * @legacy_only: driver does not support virtio 1.0. * @probe: the function to call when a device is found. Returns 0 or -errno. * @remove: the function to call when a device is removed. * @config_changed: optional function to call when the device configuration @@ -144,6 +145,7 @@ struct virtio_driver {...

...2,7 @@ int virtio_device_restore(struct virtio_device *dev); * @feature_table_size: number of entries in the feature table array. * @feature_table_legacy: same as feature_table but when working in legacy mode. * @feature_table_size_legacy: number of entries in feature table legacy array. + * @legacy_only: driver does not support virtio 1.0. * @probe: the function to call when a device is found. Returns 0 or -errno. * @remove: the function to call when a device is removed. * @config_changed: optional function to call when the device configuration @@ -144,6 +145,7 @@ struct virtio_driver {...

...--git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4497def..c9703d4 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -518,7 +518,6 @@ static unsigned int features[] = { }; static struct virtio_driver virtio_balloon_driver = { - .legacy_only = true, .feature_table = features, .feature_table_size = ARRAY_SIZE(features), .driver.name = KBUILD_MODNAME, -- MST

...--git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4497def..c9703d4 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -518,7 +518,6 @@ static unsigned int features[] = { }; static struct virtio_driver virtio_balloon_driver = { - .legacy_only = true, .feature_table = features, .feature_table_size = ARRAY_SIZE(features), .driver.name = KBUILD_MODNAME, -- MST

balloon device is not part of virtio 1.0 spec. Still, it's easy enough to make it handle endian-ness exactly as other virtio 1.0 devices: what we gain from this, is that there's no need to special-case it in virtio core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 5 +++-- drivers/virtio/virtio_balloon.c | 4 ++-- 2 files

balloon device is not part of virtio 1.0 spec. Still, it's easy enough to make it handle endian-ness exactly as other virtio 1.0 devices: what we gain from this, is that there's no need to special-case it in virtio core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_balloon.h | 5 +++-- drivers/virtio/virtio_balloon.c | 4 ++-- 2 files

...shouldn't normally fail, but checking can't hurt. Michael S. Tsirkin (6): virtio: add API to detect legacy devices virtio_ccw: legacy: don't negotiate rev 1/features virtio: allow finalize_features to fail virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 virtio_balloon: drop legacy_only driver flag virtio: drop legacy_only driver flag include/linux/virtio.h | 4 ++-- include/linux/virtio_config.h | 3 ++- drivers/lguest/lguest_device.c | 4 +++- drivers/misc/mic/card/mic_virtio.c | 4 +++- drivers/remoteproc/remoteproc_virtio.c | 4 +...

...shouldn't normally fail, but checking can't hurt. Michael S. Tsirkin (6): virtio: add API to detect legacy devices virtio_ccw: legacy: don't negotiate rev 1/features virtio: allow finalize_features to fail virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 virtio_balloon: drop legacy_only driver flag virtio: drop legacy_only driver flag include/linux/virtio.h | 4 ++-- include/linux/virtio_config.h | 3 ++- drivers/lguest/lguest_device.c | 4 +++- drivers/misc/mic/card/mic_virtio.c | 4 +++- drivers/remoteproc/remoteproc_virtio.c | 4 +...

...es, I forgot about that. > But I'm not quite sure the spec covers this? The spec does not cover balloon. It merely includes a reference section about legacy balloon device. What to do when that device sets VERSION_1 is really up to us. Patchset v8 simply makes balloon tell core it's legacy_only. This is I guess fine as far as it goes. I was still looking for the best way that involves minimal noise in core. This looked like the best way: change 4 lines, and drop all special casing in core, but given the config space endian-ness mess, I'm not sure anymore. I guess we'll just stic...

...es, I forgot about that. > But I'm not quite sure the spec covers this? The spec does not cover balloon. It merely includes a reference section about legacy balloon device. What to do when that device sets VERSION_1 is really up to us. Patchset v8 simply makes balloon tell core it's legacy_only. This is I guess fine as far as it goes. I was still looking for the best way that involves minimal noise in core. This looked like the best way: change 4 lines, and drop all special casing in core, but given the config space endian-ness mess, I'm not sure anymore. I guess we'll just stic...

...virtio headers macvtap: TUN_VNET_LE support virtio_scsi: v1.0 support virtio_scsi: move to uapi virtio_scsi: export to userspace vhost/scsi: partial virtio 1.0 support af_packet: virtio 1.0 stubs virtio_console: virtio 1.0 support virtio_balloon: add legacy_only flag virtio: make VIRTIO_F_VERSION_1 a transport bit virtio: drop VIRTIO_F_VERSION_1 from drivers virtio_console: fix sparse warnings virtio: add API to detect legacy devices virtio_ccw: legacy: don't negotiate rev 1/features virtio: allow finalize_features...

...virtio headers macvtap: TUN_VNET_LE support virtio_scsi: v1.0 support virtio_scsi: move to uapi virtio_scsi: export to userspace vhost/scsi: partial virtio 1.0 support af_packet: virtio 1.0 stubs virtio_console: virtio 1.0 support virtio_balloon: add legacy_only flag virtio: make VIRTIO_F_VERSION_1 a transport bit virtio: drop VIRTIO_F_VERSION_1 from drivers virtio_console: fix sparse warnings virtio: add API to detect legacy devices virtio_ccw: legacy: don't negotiate rev 1/features virtio: allow finalize_features...

Activate VIRTIO_F_VERSION_1 automatically unless legacy_only is set. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 4 ++-- drivers/virtio/virtio.c | 6 +++++- drivers/virtio/virtio_ring.c | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/virtio...

Activate VIRTIO_F_VERSION_1 automatically unless legacy_only is set. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 4 ++-- drivers/virtio/virtio.c | 6 +++++- drivers/virtio/virtio_ring.c | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/virtio...

...choosing GL_UNSIGNED_INT_8_8_8_8 as the representation seemed to also remedy this. I found that the _REV variant didn't byte swap the textures back to the incorrect ordering (this is probably a different bug). Easiest way to demonstrate the bug: svn co https://svn.code.sf.net/p/doomlegacy/svn/legacy_one/trunk doomlegacy cd doomlegacy make OS=LINUX make cd bin Grab this archive: https://sourceforge.net/projects/doomlegacy/files/1.47.2/doomlegacy_1.47.2_common.zip/download, unzip it, extract legacy.wad into the bin directory Grab this archive: https://github.com/freedoom/freedoom/releases/download/...