search for: last_used

...t; + kfree(desc); > + vq->desc_state_packed[id].indir_desc = NULL; > + } else if (ctx) { > + *ctx = vq->desc_state_packed[id].indir_desc; > + } > } > > static inline bool more_used_packed(const struct vring_virtqueue *vq) > { > - return false; > + u16 last_used, flags; > + u8 avail, used; > + > + last_used = vq->last_used_idx; > + flags = virtio16_to_cpu(vq->vq.vdev, > + vq->vring_packed.desc[last_used].flags); > + avail = !!(flags & VRING_DESC_F_AVAIL(1)); > + used = !!(flags & VRING_DESC_F_USED(1)); > + > +...

...t; + kfree(desc); > + vq->desc_state_packed[id].indir_desc = NULL; > + } else if (ctx) { > + *ctx = vq->desc_state_packed[id].indir_desc; > + } > } > > static inline bool more_used_packed(const struct vring_virtqueue *vq) > { > - return false; > + u16 last_used, flags; > + u8 avail, used; > + > + last_used = vq->last_used_idx; > + flags = virtio16_to_cpu(vq->vq.vdev, > + vq->vring_packed.desc[last_used].flags); > + avail = !!(flags & VRING_DESC_F_AVAIL(1)); > + used = !!(flags & VRING_DESC_F_USED(1)); > + > +...

...nmap_one_packed(vq, &desc[j]); + + kfree(desc); + vq->desc_state[id].indir_desc = NULL; + } else if (ctx) { + *ctx = vq->desc_state[id].indir_desc; + } + +out: + free_id_packed(vq, id); } static inline bool more_used_packed(const struct vring_virtqueue *vq) { - return false; + u16 last_used, flags; + bool avail, used; + + if (vq->vq.num_free == vq->vring_packed.num) + return false; + + last_used = vq->last_used_idx; + flags = virtio16_to_cpu(vq->vq.vdev, + vq->vring_packed.desc[last_used].flags); + avail = flags & VRING_DESC_F_AVAIL(1); + used = flags & VRIN...

Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost: https://lkml.org/lkml/2018/4/23/12 Both of ping and netperf worked as expected (with EVENT_IDX disabled). TODO: - Refinements (for code and commit log); - More tests; - Bug fixes; RFC v3 -> RFC v4: - Make ID allocation

First of all I would like to thank Mark for getting roundrobin to go roundrobin. Good job. Now we have some options here for leastrecent and fewestcalls strategy. It needs some work on the logic and Mark recommend that I ask the list and get some input before he makes any changes to it. fewestcalls from what I have seen would always ring the agent with the fewestcalls first then go into

...->num_added++) & (vq->vring.num-1)); vq->vring.avail->ring[avail] = head; pr_debug("Added buffer head %i to %p\n", head, vq); @@ -317,6 +317,7 @@ void *virtqueue_get_buf(struct virtqueue struct vring_virtqueue *vq = to_vvq(_vq); void *ret; unsigned int i; + u16 last_used; START_USE(vq); @@ -334,8 +335,9 @@ void *virtqueue_get_buf(struct virtqueue /* Only get used array entries after they have been exposed by host. */ virtio_rmb(); - i = vq->vring.used->ring[vq->last_used_idx%vq->vring.num].id; - *len = vq->vring.used->ring[vq->last_...

...->num_added++) & (vq->vring.num-1)); vq->vring.avail->ring[avail] = head; pr_debug("Added buffer head %i to %p\n", head, vq); @@ -317,6 +317,7 @@ void *virtqueue_get_buf(struct virtqueue struct vring_virtqueue *vq = to_vvq(_vq); void *ret; unsigned int i; + u16 last_used; START_USE(vq); @@ -334,8 +335,9 @@ void *virtqueue_get_buf(struct virtqueue /* Only get used array entries after they have been exposed by host. */ virtio_rmb(); - i = vq->vring.used->ring[vq->last_used_idx%vq->vring.num].id; - *len = vq->vring.used->ring[vq->last_...

...packed_desc); j++) + vring_unmap_one_packed(vq, &desc[j]); + + kfree(desc); + vq->desc_state[head].indir_desc = NULL; + } else if (ctx) { + *ctx = vq->desc_state[head].indir_desc; + } } static inline bool more_used_packed(const struct vring_virtqueue *vq) { - return false; + u16 last_used, flags; + bool avail, used; + + if (vq->vq.num_free == vq->vring_packed.num) + return false; + + last_used = vq->last_used_idx; + flags = virtio16_to_cpu(vq->vq.vdev, + vq->vring_packed.desc[last_used].flags); + avail = flags & VRING_DESC_F_AVAIL(1); + used = flags & VRIN...

...); i++) + vring_unmap_desc_packed(vq, &desc[i]); + + kfree(desc); + vq->desc_state_packed[id].indir_desc = NULL; + } else if (ctx) { + *ctx = vq->desc_state_packed[id].indir_desc; + } } static inline bool more_used_packed(const struct vring_virtqueue *vq) { - return false; + u16 last_used, flags; + u8 avail, used; + + last_used = vq->last_used_idx; + flags = virtio16_to_cpu(vq->vq.vdev, + vq->vring_packed.desc[last_used].flags); + avail = !!(flags & VRING_DESC_F_AVAIL(1)); + used = !!(flags & VRING_DESC_F_USED(1)); + + return avail == used && used == vq-&...

...lude <linux/highmem.h> +#include <linux/file.h> +#include <linux/mount.h> +#include <linux/magic.h> +#include <linux/module.h> + +static struct vfsmount *vring_mnt; +static DEFINE_MUTEX(vring_lock); + +struct vring_info +{ + struct vring ring; + u16 mask; + u16 __user *last_used; + u16 last_avail; + + const struct vring_ops *ops; + void *ops_data; + + /* Waitqueue for poll() */ + wait_queue_head_t poll_wait; + + /* The mapped used ring. */ + struct vring_used *used; + struct page *used_page; +}; + +static unsigned int vring_poll(struct file *filp, + struct poll_ta...

...lude <linux/highmem.h> +#include <linux/file.h> +#include <linux/mount.h> +#include <linux/magic.h> +#include <linux/module.h> + +static struct vfsmount *vring_mnt; +static DEFINE_MUTEX(vring_lock); + +struct vring_info +{ + struct vring ring; + u16 mask; + u16 __user *last_used; + u16 last_avail; + + const struct vring_ops *ops; + void *ops_data; + + /* Waitqueue for poll() */ + wait_queue_head_t poll_wait; + + /* The mapped used ring. */ + struct vring_used *used; + struct page *used_page; +}; + +static unsigned int vring_poll(struct file *filp, + struct poll_ta...

...ol weak_barriers; @@ -79,19 +80,45 @@ struct vring_virtqueue { /* Host publishes avail event idx */ bool event; - /* Head of free buffer list. */ - unsigned int free_head; /* Number we've added since last sync. */ unsigned int num_added; /* Last used index we've seen. */ u16 last_used_idx; - /* Last written value to avail->flags */ - u16 avail_flags_shadow; + union { + /* Available for split ring */ + struct { + /* Actual memory layout for this queue. */ + struct vring vring; - /* Last written value to avail->idx in guest byte order */ - u16 avail_idx_shadow; +...

...ol weak_barriers; @@ -79,19 +80,45 @@ struct vring_virtqueue { /* Host publishes avail event idx */ bool event; - /* Head of free buffer list. */ - unsigned int free_head; /* Number we've added since last sync. */ unsigned int num_added; /* Last used index we've seen. */ u16 last_used_idx; - /* Last written value to avail->flags */ - u16 avail_flags_shadow; + union { + /* Available for split ring */ + struct { + /* Actual memory layout for this queue. */ + struct vring vring; - /* Last written value to avail->idx in guest byte order */ - u16 avail_idx_shadow; +...

...(ctx) { > > + *ctx = vq->desc_state[head].indir_desc; > > + } > > + > > +out: > > + return vq->desc_state[head].num; > > +} > > + > > +static inline bool more_used_split(const struct vring_virtqueue *vq) > > { > > return vq->last_used_idx != virtio16_to_cpu(vq->vq.vdev, vq->vring.used->idx); > > } > > +static inline bool more_used_packed(const struct vring_virtqueue *vq) > > +{ > > + u16 last_used, flags; > > + bool avail, used; > > + > > + if (vq->vq.num_free == vq->vri...

...(ctx) { > > + *ctx = vq->desc_state[head].indir_desc; > > + } > > + > > +out: > > + return vq->desc_state[head].num; > > +} > > + > > +static inline bool more_used_split(const struct vring_virtqueue *vq) > > { > > return vq->last_used_idx != virtio16_to_cpu(vq->vq.vdev, vq->vring.used->idx); > > } > > +static inline bool more_used_packed(const struct vring_virtqueue *vq) > > +{ > > + u16 last_used, flags; > > + bool avail, used; > > + > > + if (vq->vq.num_free == vq->vri...

...esc_state[id].indir_desc = NULL; > + } else if (ctx) { > + *ctx = vq->desc_state[id].indir_desc; > + } > + > +out: > + free_id_packed(vq, id); > } > > static inline bool more_used_packed(const struct vring_virtqueue *vq) > { > - return false; > + u16 last_used, flags; > + bool avail, used; > + > + if (vq->vq.num_free == vq->vring_packed.num) > + return false; > + > + last_used = vq->last_used_idx; > + flags = virtio16_to_cpu(vq->vq.vdev, > + vq->vring_packed.desc[last_used].flags); > + avail = flags & VRI...

...esc_state[id].indir_desc = NULL; > + } else if (ctx) { > + *ctx = vq->desc_state[id].indir_desc; > + } > + > +out: > + free_id_packed(vq, id); > } > > static inline bool more_used_packed(const struct vring_virtqueue *vq) > { > - return false; > + u16 last_used, flags; > + bool avail, used; > + > + if (vq->vq.num_free == vq->vring_packed.num) > + return false; > + > + last_used = vq->last_used_idx; > + flags = virtio16_to_cpu(vq->vq.vdev, > + vq->vring_packed.desc[last_used].flags); > + avail = flags & VRI...

...elds have_guids have_save_guids have_only_guid128 Atype key value stream deleted last_change modseq Ctype uid guid hdr_hash modseq pvt_modseq save_timestamp add_flags remove_flags final_flags keywords_reset keyword_changes Rguid uid Mguid uid pop3_uidl pop3_order received_date stream cname decision last_used . VERSION dsync 3 2 Hhostname sync_ns_prefix sync_box sync_box_guid sync_type debug sync_visible_namespaces exclude_mailboxes send_mail_requests backup_send backup_recv lock_timeout no_mail_sync no_backup_overwrite purge_remote Smailbox_guid last_uidvalidity last_common_uid last_common_modseq last_...

...ue { > /* Host publishes avail event idx */ > bool event; > > - /* Head of free buffer list. */ > - unsigned int free_head; > /* Number we've added since last sync. */ > unsigned int num_added; > > /* Last used index we've seen. */ > u16 last_used_idx; > > - /* Last written value to avail->flags */ > - u16 avail_flags_shadow; > + union { > + /* Available for split ring */ > + struct { > + /* Actual memory layout for this queue. */ > + struct vring vring; > > - /* Last written value to avail->id...

...ue { > /* Host publishes avail event idx */ > bool event; > > - /* Head of free buffer list. */ > - unsigned int free_head; > /* Number we've added since last sync. */ > unsigned int num_added; > > /* Last used index we've seen. */ > u16 last_used_idx; > > - /* Last written value to avail->flags */ > - u16 avail_flags_shadow; > + union { > + /* Available for split ring */ > + struct { > + /* Actual memory layout for this queue. */ > + struct vring vring; > > - /* Last written value to avail->id...