search for: l_flag

This email is also sent to cluster-devel at redhat.com. Since this issue is about both dlm and ocfs2, I send the email here to look for help from upstream. This is an already known issue. on ocfs2 with user space cluster stack, run the test script from http://people.redhat.com/~teigland/make_panic on the mounted ocfs2 volume from 2 nodes simultaneously, the access to ocfs2 volume on both nodes

.......... store atomic i32 1, i32* @Flag release, align 4 ``` However when inspecting the generated assembly on x86-64, the following assembly was generated: ``` mov qword [rbp+var_50], rcx mov qword [rbp+var_48], rdx mov rbx, rsi mov r15, rdi mov eax, dword [l_Flag] ; l_Flag cmp eax, 0x1 ``` Which to my best knowledge is not atomic. I'd like to know how do I fix my frontend to make sure the locking mechanism works Zhang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/...

David, So here are the two patches. Remove all patches that you have and apply these. The first one is straight forward. The second one will hopefully fix the livelock issue you have been encountering. People reviewing the patches should note that the second one is slightly different than the one I posted earlier. It removes the BUG_ON in the if condition where we jump to update_holders. The

...int local) 1391 { 1392 int level = ex ? DLM_LOCK_EX : DLM_LOCK_PR; 1393 unsigned long flags; 1394 u32 lkm_flags = local ? DLM_LKF_LOCAL : 0; 1395 1396 spin_lock_irqsave(&lockres->l_lock, flags); 1397 BUG_ON(lockres->l_flags & OCFS2_LOCK_ATTACHED); 1398 lockres_or_flags(lockres, OCFS2_LOCK_LOCAL); 1399 spin_unlock_irqrestore(&lockres->l_lock, flags); 1400 1401 return ocfs2_lock_create(osb, lockres, level, lkm_flags); 1402 } Joel -- "Egotist: a person more interested in hims...

...nline int ocfs2_highest_compat_l static void lockres_set_flags(struct ocfs2_lock_res *lockres, unsigned long newflags) { - struct list_head *pos, *tmp; - struct ocfs2_mask_waiter *mw; + struct ocfs2_mask_waiter *mw, *tmp; assert_spin_locked(&lockres->l_lock); lockres->l_flags = newflags; - list_for_each_safe(pos, tmp, &lockres->l_mask_waiters) { - mw = list_entry(pos, struct ocfs2_mask_waiter, mw_item); + list_for_each_entry_safe(mw, tmp, &lockres->l_mask_waiters, mw_item) { if ((lockres->l_flags & mw->mw_mask) != mw->mw_goal) conti...

Found 15 patches (out of 162) that appeared relevant to ocfs2 1.4. Please review. Sunil

The following series of patches comprises the bulk of our outstanding changes for Ocfs2. Aside from the usual set of cleanups and fixes that were inappropriate for 2.6.25, there are a few highlights: The '/sys/o2cb' directory has been moved to '/sys/fs/o2cb'. The new location meshes better with modern sysfs layout. A symbolic link has been placed in the old location so as to

I'm running a bit late with the e-mail this time around, but I think that's ok since there really isn't any major new features here - the bulk of the Ocfs2 update is bug fixes, or cleanups. The same goes for configfs. The only two things that could be described as features would be: - Sunil has updated Ocfs2 to provide even more live cluster locking information via debugfs. - Joel

Please review the list of patches being applied to the ocfs2 1.4 tree. All patches list the mainline commit hash. Thanks Sunil

Hi, This is the second batch of Ocfs2 patches intended for the merge window. The 1st batch were sent out previously: http://lkml.org/lkml/2008/12/19/280 The bulk of this set is comprised of Jan Kara's patches to add quota support to Ocfs2. Many of the quota patches are to generic code, which I carried to make merging of the Ocfs2 support easier. All of the non-ocfs2 patches should have