search for: l757

...assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed: https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757 > we could do some > additional things: > > * Remove "Summary:" in front of message > * Line break after 72 columns > * Convert summary markdown formatting to plain texts (e.g. remove > backticks; I don't know any git client that renders as markdown) > *...

...g/blob/71928e1dab585f336f6d0fb337969eda00ccd19c/lib/Basic/Targets.cpp#L491 The problem with DarwinX86_64TargetInfo is, that it's hard-coded for Mach-O. It always sets the same data-layout string in the target description: https://github.com/llvm-mirror/clang/blob/master/lib/Basic/Targets/X86.h#L757 *** This causes the above error. Can anyone explain this behavior? Is there anyone possibly relying on it? *** My impression is that one of these points should be changed. Either the branch to DarwinX86_64TargetInfo from: Triple.isOSDarwin() || Triple.isOSBinFormatMachO() to:   Triple.isOSDarwin(...

Can we fix this in reviews.llvm.org's fork of phab? https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT. Jon On Fri, Dec 27, 2019 at 11:30 PM Mehdi AMINI via llvm-dev