search for: l591

...&& > > + pread dev 4 0x01b8 = diskid > > + with Unix.Unix_error (Unix.EINVAL, _, _) -> false > > The old C inspection code did not check for the partition type: > https://github.com/libguestfs/libguestfs/blob/stable-1.36/lib/inspect-fs-windows.c#L591 > The partition type check was added recently: > https://github.com/libguestfs/libguestfs/commit/7b4d13626ff878b124d01ec452a4fd0052934133 > > TBH I'd rather prefer that we check for the situation explicitly > before, rather than catching a generic EINVAL error. Or, even better, &...

By creating an empty disk and using it as the first disk of the vm (i.e. /dev/sda, /dev/sdb{1,2} contains the windows fses) we change the iteration order of the disks. This causes inspect_os() to fail since Parted returns a Unix_error if the device does not contain any partitions - fix this by handling this Unix_error. Signed-off-by: Sam Eiderman <sameid@google.com> ---

...dev = "msdos" && > + pread dev 4 0x01b8 = diskid > + with Unix.Unix_error (Unix.EINVAL, _, _) -> false The old C inspection code did not check for the partition type: https://github.com/libguestfs/libguestfs/blob/stable-1.36/lib/inspect-fs-windows.c#L591 The partition type check was added recently: https://github.com/libguestfs/libguestfs/commit/7b4d13626ff878b124d01ec452a4fd0052934133 TBH I'd rather prefer that we check for the situation explicitly before, rather than catching a generic EINVAL error. Or, even better, try to avoid altogether t...

We're putting together a Linux-cups-samba print server for Windows clients. A dozen print drivers have been loaded and used successfully on the Windows clients from the samba server. But, one particular printer is causing trouble: a Xerox DC 2240. When a windows client tries to open the printer preferences, after connecting to the printer on the samba print server, a popup says