Displaying 2 results from an estimated 2 matches for "l525".
Did you mean:
525
2023 Mar 24
1
[PATCH 1/1] nbd/server: push pending frames after sending reply
...the
use of a flag can be more efficient than separate passes through
cork/uncork calls. But even your initial work at properly corking is
a good step in the right direction.
And surprisingly, qemu IS using corking on the client side:
https://gitlab.com/qemu-project/qemu/-/blob/master/block/nbd.c#L525
just not on the server side, before your patch.
>
> Signed-off-by: Florian Westphal <fw at strlen.de>
> ---
> nbd/server.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/nbd/server.c b/nbd/server.c
> index a4750e41880a..848836d41405 100644
> --- a/n...
2023 Mar 24
1
[PATCH 1/1] nbd/server: push pending frames after sending reply
...ian Westphal wrote:
> > qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
Replying to myself, WHY aren't we setting TCP_NODELAY on the socket?
>
> And surprisingly, qemu IS using corking on the client side:
> https://gitlab.com/qemu-project/qemu/-/blob/master/block/nbd.c#L525
> just not on the server side, before your patch.
Corking matters more when TCP_NODELAY is enabled. The entire reason
Nagle's algorithm exists (and is default on unless you enable
TCP_NODELAY) is that the benefits of merging smaller piecemeal packets
into larger traffic is a lot easier to...