search for: l503

...e doesn't really need or want it. It's also not great from a build hygiene perspective, as LLVM globally sets some flags and subprojects pick them up, when they don't really mean to. For example, see this workaround: https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L503-L507 <https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L503-L507>, where we need to account for some flags that might have been set globally by LLVM. I'm not sure about other projects, however this is quite problematic for projects part of the C++ runtime (libc++/li...

On Thu, Jul 12, 2018 at 2:21 PM Duncan Murdoch <murdoch.duncan at gmail.com> wrote: > I think I found the bug. The tools::checkRd function only processes > \Sexpr's with "stage=render". I think the author (who might have been > me, I forget) assumed that would imply all the earlier stages as well, > but apparently it doesn't. > > So you could use that as

...like there is no clean workaround here. >> >> Thanks again, >> G. > > Btw. would it make sense to just allow \Sexpr as a top level section? > Maybe here: > https://github.com/wch/r-source/blob/98e9999eb0e8616550632a1675e4d2dbe630d5e4/src/library/tools/R/RdConv2.R#L500-L503 > > At least if stage=render, there is no way to check if the returned > value is always a valid top level section, anyway. > If it is not a valid section (or \Sexpr returns some bad markup in > general), then the user gets a render-time error, > but with stage=render I guess one...

...e doesn't really need or want it. It's also not great from a build hygiene perspective, as LLVM globally sets some flags and subprojects pick them up, when they don't really mean to. For example, see this workaround: https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L503-L507, where we need to account for some flags that might have been set globally by LLVM. >> >> I'm not sure about other projects, however this is quite problematic for projects part of the C++ runtime (libc++/libc++abi/libunwind). Indeed, we often try to build those projects targett...

...ion is dropped. > > Seems like there is no clean workaround here. > > Thanks again, > G. Btw. would it make sense to just allow \Sexpr as a top level section? Maybe here: https://github.com/wch/r-source/blob/98e9999eb0e8616550632a1675e4d2dbe630d5e4/src/library/tools/R/RdConv2.R#L500-L503 At least if stage=render, there is no way to check if the returned value is always a valid top level section, anyway. If it is not a valid section (or \Sexpr returns some bad markup in general), then the user gets a render-time error, but with stage=render I guess one cannot do better. G.