Displaying 4 results from an estimated 4 matches for "l1846".
Did you mean:
1846
2019 Nov 22
2
Re: [PATCH nbdkit v2 02/10] python: Add various constants to the API.
...rd library have
this issue.
In sanlock we do:
if (PyModule_AddIntConstant(m, "LSFLAG_ADD", SANLK_LSF_ADD))
return -1;
And the caller decref the module object and return NULL.
See
https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1846
https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1763
> + PyModule_AddIntConstant (m, "THREAD_MODEL_SERIALIZE_ALL_REQUESTS",
> + NBDKIT_THREAD_MODEL_SERIALIZE_ALL_REQUESTS);
> + PyModule_AddIntConstant (m...
2019 Nov 22
1
Re: [PATCH nbdkit v2 02/10] python: Add various constants to the API.
...Module_AddIntConstant(m, "LSFLAG_ADD", SANLK_LSF_ADD))
> > return -1;
> >
> > And the caller decref the module object and return NULL.
> >
> > See
> > https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1846
> > https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1763
>
> Yes I can make this change. It's worth it in case there is some
> subtle Python API change in future that we need to be aware of.
>
> We can in fact exit if load()...
2019 Nov 22
0
Re: [PATCH nbdkit v2 02/10] python: Add various constants to the API.
...we do:
>
> if (PyModule_AddIntConstant(m, "LSFLAG_ADD", SANLK_LSF_ADD))
> return -1;
>
> And the caller decref the module object and return NULL.
>
> See
> https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1846
> https://github.com/nirs/sanlock/blob/53f7f0284c084ac2e4542fd1f71d0406075adb5d/python/sanlock.c#L1763
Yes I can make this change. It's worth it in case there is some
subtle Python API change in future that we need to be aware of.
We can in fact exit if load() fails so I guess we don'...
2019 Nov 22
18
[PATCH nbdkit v2 00/10] Implement nbdkit API v2 for Python plugins.
v1:
https://www.redhat.com/archives/libguestfs/2019-November/msg00153.html
v2:
- Fix implementation of can_cache.
- Add implementation of can_fua.
- Add a very thorough test suite which tests every command + flag
combination.