Displaying 2 results from an estimated 2 matches for "l1296".
Did you mean:
1296
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
...3. It doesn't create an identical level of intendation
> 4. It wastes huge amount of space and does not solve the problem of
> long names, but might even make it worse:
> https://elixir.bootlin.com/linux/v6.13-
> rc3/source/drivers/gpu/drm/scheduler/sched_main.c#L1296
It's mostly a matter of keeping things consistent in a code base. I
don't really have strong opinions when it comes to coding style, but I
always try to follow the rules in place in the file/subsystem/project
I'm contributing to, and clearly the pattern in this file is to align
the ext...
2025 Jan 23
0
[PATCH] drm/sched: Use struct for drm_sched_init() params
...sistent in regards to
> this.
That's not really a good argument to make it more inconsistent, is it?
>
> Anyways, what is your proposed solution to ridiculous nonsense like
> this?
>
> https://elixir.bootlin.com/linux/v6.13-rc3/source/drivers/gpu/drm/scheduler/sched_main.c#L1296
I don't think this one needs a solution.
The kernel picked a convention long ago, which also has downsides. If it gets
too bad, we can deviate from conventions at any point of time; for the thing
that otherwise would be bad, but we shouldn't do it in general.