search for: kzalloc_node

An embedded and charset-unspecified text was scrubbed... Name: cpumask:update-irq_desc-to-use-cpumask_var_t.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090107/8ebe5843/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: cpumask:update-irq_desc-to-use-cpumask_var_t.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090107/8ebe5843/attachment.txt

An embedded and charset-unspecified text was scrubbed... Name: cpumask:update-irq_desc-to-use-cpumask_var_t.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090107/8ebe5843/attachment.txt

...r_do_req() is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() is only called by > virtio_crypto_ablkcipher_crypt_req(), which is only called by > virtcrypto_find_vqs() that is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() calls kzalloc_node() with GFP_ATOMIC, > which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > I also manually check the kernel code before reporting it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990 at...

...+ src_nents = sg_nents_for_len(req->src, req->nbytes); + dst_nents = sg_nents(req->dst); + + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, dst_nents: %d)\n", + src_nents, dst_nents); + + /* Why 3? outhdr + iv + inhdr */ + sg_total = src_nents + dst_nents + 3; + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!sgs) + return -ENOMEM; + + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!req_data) { + kfree(sgs); + return -ENOMEM; + } + + vc_req->...

...+ src_nents = sg_nents_for_len(req->src, req->nbytes); + dst_nents = sg_nents(req->dst); + + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, dst_nents: %d)\n", + src_nents, dst_nents); + + /* Why 3? outhdr + iv + inhdr */ + sg_total = src_nents + dst_nents + 3; + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!sgs) + return -ENOMEM; + + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!req_data) { + kfree(sgs); + return -ENOMEM; + } + + vc_req->...

...+ src_nents = sg_nents_for_len(req->src, req->nbytes); + dst_nents = sg_nents(req->dst); + + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, dst_nents: %d)\n", + src_nents, dst_nents); + + /* Why 3? outhdr + iv + inhdr */ + sg_total = src_nents + dst_nents + 3; + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!sgs) + return -ENOMEM; + + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!req_data) { + kfree(sgs); + return -ENOMEM; + } + + vc_req->...

...+ src_nents = sg_nents_for_len(req->src, req->nbytes); + dst_nents = sg_nents(req->dst); + + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, dst_nents: %d)\n", + src_nents, dst_nents); + + /* Why 3? outhdr + iv + inhdr */ + sg_total = src_nents + dst_nents + 3; + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!sgs) + return -ENOMEM; + + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, + dev_to_node(&vcrypto->vdev->dev)); + if (!req_data) { + kfree(sgs); + return -ENOMEM; + } + + vc_req->...

v6: - add patch 1/2 to make sparc architecture happy. [Sam] - close created sessions previousely when rekeying. - convert the priority of virtio crypto algs from 4001 to 501 which is enough. v5: - add comments for algs_lock and table_lock. [Stefan] - use kzfree instead of kfree for key material security. [Stefan] - drop unnecessary spin_lock for struct virtio_crypto_ablkcipher_ctx. -

v6: - add patch 1/2 to make sparc architecture happy. [Sam] - close created sessions previousely when rekeying. - convert the priority of virtio crypto algs from 4001 to 501 which is enough. v5: - add comments for algs_lock and table_lock. [Stefan] - use kzfree instead of kfree for key material security. [Stefan] - drop unnecessary spin_lock for struct virtio_crypto_ablkcipher_ctx. -

...req->nbytes); > + dst_nents = sg_nents(req->dst); > + > + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, > dst_nents: %d)\n", > + src_nents, dst_nents); > + > + /* Why 3? outhdr + iv + inhdr */ > + sg_total = src_nents + dst_nents + 3; > + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!sgs) > + return -ENOMEM; > + > + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!req_data) { > + kfree(sgs)...

...req->nbytes); > + dst_nents = sg_nents(req->dst); > + > + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, > dst_nents: %d)\n", > + src_nents, dst_nents); > + > + /* Why 3? outhdr + iv + inhdr */ > + sg_total = src_nents + dst_nents + 3; > + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!sgs) > + return -ENOMEM; > + > + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!req_data) { > + kfree(sgs)...

v5: - add comments for algs_lock and table_lock. [Stefan] - use kzfree instead of kfree for key material security. [Stefan] - drop unnecessary spin_lock for struct virtio_crypto_ablkcipher_ctx. - dynamically allocated memory for iv in order to avoid to do DMA from the stack memory in __virtio_crypto_ablkcipher_do_req(). - add logs for error path in virtio_crypto_alg_validate_key(). - add

v5: - add comments for algs_lock and table_lock. [Stefan] - use kzfree instead of kfree for key material security. [Stefan] - drop unnecessary spin_lock for struct virtio_crypto_ablkcipher_ctx. - dynamically allocated memory for iv in order to avoid to do DMA from the stack memory in __virtio_crypto_ablkcipher_do_req(). - add logs for error path in virtio_crypto_alg_validate_key(). - add

...req->nbytes); > + dst_nents = sg_nents(req->dst); > + > + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, > dst_nents: %d)\n", > + src_nents, dst_nents); > + > + /* Why 3? outhdr + iv + inhdr */ > + sg_total = src_nents + dst_nents + 3; > + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!sgs) > + return -ENOMEM; > + > + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!req_data) { > + kfree(sgs)...

...req->nbytes); > + dst_nents = sg_nents(req->dst); > + > + pr_debug("virtio_crypto: Number of sgs (src_nents: %d, > dst_nents: %d)\n", > + src_nents, dst_nents); > + > + /* Why 3? outhdr + iv + inhdr */ > + sg_total = src_nents + dst_nents + 3; > + sgs = kzalloc_node(sg_total * sizeof(*sgs), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!sgs) > + return -ENOMEM; > + > + req_data = kzalloc_node(sizeof(*req_data), GFP_ATOMIC, > + dev_to_node(&vcrypto->vdev->dev)); > + if (!req_data) { > + kfree(sgs)...

v8: - use per virtqueue lock instead of a whole device lock for data virtuqueue. [Halil & Xin] v7: - fix "BUG: smp_processor_id() in preemptible [00000000] code" reported by Halil, using get_cpu/put_cpu instead of calling smp_processor_id() directly. - fix a possible spinlock recursion in virtcrypto_dataq_callback(), we should release the spinlock before invoking the

v8: - use per virtqueue lock instead of a whole device lock for data virtuqueue. [Halil & Xin] v7: - fix "BUG: smp_processor_id() in preemptible [00000000] code" reported by Halil, using get_cpu/put_cpu instead of calling smp_processor_id() directly. - fix a possible spinlock recursion in virtcrypto_dataq_callback(), we should release the spinlock before invoking the

v7: - fix "BUG: smp_processor_id() in preemptible [00000000] code" reported by Halil, using get_cpu/put_cpu instead of calling smp_processor_id() directly. - fix a possible spinlock recursion in virtcrypto_dataq_callback(), we should release the spinlock before invoking the callback. - rebase on the latest kernel master tree. v6: - add patch 1/2 to make sparc architecture

v7: - fix "BUG: smp_processor_id() in preemptible [00000000] code" reported by Halil, using get_cpu/put_cpu instead of calling smp_processor_id() directly. - fix a possible spinlock recursion in virtcrypto_dataq_callback(), we should release the spinlock before invoking the callback. - rebase on the latest kernel master tree. v6: - add patch 1/2 to make sparc architecture