search for: kvm_arch

Hi Xiantao, Some more nit-picking, though some of this is a bit more important to fixup. Cheers, Jes > +typedef struct thash_data { Urgh! argh! Please avoid typedefs unless you really need them, see Chapter 5 of Documentation/CodingStyle for details. > diff --git a/include/asm-ia64/kvm_host.h b/include/asm-ia64/kvm_host.h > new file mode 100644 > index 0000000..522bde0 > ---

Hi Xiantao, Some more nit-picking, though some of this is a bit more important to fixup. Cheers, Jes > +typedef struct thash_data { Urgh! argh! Please avoid typedefs unless you really need them, see Chapter 5 of Documentation/CodingStyle for details. > diff --git a/include/asm-ia64/kvm_host.h b/include/asm-ia64/kvm_host.h > new file mode 100644 > index 0000000..522bde0 > ---

...er *kian); void kvm_timer_intr_post(struct kvm_vcpu *vcpu, int vec); void kvm_inject_pending_timer_irqs(struct kvm_vcpu *vcpu); diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index c7bad53..a016900 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3948,6 +3948,7 @@ struct kvm *kvm_arch_create_vm(void) return ERR_PTR(-ENOMEM); INIT_LIST_HEAD(&kvm->arch.active_mmu_pages); + INIT_HLIST_HEAD(&kvm->arch.irq_ack_notifier_list); return kvm; } diff --git a/include/asm-x86/kvm_host.h b/include/asm-x86/kvm_host.h index b893a85..73756e5 100644 --- a/include/asm-x86...

Although SPAPR_TCE_IOMMU itself can be compile tested on certain PowerPC configurations, its presence makes arch/powerpc/kvm/Makefile to select modules which do not build in such configuration. The arch/powerpc/kvm/ modules use kvm_arch.spapr_tce_tables which exists only with CONFIG_PPC_BOOK3S_64. However these modules are selected when COMPILE_TEST and SPAPR_TCE_IOMMU are chosen leading to build failures: In file included from arch/powerpc/include/asm/book3s/64/mmu-hash.h:20:0, from arch/powerpc/kvm/boo...

Although SPAPR_TCE_IOMMU itself can be compile tested on certain PowerPC configurations, its presence makes arch/powerpc/kvm/Makefile to select modules which do not build in such configuration. The arch/powerpc/kvm/ modules use kvm_arch.spapr_tce_tables which exists only with CONFIG_PPC_BOOK3S_64. However these modules are selected when COMPILE_TEST and SPAPR_TCE_IOMMU are chosen leading to build failures: In file included from arch/powerpc/include/asm/book3s/64/mmu-hash.h:20:0, from arch/powerpc/kvm/boo...

...Main changes to current source: > 1. Add subdirectories, such as x86 and ia64 to hold arch-specific code. > 2. Split kvm_main.c to two parts. One is still called kvm_main.c, just > contains KVM common interfaces with user space, and basic KVM > infrastructure. The other one is named as kvm_arch.c under sub-directory > (eg. X86, ia64 etc), which includes arch-specific code to supplement the > functionality of kvm_main.c > 3. Add an "include" directory in drivers/kvm. Due to possibly complex > code logic in KVM source, maybe many header files need to maintain for >...

...Main changes to current source: > 1. Add subdirectories, such as x86 and ia64 to hold arch-specific code. > 2. Split kvm_main.c to two parts. One is still called kvm_main.c, just > contains KVM common interfaces with user space, and basic KVM > infrastructure. The other one is named as kvm_arch.c under sub-directory > (eg. X86, ia64 etc), which includes arch-specific code to supplement the > functionality of kvm_main.c > 3. Add an "include" directory in drivers/kvm. Due to possibly complex > code logic in KVM source, maybe many header files need to maintain for >...

...@@ let convert (g : G.guestfs) inspect source output rcaps = gcaps_virtio_rng = kernel.ki_supports_virtio_rng; gcaps_virtio_balloon = kernel.ki_supports_virtio_balloon; gcaps_isa_pvpanic = kernel.ki_supports_isa_pvpanic; + gcaps_machine = machine; gcaps_arch = Utils.kvm_arch inspect.i_arch; gcaps_acpi = acpi; } in diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml index 163319545..97882c377 100644 --- a/v2v/convert_windows.ml +++ b/v2v/convert_windows.ml @@ -212,6 +212,15 @@ let convert (g : G.guestfs) inspect source output rcaps = warnin...

...@@ let convert (g : G.guestfs) inspect source output rcaps = gcaps_virtio_rng = kernel.ki_supports_virtio_rng; gcaps_virtio_balloon = kernel.ki_supports_virtio_balloon; gcaps_isa_pvpanic = kernel.ki_supports_isa_pvpanic; + gcaps_machine = machine; gcaps_arch = Utils.kvm_arch inspect.i_arch; gcaps_acpi = acpi; } in diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml index 163319545..1e058136e 100644 --- a/v2v/convert_windows.ml +++ b/v2v/convert_windows.ml @@ -212,6 +212,12 @@ let convert (g : G.guestfs) inspect source output rcaps = warnin...

...stfs) inspect source output rcaps = > gcaps_virtio_rng = kernel.ki_supports_virtio_rng; > gcaps_virtio_balloon = kernel.ki_supports_virtio_balloon; > gcaps_isa_pvpanic = kernel.ki_supports_isa_pvpanic; > + gcaps_machine = machine; > gcaps_arch = Utils.kvm_arch inspect.i_arch; > gcaps_acpi = acpi; > } in > diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml > index 163319545..97882c377 100644 > --- a/v2v/convert_windows.ml > +++ b/v2v/convert_windows.ml > @@ -212,6 +212,15 @@ let convert (g : G.guestfs) inspect so...

Version 1 was here: https://listman.redhat.com/archives/libguestfs/2023-February/thread.html#30694 I made a few changes in v2 but overall decided to keep the now unused gcaps_arch_min_version capability. This doesn't preclude removing it in future if we think it's never going to be useful. I changed patch 1 so that to remove the long comment about how the field is used, anticipating the

.../14/2020 02:26 PM, Krzysztof Kozlowski wrote: > Although SPAPR_TCE_IOMMU itself can be compile tested on certain PowerPC > configurations, its presence makes arch/powerpc/kvm/Makefile to select > modules which do not build in such configuration. > > The arch/powerpc/kvm/ modules use kvm_arch.spapr_tce_tables which exists > only with CONFIG_PPC_BOOK3S_64. However these modules are selected when > COMPILE_TEST and SPAPR_TCE_IOMMU are chosen leading to build failures: > > In file included from arch/powerpc/include/asm/book3s/64/mmu-hash.h:20:0, >...

...uma after a while (could take seconds but it will happen) the > > memory will migrate. > > > > Yes. As you mentioned during the discuss, I wonder we could do it similarly > through mmu notifier like APIC access page in commit c24ae0dcd3e ("kvm: x86: > Unpin and remove kvm_arch->apic_access_page") That would be a possible approach. > > > > > > > > > > > > > > > > > > > > > > > > This is the price of all GUP users not only vhost itself. > > > > > > Yes. GUP is just not...

...uma after a while (could take seconds but it will happen) the > > memory will migrate. > > > > Yes. As you mentioned during the discuss, I wonder we could do it similarly > through mmu notifier like APIC access page in commit c24ae0dcd3e ("kvm: x86: > Unpin and remove kvm_arch->apic_access_page") That would be a possible approach. > > > > > > > > > > > > > > > > > > > > > > > > This is the price of all GUP users not only vhost itself. > > > > > > Yes. GUP is just not...

...will happen) the > > > > memory will migrate. > > > > > > > Yes. As you mentioned during the discuss, I wonder we could do it similarly > > > through mmu notifier like APIC access page in commit c24ae0dcd3e ("kvm: x86: > > > Unpin and remove kvm_arch->apic_access_page") > > That would be a possible approach. > > > Yes, this looks possible, and the conversion seems not hard. Let me have a > try with this. > > > [...] > > > > > > > > > > I don't see how a kthread makes any...

> On Oct 4, 2018, at 12:31 PM, Peter Zijlstra <peterz at infradead.org> wrote: > > On Thu, Oct 04, 2018 at 07:00:45AM -0700, Andy Lutomirski wrote: >>> On Oct 4, 2018, at 1:11 AM, Peter Zijlstra <peterz at infradead.org> wrote: >>> >>>> On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote: >>>> I was hoping to hear this

> On Oct 4, 2018, at 12:31 PM, Peter Zijlstra <peterz at infradead.org> wrote: > > On Thu, Oct 04, 2018 at 07:00:45AM -0700, Andy Lutomirski wrote: >>> On Oct 4, 2018, at 1:11 AM, Peter Zijlstra <peterz at infradead.org> wrote: >>> >>>> On Thu, Oct 04, 2018 at 09:54:45AM +0200, Vitaly Kuznetsov wrote: >>>> I was hoping to hear this

...6 +29,9 @@ val shell_unquote : string -> string (like ones under /etc/sysconfig), and it doesn't deal with some situations such as $variable interpolation. *) +val uri_quote : string -> string +(** Take a string and perform %xx escaping as used in some parts of URLs. *) + val kvm_arch : string -> string (** Map guest architecture found by inspection to the architecture that KVM must emulate. Note for x86 we assume a 64 bit hypervisor. *) diff --git a/v2v/vCenter.ml b/v2v/vCenter.ml index 468261d3d..f21324611 100644 --- a/v2v/vCenter.ml +++ b/v2v/vCenter.ml @@ -22,21 +2...

...h/pte-book3e.h: error: redefinition of 'pte_mkprivileged': => 108:26 > >> + /kisskb/src/arch/powerpc/include/asm/nohash/pte-book3e.h: error: redefinition of 'pte_mkuser': => 115:20 > >> + /kisskb/src/arch/powerpc/kvm/book3s_64_vio_hv.c: error: 'struct kvm_arch' has no member named 'spapr_tce_tables': => 68:46, 68:2 > > > > ppc64_book3e_allmodconfig > > Caused by: > > e93a1695d7fb ("iommu: Enable compile testing for some of drivers") > > Which did: > > config SPAPR_TCE_IOMMU > bool &q...

Yaniv pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1438794 that virt-v2v both doesn't install the virtio-rng driver for Windows, and doesn't give the guest a virtio-rng PCI device either. There are two problems here: Firstly the Windows virtio-rng driver isn't included in the exploded tree (/usr/share/virtio-win) so it doesn't get copied into the guest. The solution