Displaying 4 results from an estimated 4 matches for "koschel".
Did you mean:
koschei
2023 Mar 01
5
[PATCH 0/2] drm/nouveau: avoid usage of list iterator after loop
...that otherwise
would be completely undetectable.
It also helps the greater mission to hopefully move the list iterator
variable into the iterating macro directly [1].
Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w at mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <jkl820.git at gmail.com>
---
Jakob Koschel (2):
drm/nouveau/device: avoid usage of list iterator after loop
drm/nouveau/clk: avoid usage of list iterator after loop
drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c | 9 ++++++---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c...
2023 Mar 07
1
[PATCH 0/2] drm/nouveau: avoid usage of list iterator after loop
Reviewed-by: Lyude Paul <lyude at redhat.com>
Will push upstream in just a moment
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> This patch set includes two instances where the list iterator variable
> 'pstate' is implicitly assumed to be valid after the iterator loop.
> While in pratice that is most likely the case (if
> 'pstatei'/'args->v0.state' is <= the elements in clk-...
2023 Mar 07
0
[PATCH 1/2] drm/nouveau/device: avoid usage of list iterator after loop
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> If potentially no valid element is found, 'pstate' would contain an
> invalid pointer past the iterator loop. To ensure 'pstate' is always
> valid, we only set it if the correct element was found. That allows
> adding a BUG_ON in case the code works incorrectly,...
2023 Mar 07
0
[PATCH 2/2] drm/nouveau/clk: avoid usage of list iterator after loop
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> + }
> ? }
> ?
> + BUG_ON(!pstate);
> ? nvkm_debug(subdev, "setting performance state %d\n", pstatei);
> ? clk->pstate = pstatei;
We should probably also replace this with
if (WARN_ON(!pstate)
return -EINVAL;
--
Cheers,
Lyude Paul (she/her)
Software...