search for: konovalov

On Thu, Oct 17, 2019 at 09:00:18PM +0200, Andrey Konovalov wrote: > On Thu, Oct 17, 2019 at 8:18 PM Greg Kroah-Hartman > <gregkh at linuxfoundation.org> wrote: > > > > On Thu, Oct 17, 2019 at 07:44:15PM +0200, Andrey Konovalov wrote: > > > This patch adds kcov_remote_start/kcov_remote_stop annotations to the > > >...

On Wed, Oct 23, 2019 at 3:35 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > On Wed, Oct 23, 2019 at 10:36 AM Dmitry Vyukov <dvyukov at google.com> wrote: > > > > On Tue, Oct 22, 2019 at 6:46 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > > > > > This patch adds kcov_remot...

On Thu, Oct 17, 2019 at 09:06:56PM +0200, Andrey Konovalov wrote: > On Thu, Oct 17, 2019 at 8:19 PM Greg Kroah-Hartman > <gregkh at linuxfoundation.org> wrote: > > > > On Thu, Oct 17, 2019 at 07:44:14PM +0200, Andrey Konovalov wrote: > > > This patch adds kcov_remote_start/kcov_remote_stop annotations to the > > >...

On Thu, Oct 17, 2019 at 07:44:15PM +0200, Andrey Konovalov wrote: > This patch adds kcov_remote_start/kcov_remote_stop annotations to the > vhost_worker function, which is responsible for processing vhost works. > Since vhost_worker is spawned when a vhost device instance is created, > the common kcov handle is used for kcov_remote_start/stop a...

On Thu, Oct 17, 2019 at 07:44:14PM +0200, Andrey Konovalov wrote: > This patch adds kcov_remote_start/kcov_remote_stop annotations to the > hub_event function, which is responsible for processing events on USB > buses, in particular events that happen during USB device enumeration. > Each USB bus gets a unique id, which can be used to attach a...

On Tue, Oct 22, 2019 at 6:46 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > This patch adds kcov_remote_start()/kcov_remote_stop() annotations to the > vhost_worker() function, which is responsible for processing vhost works. > Since vhost_worker() threads are spawned per vhost device instance > the common kcov han...

On Tue, Oct 22, 2019 at 6:46 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > This patchset extends kcov to allow collecting coverage from the USB > subsystem and vhost workers. See the first patch description for details > about the kcov extension. The other two patches apply this kcov extension > to USB and vhost....

On Tue, Oct 29, 2019 at 05:32:28PM +0100, Andrey Konovalov wrote: > This patch adds kcov_remote_start()/kcov_remote_stop() annotations to the > hub_event() function, which is responsible for processing events on USB > buses, in particular events that happen during USB device enumeration. > Since hub_event() is run in a global background kernel...

...your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191023-185245 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw...

...your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191023-185245 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githu...

On Wed, 23 Oct 2019 17:24:28 +0200 Andrey Konovalov <andreyknvl at google.com> wrote: > This patchset extends kcov to allow collecting coverage from the USB > subsystem and vhost workers. See the first patch description for details > about the kcov extension. The other two patches apply this kcov extension > to USB and vhost. >...

On Wed, Oct 23, 2019 at 5:24 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > This patch adds background thread coverage collection ability to kcov. ... > +static struct kcov_remote *kcov_remote_add(struct kcov *kcov, u64 handle) > +{ > + struct kcov_remote *remote; > + > + if (kcov_remote_find(hand...

On Thu, 24 Oct 2019 14:47:31 +0200 Andrey Konovalov <andreyknvl at google.com> wrote: > > is it expected that the new kcov feature will be used elsewhere in the > > kernel? > > > > If the latter, which are the expected subsystems? > > Currently we encountered two cases where this is useful: USB and vhost > wo...

...your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191025-145734 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 39a38bcba4ab6e5285b07675b0e42c96eec35e67 config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githu...

...{ + status--; warn("mount"); + } else if (verbose) printf("%s: mounted on %s\n", dev, oarg); } } /* done: */ fflush(stdout); - return(rv < 0); + return(status < 0); } #define EOL(c) ((c) == '\0' || (c) == '\n') %%% -- Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org

mb() typically uses mfence on modern x86, but a micro-benchmark shows that it's 2 to 3 times slower than lock; addl that we use on older CPUs. So we really should use the locked variant everywhere, except that intel manual says that clflush is only ordered by mfence, so we can't. Note: some callers of clflush seems to assume sfence will order it, so there could be existing bugs around

mb() typically uses mfence on modern x86, but a micro-benchmark shows that it's 2 to 3 times slower than lock; addl that we use on older CPUs. So we really should use the locked variant everywhere, except that intel manual says that clflush is only ordered by mfence, so we can't. Note: some callers of clflush seems to assume sfence will order it, so there could be existing bugs around

On Wed, 23 Oct 2019 17:24:29 +0200 Andrey Konovalov <andreyknvl at google.com> wrote: > This patch adds background thread coverage collection ability to kcov. > > With KCOV_ENABLE coverage is collected only for syscalls that are issued > from the current process. With KCOV_REMOTE_ENABLE it's possible to collect > coverage...

On Thu, Oct 17, 2019 at 7:44 PM Andrey Konovalov <andreyknvl at google.com> wrote: > > Currently kcov can only collect coverage for syscalls that are issued > from the current process. This patch adds support for KCOV_REMOTE_ENABLE, > that makes it possible to collect coverage for arbitrary parts of the > kernel code, provide...

I've got a fix for the panic from the cd(4)/da(4) drivers when INVARIANTS is turned on in -stable. The fix is to create a task queue that runs in a thread context and use that to create the sysctl variables needed by cd(4) and da(4). The eventual fix will be to move the CAM transport layer probe code into a kernel thread. Anyway, these patches work for me, but if I could get some feedback