Displaying 20 results from an estimated 24 matches for "koncevi".
2023 Apr 30
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
>>>>> Karolis Koncevi?ius writes:
> But this might require a more detailed investigation. For example I
> just noticed that even with the patch `@` is still not listed in
> .S3_methods_table().
Afaict base does not register any methods for @ or @<- ?
-k
> KK.
>> On Apr 29, 2023, at 4:44 PM, Kar...
2023 Apr 30
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
But this might require a more detailed investigation. For example I just noticed that even with the patch `@` is still not listed in .S3_methods_table().
KK.
> On Apr 29, 2023, at 4:44 PM, Karolis Koncevi?ius <karolis.koncevicius at gmail.com> wrote:
>
> Hello Kurt,
>
> With r84341 it now works on my side.
>
> Warm regards,
> Karolis K.
>
>> On Apr 29, 2023, at 1:24 PM, Kurt Hornik <Kurt.Hornik at wu.ac.at> wrote:
>>
>>>>>>> K...
2023 Apr 29
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
Hello Kurt,
With r84341 it now works on my side.
Warm regards,
Karolis K.
> On Apr 29, 2023, at 1:24 PM, Kurt Hornik <Kurt.Hornik at wu.ac.at> wrote:
>
>>>>>> Karolis Koncevi?ius writes:
>
> Can you pls try again with r84341 or later?
>
> Best
> -k
>
>> A more concrete example in order to correct my vague messages below.
>> Writing an R package that uses `@` and `@<-` as S3 generics. Line from manual pages in .Rd files:
>
>>...
2023 Apr 29
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
>>>>> Karolis Koncevi?ius writes:
Can you pls try again with r84341 or later?
Best
-k
> A more concrete example in order to correct my vague messages below.
> Writing an R package that uses `@` and `@<-` as S3 generics. Line from manual pages in .Rd files:
> \method{@}{newclass}(object, name) <- v...
2023 Apr 28
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
...ls:::.S3_method_markup_regexp and not finding `@` as a valid for S3.
This error is gone if we adjust tools:::.S3_method_markup_regexp to pass for ?@? by adding ?\\@? to regexp.
Please note that this now is not dependant on using or not using roxygen2
KK.
> On Apr 29, 2023, at 12:53 AM, Karolis Koncevi?ius <karolis.koncevicius at gmail.com> wrote:
>
> Thank you for such a quick reply, Gabriel,
>
> I am not too familiar with the package tools, so cannot speak too confidently, but below is how I see the issue currently.
>
> The issue is not for external packages to rely o...
2019 Dec 12
2
Inconsistencies in wilcox.test
>>>>> Karolis Koncevi?ius
>>>>> on Mon, 9 Dec 2019 23:43:36 +0200 writes:
> So I tried adding Infinity support for all cases.
> And it is (as could be expected) more complicated than I thought.
"Of course !" Thank you, Karolis, in any case!
> It is easy to add Inf...
2019 Dec 07
2
Inconsistencies in wilcox.test
...issues 2:4 are all
related to machine precision, which is not the case - only 2nd issue is.
Just wanted to draw this to your attention, in case you might have some
feedback and guidelines about issues 3 and 4 as well.
On 2019-12-07 21:59, Martin Maechler wrote:
>>>>>> Karolis Koncevi?ius
>>>>>> on Sat, 7 Dec 2019 20:55:36 +0200 writes:
>
> > Hello,
> > Writing to share some things I've found about wilcox.test() that seem a
> > a bit inconsistent.
>
> > 1. Inf values are not removed if paired=TRUE
>
> &...
2019 Dec 07
5
Inconsistencies in wilcox.test
...LSE, correct=FALSE)
wilcox.test(rnorm(10), exact=TRUE, correct=FALSE)
From all of these I am pretty sure the 1st one is likely unintended,
so attaching a small patch to adjust it. Can also try patching others if
consensus is reached that the behavioiur has to be modified.
Kind regards,
Karolis Koncevi?ius.
---
Index: wilcox.test.R
===================================================================
--- wilcox.test.R (revision 77540)
+++ wilcox.test.R (working copy)
@@ -42,7 +42,7 @@
if(paired) {
if(length(x) != length(y))
stop("'x' and ...
2023 Apr 28
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
...ument.
>
> I do not know whether R-core feels this is something packages/users should be able to do; both decisions strike me as possible, to be honest, depending on details I don't know and/or am not privy to.
>
> Best,
> ~G
>
> On Fri, Apr 28, 2023 at 1:49?PM Karolis Koncevi?ius <karolis.koncevicius at gmail.com <mailto:karolis.koncevicius at gmail.com>> wrote:
>> This issue might go deeper - I was not successful in passing R CMD checks for the usage files. R CMD check kept showing errors for `@` declarations, even thou they were identical to `$` decl...
2019 Dec 14
0
Inconsistencies in wilcox.test
>>>>> Martin Maechler
>>>>> on Thu, 12 Dec 2019 17:20:47 +0100 writes:
>>>>> Karolis Koncevi?ius
>>>>> on Mon, 9 Dec 2019 23:43:36 +0200 writes:
>> So I tried adding Infinity support for all cases. And it
>> is (as could be expected) more complicated than I
>> thought.
> "Of course !" Thank you, Karolis, in any case!...
2019 Dec 09
0
Inconsistencies in wilcox.test
...y remove Infinity
support from the paired=TRUE case.
But going with the more desirable approach of adding Infinity support
for non-paired cases - it is currently not clear to me what confidence
intervals and pseudomedian should be. Specially when Infinities are on
both sides.
Regards,
Karolis Koncevi?ius.
On 2019-12-07 23:18, Karolis Koncevi?ius wrote:
>Thank you for a fast response. Nice to see this mailing list being so
>alive.
>
>Regarding Inf issue: I agree with your assessment that Inf should not
>be removed. The code gave me an impression that Inf values were
>inten...
2023 Apr 28
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
...en maintainers' job to fix or document.
I do not know whether R-core feels this is something packages/users should
be able to do; both decisions strike me as possible, to be honest,
depending on details I don't know and/or am not privy to.
Best,
~G
On Fri, Apr 28, 2023 at 1:49?PM Karolis Koncevi?ius <
karolis.koncevicius at gmail.com> wrote:
> This issue might go deeper - I was not successful in passing R CMD checks
> for the usage files. R CMD check kept showing errors for `@` declarations,
> even thou they were identical to `$` declarations (which passed fine).
>
>...
2023 Apr 28
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
...cks for the usage files. R CMD check kept showing errors for `@` declarations, even thou they were identical to `$` declarations (which passed fine).
Seems like the usage check functions are not prepared for `@` - also in tools:::.S3_method_markup_regexp
> On Apr 28, 2023, at 10:34 PM, Karolis Koncevi?ius <karolis.koncevicius at gmail.com> wrote:
>
> I was building a package that uses the new generic @ and kept having errors with ?roxygen2? documentation. ?roxygen2? generated NAMESPACE added `@.newclass` as a newly exported function, not as a S3method.
>
> At first I thought...
2019 Dec 07
0
Inconsistencies in wilcox.test
...ouble.eps)), but it's
delicate and somewhat subjective/problem-dependent.
Example:
options(digits=20)
> unique(c(4,3,2)-c(3,2,1))
[1] 1
> unique(c(0.4,0.3,0.2)-c(0.3,0.2,0.1))
[1] 0.100000000000000033307 0.099999999999999977796 0.100000000000000005551
On 2019-12-07 1:55 p.m., Karolis Koncevi?ius wrote:
> Hello,
>
> Writing to share some things I've found about wilcox.test() that seem a
> a bit inconsistent.
>
> 1. Inf values are not removed if paired=TRUE
>
> # returns different results (Inf is removed):
> wilcox.test(c(1,2,3,4), c(0,9,8,7))
> wilco...
2019 Dec 07
0
Inconsistencies in wilcox.test
>>>>> Karolis Koncevi?ius
>>>>> on Sat, 7 Dec 2019 20:55:36 +0200 writes:
> Hello,
> Writing to share some things I've found about wilcox.test() that seem a
> a bit inconsistent.
> 1. Inf values are not removed if paired=TRUE
> # returns different results (In...
2019 Jun 21
1
[Suggested patch] to fligner.test - constant values can produce significant results
...es that g is a factor:
x <- x - tapply(x,g,median)[g]
+ if (all(x == 0))
+ stop("data are essentially constant")
a <- qnorm((1 + rank(abs(x)) / (n + 1)) / 2)
STATISTIC <- sum(tapply(a, g, "sum")^2 / tapply(a, g, "length"))
---
Karolis Koncevi?ius
[[alternative HTML version deleted]]
2019 Jun 18
0
Small bug in fligner.test - constant values can produce significant results (patch attached)
...hat should solve the issue by producing an error "data is essentially constant"
- which is the same error message found in t-test under similar conditions.
P.S. First time writing to this list. Read all the guides of posting, but sorry in advance if I still missed any rules.
---
Karolis Koncevi?ius
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.diff
URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20190619/0642547d/attachment.ksh>
2023 Apr 28
1
Should '@" now be listed in tools:::.get_internal_S3_generics() ?
...R. But after some investigation I found that ?roxygen2? is using tools:::.get_internal_S3_generis() to decide if the method should be exported as S3method or not. For some reason ?@<-? is listed in there, but ?@? is not.
Am I missing some context, or is this an oversight?
Kind regards,
Karolis Koncevicius
2020 Apr 13
1
stringsAsFactors
Hello,
I also want to report 2 missed cases of stringsAsFactors=TRUE in base:
1. grid.expand() still uses hard stringsAsFactors=TRUE in its arguments.
2. as.data.frame.table() also keeps factors after conversion from table.
>>>>>> Duncan Murdoch
>>>>>> on Sun, 12 Apr 2020 08:57:14 -0400 writes:
>
> > The NEWS for R 4.0.0 says "R now uses
2020 Feb 16
1
Why is any() only defined for a numeric and not logical data.frame?
Hello,
I recently stumbled on an unusual behaviour of any() and all() and have
been adviced from StackOverflow to share it here [1].
df1 <- data.frame(A=TRUE, B=FALSE)
df2 <- data.frame(A=1, B=0)
> any(df1)
Error in FUN(X[[i]], ...):
only defined on a data frame with all numeric variables
> any(df2)
[1] TRUE
Warning message: In any(c(1,