search for: kobjects

There are plenty of using kobject_del() and kobject_put() together in the kernel tree. This patch wraps these two calls in a single helper. Signed-off-by: Yangtao Li <frank.li at vivo.com> --- v2: -add kobject_del_and_put() users resend patchset to gregkh, Rafael and Damien include/linux/kobject.h | 1 + lib/kobject.c | 17 +++++++++++++++-- 2 files changed, 16 insertions(+), 2

There are plenty of using kobject_del() and kobject_put() together in the kernel tree. This patch wraps these two calls in a single helper. Signed-off-by: Yangtao Li <frank.li at vivo.com> --- v3: -convert to inline helper v2: -add kobject_del_and_put() users include/linux/kobject.h | 13 +++++++++++++ lib/kobject.c | 3 +-- 2 files changed, 14 insertions(+), 2 deletions(-)

Useful for locating buggy drivers on kernel oops. It may add dozens of new lines to boot dmesg. DEBUG_KOBJECT_RELEASE is hopefully only enabled in debug kernels (like maybe the Fedora rawhide one, or at developers), so being a bit more verbose is likely ok. CC: Russell King - ARM Linux <linux@arm.linux.org.uk> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url:

Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url:

...ed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Note, I can remove a lot more sysfs-related code in here, to make it much simpler if you want me to. But that would make this file pretty messy if you need to keep backwards compatibility with old kernels. Also, the lifetime rules for your kobjects seem very suspect. Especially as you have a completion handler for your release functions. I can rework this if needed too. Time to go download the userspace tools to make sure I don't break anything really badly... diff -u btrfs-unstable-18f284b2de93.orig/sysfs.c btrfs-unstable-18f284b2de93...

Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?

Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?

On Mon, Sep 23, 2019 at 11:20:12PM +0800, kbuild test robot wrote: > Hi Jason, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [cannot apply to v5.3 next-20190920] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to

On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang <jasowang at redhat.com> wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus match method to pair the mdev device > and mdev

On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang <jasowang at redhat.com> wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus match method to pair the mdev device > and mdev

Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we need to add device class id support in bus match method to pair the mdev device and mdev driver correctly. So this patch adds id_table to mdev_driver and class_id for mdev device with the match method

On Tue, 24 Sep 2019 21:53:29 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Tue, 24 Sep 2019 21:53:29 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

Hi all, Out of consideration for minimizing disruption, I did not send the patchset to everyone. However, it seems that my consideration was unnecessary, so I CC'd everyone on the first patch. If you would like to see the entire patchset, you can access it at this address. https://lore.kernel.org/lkml/20230319092641.41917-1-frank.li at vivo.com/ Thx, Yangtao

On 3/20/23 12:34, Yangtao Li wrote: > Hi all, > > Out of consideration for minimizing disruption, I did not send the > patchset to everyone. However, it seems that my consideration was > unnecessary, so I CC'd everyone on the first patch. If you would > like to see the entire patchset, you can access it at this address. > >

Hi filesystem maintainers, > Hard to comment on patches with this. It is only 10 patches. So send everything please. If you are interested in the entire patchset besides Damien, please let me know. I'll resend the email later to cc more people. Thx, Yangtao

On Tue, 24 Sep 2019 21:53:26 +0800 Jason Wang <jasowang at redhat.com> wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus match method to pair the mdev device > and mdev

On Mon, 4 Nov 2019 20:39:47 +0800 Jason Wang <jasowang at redhat.com> wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus match method to pair the mdev device > and mdev

Currently, except for the create and remove, the rest of mdev_parent_ops is designed for vfio-mdev driver only and may not help for kernel mdev driver. With the help of class id, this patch introduces device specific callbacks inside mdev_device structure. This allows different set of callback to be used by vfio-mdev and virtio-mdev. Signed-off-by: Jason Wang <jasowang at redhat.com> ---