search for: kledzik

On Mon, Oct 6, 2014 at 5:00 PM, Nick Kledzik <kledzik at apple.com> wrote: > On Oct 6, 2014, at 3:44 PM, Rui Ueyama <ruiu at google.com> wrote: > > Looks like most people in this thread support using LLVM style in LLD. I > also had an offline discussion and many people wanted to have one coding > style in all LLVM...

...ly checking if it could be avoided (probably some refactoring will be needed). However I was wondering if it might not be easier to just avoid this clash at all by avoiding it in LLVM. Alternatively I could #undef everything right after including Windows.h. On Thu, Aug 29, 2013 at 11:08 AM, Nick Kledzik <kledzik at apple.com> wrote: > > On Aug 28, 2013, at 7:05 PM, Virgile Bello <virgile.bello at gmail.com> > wrote: > > Right now, we have: > In COFF.h: > class COFF { enum MachineTypes { IMAGE_FILE_MACHINE_UNKNOWN = 0x0, > ... }; }; > In windows.h: >...

On Jul 30, 2013, at 4:28 PM, Eric Christopher wrote: > On Mon, Jul 29, 2013 at 9:24 AM, Nick Kledzik <kledzik at apple.com> wrote: >> >> On Jul 25, 2013, at 2:10 PM, Rui Ueyama wrote: >>> Is there any reason -ffunction-sections and -fdata-sections wouldn't work? If it'll work, it may be be better to say "if you want to get a better linker output use these o...

On Tue, Jul 30, 2013 at 5:36 PM, Nick Kledzik <kledzik at apple.com> wrote: > > On Jul 30, 2013, at 4:28 PM, Eric Christopher wrote: >> On Mon, Jul 29, 2013 at 9:24 AM, Nick Kledzik <kledzik at apple.com> wrote: >>> >>> On Jul 25, 2013, at 2:10 PM, Rui Ueyama wrote: >>>> Is there any reason...

...ncredibly slim :) You can't include the separate headers (winbase.h etc), you have to just include windows.h Windows defines IMAGE_* whether we like it or not, we can't stop it doing it, so the only reasonable solution is to change LLVM to have it's own set of constant names. Nick Kledzik wrote: > In the Windows SDK headers, is the IMAGE_* defines in a separate file (e.g. winint.h)? Does the file have a guard against multiple inclusion? If so (and the guard was named _WINNT_H_), perhaps you can do something like: > > #define _WINNT_H_ > #include<windows.h> > &...

...e avoided (probably some refactoring will be needed). However I was wondering if it might not be easier to just avoid this clash at all by avoiding it in LLVM. > > Alternatively I could #undef everything right after including Windows.h. > > > On Thu, Aug 29, 2013 at 11:08 AM, Nick Kledzik <kledzik at apple.com> wrote: > > On Aug 28, 2013, at 7:05 PM, Virgile Bello <virgile.bello at gmail.com> wrote: >> Right now, we have: >> In COFF.h: >> class COFF { enum MachineTypes { IMAGE_FILE_MACHINE_UNKNOWN = 0x0, ... }; }; >> In windows.h: &gt...

...u first include COFF.h and then windows.h, COFF::IMAGE_FILE_MACHINE_UNKNOWN will be preprocessed into COFF:0. * If you first include Windows.h and then COFF.h, COFF.h won't work because it's enum will become: enum MachinTypes { 0 = 0x0 }; On Thu, Aug 29, 2013 at 6:03 AM, Nick Kledzik <kledzik at apple.com> wrote: > > On Aug 27, 2013, at 5:56 PM, Virgile Bello <virgile.bello at gmail.com> > wrote: > > Yes of course I understand it was done on purpose. > It's just that it makes it impossible to include COFF.h and Windows.h side > by side (whi...

On Tue, May 7, 2013 at 10:08 PM, Nick Kledzik <kledzik at apple.com> wrote: > Shankar, > > Do you mean add a method like: > > virtual unsigned contentHash() const = 0; > > or maybe: > > virtual llvm::hash_code contentHash() const = 0 > > to lld::DefinedAtom? That seems good to me. We just ne...

...hat you mentioned, I think there needs a special *AliasReference* that need to be created which the DefinedAtom points to. Thanks Shankar Easwaran -------- Original Message -------- Subject: Re: [PATCH] Add a fallback mechanism for undefined atom. Date: Thu, 29 Aug 2013 15:15:49 -0700 From: kledzik at apple.com <kledzik at apple.com> Reply-To: reviews+D1550+public+25c98da67f89e22f at llvm-reviews.chandlerc.com To: shankarke at gmail.com, kledzik at apple.com, bigcheesegs at gmail.com, ruiu at google.com CC: llvm-commits at cs.uiuc.edu Interesting feature. What happens if a...

On 7/30/2013 7:50 PM, Eric Christopher wrote: > On Tue, Jul 30, 2013 at 5:36 PM, Nick Kledzik <kledzik at apple.com> wrote: >> On Jul 30, 2013, at 4:28 PM, Eric Christopher wrote: >>> On Mon, Jul 29, 2013 at 9:24 AM, Nick Kledzik <kledzik at apple.com> wrote: >>>> On Jul 25, 2013, at 2:10 PM, Rui Ueyama wrote: >>>>> Is there any reason -...

On Wed, Jun 20, 2012 at 12:36 PM, Nick Kledzik <kledzik at apple.com> wrote: > On Jun 20, 2012, at 12:28 AM, Chandler Carruth wrote: >> On Tue, Jun 19, 2012 at 11:18 AM, Jeffrey Yasskin <jyasskin at google.com> wrote: >> On Jun 18, 2012 1:24 PM, "Nick Kledzik" <kledzik at apple.com> wrote: >> &gt...

On Sep 24, 2013, at 4:07 PM, Sean Silva <chisophugis at gmail.com> wrote: > On Tue, Sep 24, 2013 at 4:17 PM, Nick Kledzik <kledzik at apple.com> wrote: > > On Sep 24, 2013, at 12:40 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > >> On Tue, Sep 24, 2013 at 12:33 PM, Rui Ueyama <ruiu at google.com> wrote: >> Hi LLD developers, >> >> I'm about to make a c...

On Tue, Jun 19, 2012 at 11:18 AM, Jeffrey Yasskin <jyasskin at google.com>wrote: > On Jun 18, 2012 1:24 PM, "Nick Kledzik" <kledzik at apple.com> wrote: > > > > On Jun 16, 2012, at 3:51 PM, Chris Lattner wrote: > > > On Jun 15, 2012, at 3:48 PM, Nick Kledzik wrote: > > > > > >> In lld we have a Reader class which is a factory that takes .o > file(s) and produces...

...something like: enum CodeModel { // Note: all these values need word smithing codeNA, codeMIPS_PIC, codeMIPS_micro, codeMIPS_16, codeARM_16, codeARM_32, }; virtual CodeModel codeModel() { return codeNA; } -Nick > > On Tue, Nov 11, 2014 at 11:19 AM, Nick Kledzik <kledzik at apple.com> wrote: > I had a similar issue with arm vs thumb in mach-o. Each function’s thumbness is marked in its symbol table entry. > > But it is even worse, a function could change encoding in the middle (only hand coded assembly could do this). > > My solutio...

On Tue, Sep 24, 2013 at 4:44 PM, Nick Kledzik <kledzik at apple.com> wrote: > > On Sep 24, 2013, at 4:07 PM, Sean Silva <chisophugis at gmail.com> wrote: > > On Tue, Sep 24, 2013 at 4:17 PM, Nick Kledzik <kledzik at apple.com> wrote: > >> >> On Sep 24, 2013, at 12:40 PM, Michael Spencer <bigchee...

I’d like to discuss revising the LLVM coding conventions to change the naming of variables to start with a lowercase letter. This should not be a discussion on the pain of such a transition, or how to get from here to there, but rather, if there is a better place to be. My arguments for the change are: 1. No other popular C++ coding style uses capitalized variable names. For instance here

...being included at all? That header does not exist on some OS’s so the code would not build be portable. If this use is in the one or two files of llvm that implement platform support, why is COFF.h being included in those instances? -Nick > > > On Thu, Aug 29, 2013 at 6:03 AM, Nick Kledzik <kledzik at apple.com> wrote: > > On Aug 27, 2013, at 5:56 PM, Virgile Bello <virgile.bello at gmail.com> wrote: > >> Yes of course I understand it was done on purpose. >> It's just that it makes it impossible to include COFF.h and Windows.h side by side (whic...

On Wed, Oct 8, 2014 at 7:20 PM, Nick Kledzik <kledzik at apple.com> wrote: > Sure, I actually have no problem with this. > > I'm going to point out that one of the naming conventions used by LLD has > serious problems: naming variables with a leading underscore puts them > *way* too close to the reserved identifier s...

On May 8, 2012, at 3:41 PM, Michael Spencer wrote: > On Mon, May 7, 2012 at 12:56 PM, Nick Kledzik <kledzik at apple.com> wrote: >> For the reasons listed in my 03-May-2012 email, I am proposing a new >> llvm/Support class for using in writing binary files: >> >> /// OutputBuffer - This interface provides simple way to create an in-memory >> /// buffer which...

On Tue, Mar 24, 2015 at 5:40 PM, Nick Kledzik <kledzik at apple.com> wrote: > > On Mar 24, 2015, at 5:09 PM, Rui Ueyama <ruiu at google.com> wrote: > > > It's not a big deal, but it always annoyed me a bit when I hit it, so > I'll bring it up here. > > > > LLD represents an alignment X as log2...