Displaying 9 results from an estimated 9 matches for "klaebe".
2014 May 11
7
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
...occinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
- SET_ETHTOOL_OPS(dev, ops);
+ dev->ethtool_ops = ops;
Compile tested only, but I'd seriously wonder if this broke anything.
Suggested-by: Dave Miller <davem at davemloft.net>
Signed-off-by: Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de>
---
Applies against v3.15-rc4 and v3.15-rc5 likewise.
resend: trimmed CC list. Thanks to Dave for notifying me.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index c4b3940..078cadd 100644
---...
2014 May 11
7
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
...occinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
- SET_ETHTOOL_OPS(dev, ops);
+ dev->ethtool_ops = ops;
Compile tested only, but I'd seriously wonder if this broke anything.
Suggested-by: Dave Miller <davem at davemloft.net>
Signed-off-by: Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de>
---
Applies against v3.15-rc4 and v3.15-rc5 likewise.
resend: trimmed CC list. Thanks to Dave for notifying me.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index c4b3940..078cadd 100644
---...
2014 May 11
7
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
...occinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
- SET_ETHTOOL_OPS(dev, ops);
+ dev->ethtool_ops = ops;
Compile tested only, but I'd seriously wonder if this broke anything.
Suggested-by: Dave Miller <davem at davemloft.net>
Signed-off-by: Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de>
---
Applies against v3.15-rc4 and v3.15-rc5 likewise.
resend: trimmed CC list. Thanks to Dave for notifying me.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index c4b3940..078cadd 100644
---...
2014 May 08
0
[PATCH] net: get rid of SET_ETHTOOL_OPS
I think that it may be appropriate to submit this patch for linux-next
instead of 3.15-rc4...
On Thu, May 8, 2014 at 1:53 PM, Wilfried Klaebe
<w-lkml at lebenslange-mailadresse.de> wrote:
> Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
> This does that.
>
> Compile tested only, but I'd seriously wonder if this broke anything.
>
> Suggested-by: Dave Miller <davem at davemloft.net>
>...
2014 May 11
0
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
SET_ETHTOOL_OPS is equivalent to :
#define SET_ETHTOOL_OPS(netdev,ops) \
( (netdev)->ethtool_ops = (ops) )
how it makes difference removing this code and replacing with the
code mentioned ?
On Sun, May 11, 2014 at 5:42 AM, Wilfried Klaebe
<w-lkml at lebenslange-mailadresse.de> wrote:
> net: get rid of SET_ETHTOOL_OPS
>
> Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
> This does that.
>
> Mostly done via coccinelle script:
> @@
> struct ethtool_ops *ops;
> struct net_device *dev;
&g...
2014 May 11
0
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
SET_ETHTOOL_OPS is equivalent to :
#define SET_ETHTOOL_OPS(netdev,ops) \
( (netdev)->ethtool_ops = (ops) )
how it makes difference removing this code and replacing with the
code mentioned ?
On Sun, May 11, 2014 at 5:42 AM, Wilfried Klaebe
<w-lkml at lebenslange-mailadresse.de> wrote:
> net: get rid of SET_ETHTOOL_OPS
>
> Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
> This does that.
>
> Mostly done via coccinelle script:
> @@
> struct ethtool_ops *ops;
> struct net_device *dev;
&g...
2014 May 08
2
[PATCH] net: get rid of SET_ETHTOOL_OPS
Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
This does that.
Compile tested only, but I'd seriously wonder if this broke anything.
Suggested-by: Dave Miller <davem at davemloft.net>
Signed-off-by: Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de>
---
Applies against v3.15-rc4.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index c4b3940..078cadd 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
+++ b/drivers/infiniband/ulp/ipoib...
2014 May 08
2
[PATCH] net: get rid of SET_ETHTOOL_OPS
Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
This does that.
Compile tested only, but I'd seriously wonder if this broke anything.
Suggested-by: Dave Miller <davem at davemloft.net>
Signed-off-by: Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de>
---
Applies against v3.15-rc4.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
index c4b3940..078cadd 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
+++ b/drivers/infiniband/ulp/ipoib...
2014 May 11
0
[PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana:
> SET_ETHTOOL_OPS is equivalent to :
> #define SET_ETHTOOL_OPS(netdev,ops) \
> ( (netdev)->ethtool_ops = (ops) )
>
> how it makes difference removing this code and replacing with the
> code mentioned ?
It doesn't change anything in the resulting binaries. The whole point
is to remove the macro, which is