search for: kick_vq_with_data

Add VIRTIO_F_NOTIFICATION_DATA support for vDPA transport. If this feature is negotiated, the driver passes extra data when kicking a virtqueue. A device that offers this feature needs to implement the kick_vq_with_data callback. kick_vq_with_data receives the vDPA device and data. data includes the vqn, next_off and next_wrap for packed virtqueues. This patch follows a patch [1] by Viktor Prutyanov which adds support for the MMIO, channel I/O and modern PCI transports. This patch needs to be applied on top of...

Add VIRTIO_F_NOTIFICATION_DATA support for vDPA transport. If this feature is negotiated, the driver passes extra data when kicking a virtqueue. A device that offers this feature needs to implement the kick_vq_with_data callback. kick_vq_with_data receives the vDPA device and data. data includes: 16 bits vqn and 16 bits next available index for split virtqueues. 16 bits vqs, 15 least significant bits of next available index and 1 bit next_wrap for packed virtqueues. This patch follows a patch [1] by Viktor Pruty...

On Sun, Apr 02, 2023 at 11:10:34AM +0300, Alvaro Karsz wrote: > Add VIRTIO_F_NOTIFICATION_DATA support for vDPA transport. > If this feature is negotiated, the driver passes extra data when kicking > a virtqueue. > > A device that offers this feature needs to implement the > kick_vq_with_data callback. > > kick_vq_with_data receives the vDPA device and data. > data includes the vqn, next_off and next_wrap for packed virtqueues. > > This patch follows a patch [1] by Viktor Prutyanov which adds support > for the MMIO, channel I/O and modern PCI transports. > > T...

...0?PM Alvaro Karsz <alvaro.karsz at solid-run.com> wrote: > > Add VIRTIO_F_NOTIFICATION_DATA support for vDPA transport. > If this feature is negotiated, the driver passes extra data when kicking > a virtqueue. > > A device that offers this feature needs to implement the > kick_vq_with_data callback. > > kick_vq_with_data receives the vDPA device and data. > data includes the vqn, next_off and next_wrap for packed virtqueues. > > This patch follows a patch [1] by Viktor Prutyanov which adds support > for the MMIO, channel I/O and modern PCI transports. > > This...

> Hmm so I conclude that drivers without kick_vq_with_data > should not accept VIRTIO_F_NOTIFICATION_DATA then? Yes, vDPA drivers without kick_vq_with_data should not offer VIRTIO_F_NOTIFICATION_DATA in the first place. We can be more forgiving in such cases and clear the feature bit + print a warning. It may be easier to debug when creating a new vD...

On Tue, Apr 4, 2023 at 3:20?PM Alvaro Karsz <alvaro.karsz at solid-run.com> wrote: > > > > + * @kick_vq_with_data: Kick the virtqueue and supply extra data > > > + * (only if VIRTIO_F_NOTIFICATION_DATA is negotiated) > > > + * @vdev: vdpa device > > > + * @data: includes vqn, next_off and next...