search for: kick_sync

..._vq, > > > + unsigned int head, > > > + bool indirect, > > > + struct vring_desc *indirect_desc, > > > + void *data, > > > + void *ctx); > > > + > > > bool virtqueue_kick(struct virtqueue *vq); > > > +bool virtqueue_kick_sync(struct virtqueue *vq); > > > + > > > +bool virtqueue_kick_async(struct virtqueue *vq, wait_queue_head_t wq); > > > + > > > bool virtqueue_kick_prepare(struct virtqueue *vq); > > > bool virtqueue_notify(struct virtqueue *vq); > > I don't muc...

..._vq, > > > + unsigned int head, > > > + bool indirect, > > > + struct vring_desc *indirect_desc, > > > + void *data, > > > + void *ctx); > > > + > > > bool virtqueue_kick(struct virtqueue *vq); > > > +bool virtqueue_kick_sync(struct virtqueue *vq); > > > + > > > +bool virtqueue_kick_async(struct virtqueue *vq, wait_queue_head_t wq); > > > + > > > bool virtqueue_kick_prepare(struct virtqueue *vq); > > > bool virtqueue_notify(struct virtqueue *vq); > > I don't muc...

On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > So the way I see it, there are several issues: > > > > - internal wait - forces multiple APIs like kick/kick_sync > > note how kick_sync can fail but your code never checks return code > > - need to re-write the last descriptor - might not work > > for alternative layouts which always expose descriptors > > immediately > > Probably it wasn't clear. Please let me expl...

On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > So the way I see it, there are several issues: > > > > - internal wait - forces multiple APIs like kick/kick_sync > > note how kick_sync can fail but your code never checks return code > > - need to re-write the last descriptor - might not work > > for alternative layouts which always expose descriptors > > immediately > > Probably it wasn't clear. Please let me expl...

...in wrote: > > On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: > > > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > So the way I see it, there are several issues: > > > > > > > > - internal wait - forces multiple APIs like kick/kick_sync > > > > note how kick_sync can fail but your code never checks return code > > > > - need to re-write the last descriptor - might not work > > > > for alternative layouts which always expose descriptors > > > > immediately > > > P...

...in wrote: > > On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: > > > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > So the way I see it, there are several issues: > > > > > > > > - internal wait - forces multiple APIs like kick/kick_sync > > > > note how kick_sync can fail but your code never checks return code > > > > - need to re-write the last descriptor - might not work > > > > for alternative layouts which always expose descriptors > > > > immediately > > > P...

On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > So the way I see it, there are several issues: > > - internal wait - forces multiple APIs like kick/kick_sync > note how kick_sync can fail but your code never checks return code > - need to re-write the last descriptor - might not work > for alternative layouts which always expose descriptors > immediately Probably it wasn't clear. Please let me explain the two functions here: 1...

...4/2017 04:19 AM, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: >> On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: >>> So the way I see it, there are several issues: >>> >>> - internal wait - forces multiple APIs like kick/kick_sync >>> note how kick_sync can fail but your code never checks return code >>> - need to re-write the last descriptor - might not work >>> for alternative layouts which always expose descriptors >>> immediately >> Probably it wasn't clear. Pleas...

...at 03:42:35PM +0800, Wei Wang wrote: > > > > > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > > > So the way I see it, there are several issues: > > > > > > > > > > > > - internal wait - forces multiple APIs like kick/kick_sync > > > > > > note how kick_sync can fail but your code never checks return code > > > > > > - need to re-write the last descriptor - might not work > > > > > > for alternative layouts which always expose descriptors > > > >...

...at 03:42:35PM +0800, Wei Wang wrote: > > > > > On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: > > > > > > So the way I see it, there are several issues: > > > > > > > > > > > > - internal wait - forces multiple APIs like kick/kick_sync > > > > > > note how kick_sync can fail but your code never checks return code > > > > > > - need to re-write the last descriptor - might not work > > > > > > for alternative layouts which always expose descriptors > > > >...

...e: >>> On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: >>>> On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: >>>>> So the way I see it, there are several issues: >>>>> >>>>> - internal wait - forces multiple APIs like kick/kick_sync >>>>> note how kick_sync can fail but your code never checks return code >>>>> - need to re-write the last descriptor - might not work >>>>> for alternative layouts which always expose descriptors >>>>> immediately >>&...

...+ bool in); > + > +int virtqueue_add_chain(struct virtqueue *_vq, > + unsigned int head, > + bool indirect, > + struct vring_desc *indirect_desc, > + void *data, > + void *ctx); > + > bool virtqueue_kick(struct virtqueue *vq); > > +bool virtqueue_kick_sync(struct virtqueue *vq); > + > +bool virtqueue_kick_async(struct virtqueue *vq, wait_queue_head_t wq); > + > bool virtqueue_kick_prepare(struct virtqueue *vq); > > bool virtqueue_notify(struct virtqueue *vq); I don't much care for this API. It does exactly what balloon need...

...+ bool in); > + > +int virtqueue_add_chain(struct virtqueue *_vq, > + unsigned int head, > + bool indirect, > + struct vring_desc *indirect_desc, > + void *data, > + void *ctx); > + > bool virtqueue_kick(struct virtqueue *vq); > > +bool virtqueue_kick_sync(struct virtqueue *vq); > + > +bool virtqueue_kick_async(struct virtqueue *vq, wait_queue_head_t wq); > + > bool virtqueue_kick_prepare(struct virtqueue *vq); > > bool virtqueue_notify(struct virtqueue *vq); I don't much care for this API. It does exactly what balloon need...

...2017 at 03:42:35PM +0800, Wei Wang wrote: >>>>>> On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: >>>>>>> So the way I see it, there are several issues: >>>>>>> >>>>>>> - internal wait - forces multiple APIs like kick/kick_sync >>>>>>> note how kick_sync can fail but your code never checks return code >>>>>>> - need to re-write the last descriptor - might not work >>>>>>> for alternative layouts which always expose descriptors >>>>>&...