search for: keepclass2

On 24/01/2018 6:35 PM, G?bor Cs?rdi wrote: > When you create a branch for your bug fix, don't create it off the > previous fix. Create it off the original, forked state of the repo. Branches keepclass2 through to keepclass5 are my attempts to do that. As far as I can see they are all the same as keepclass, which was branched from the head of the master branch of my fork. > > Are the two commits here your fixes? > https://github.com/dmurdoch/manipulateWidget/commits/master Those are b...

...PM, Duncan Murdoch <murdoch.duncan at gmail.com> wrote: > On 24/01/2018 6:35 PM, G?bor Cs?rdi wrote: >> >> When you create a branch for your bug fix, don't create it off the >> previous fix. Create it off the original, forked state of the repo. > > > Branches keepclass2 through to keepclass5 are my attempts to do that. As far > as I can see they are all the same as keepclass, which was branched from the > head of the master branch of my fork. >> >> >> Are the two commits here your fixes? >> https://github.com/dmurdoch/manipulateWidget...

...ch.duncan at gmail.com> wrote: >> On 24/01/2018 6:35 PM, G?bor Cs?rdi wrote: >>> >>> When you create a branch for your bug fix, don't create it off the >>> previous fix. Create it off the original, forked state of the repo. >> >> >> Branches keepclass2 through to keepclass5 are my attempts to do that. As far >> as I can see they are all the same as keepclass, which was branched from the >> head of the master branch of my fork. >>> >>> >>> Are the two commits here your fixes? >>> https://github.com/d...

Lately I've been doing some work with the manipulateWidget package, which lives on Github at https://github.com/rte-antares-rpackage/manipulateWidget/. Last week I found a bug, so being a good community member, I put together a patch. Since the package lives on Github, I followed instructions to put together a "pull request": - I forked the main branch to my own Github account