search for: keep_empty

On Mon, Jan 30, 2017 at 10:43:15PM +0100, Tomáš Golembiovský wrote: > Added two new optional arguments to nsplit: > > * keep_empty: if set to false empty elements are not stored in the > returned list. The default is to keep the empty elements The ?keep_empty flag is pointless. It's simpler and more clear to write: List.filter ((<>) "") (nsplit ...) when you don't want empty elements. Howeve...

Added two new optional arguments to nsplit: * keep_empty: if set to false empty elements are not stored in the returned list. The default is to keep the empty elements * count: specifies how many splits to perform; negative count (the default) means do as many splits as possible Added tests for nsplit. Signed-off-by: Tomáš Golembiovský <tgolemb...

...biovský wrote: > On Tue, 31 Jan 2017 11:35:01 +0000 > "Richard W.M. Jones" <rjones@redhat.com> wrote: > > > On Mon, Jan 30, 2017 at 10:43:15PM +0100, Tomáš Golembiovský wrote: > > > Added two new optional arguments to nsplit: > > > > > > * keep_empty: if set to false empty elements are not stored in the > > > returned list. The default is to keep the empty elements > > > > The ?keep_empty flag is pointless. It's simpler and more > > clear to write: > > > > List.filter ((<>) "")...

On Tue, 31 Jan 2017 11:35:01 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > On Mon, Jan 30, 2017 at 10:43:15PM +0100, Tomáš Golembiovský wrote: > > Added two new optional arguments to nsplit: > > > > * keep_empty: if set to false empty elements are not stored in the > > returned list. The default is to keep the empty elements > > The ?keep_empty flag is pointless. It's simpler and more > clear to write: > > List.filter ((<>) "") (nsplit ...) > > when...

v5: - rebase, patches 1,3,5 were merged - 1/3: we still need to discuss whether to detect compressed discs - 2/3: - renamed argument noempty to keep_empty - tests were not run - 3/3: - using JSON module to generate JSON (as suggested by Pino) - all the other comments raised by Pino v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards...

v6: - just rebase v5: - rebase, patches 1,3,5 were merged - 1/3: we still need to discuss whether to detect compressed discs - 2/3: - renamed argument noempty to keep_empty - tests were not run - 3/3: - using JSON module to generate JSON (as suggested by Pino) - all the other comments raised by Pino v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards...

On Sunday, 18 December 2016 23:16:31 CET Tomáš Golembiovský wrote: > Added two new optional arguments to nsplit: > > * noempty: if set to false empty elements are not stored in the returned > list. The default is to keep the empty elements > > * count: specifies how many splits to perform; negative count > (the default) means do as many splits as possible > >

...lines with + | [] -> raise Not_found + | line :: lines -> ( + (* Lines have the form: + * block <offset>: <perms> <owner>/<group> <size> <mdate> <mtime> <file> + *) + let elems = String.nsplit ~keep_empty:false ~count:7 " " line in + if List.length elems = 8 && List.hd elems = "block" then ( + let elems = Array.of_list elems in + let offset = elems.(1) in + let size = elems.(4) in + let fname = elems.(7) in + +...

...een dropped (2/3) - addressed Richard's comments, notably the subfolder function was moved to mllib and renamed to subdirectory v6: - just rebase v5: - rebase, patches 1,3,5 were merged - 1/3: we still need to discuss whether to detect compressed discs - 2/3: - renamed argument noempty to keep_empty - tests were not run - 3/3: - using JSON module to generate JSON (as suggested by Pino) - all the other comments raised by Pino v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards...

...een dropped (2/3) - addressed Richard's comments, notably the subfolder function was moved to mllib and renamed to subdirectory v6: - just rebase v5: - rebase, patches 1,3,5 were merged - 1/3: we still need to discuss whether to detect compressed discs - 2/3: - renamed argument noempty to keep_empty - tests were not run - 3/3: - using JSON module to generate JSON (as suggested by Pino) - all the other comments raised by Pino v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards...