search for: katsura

Dear libguestfs developers and users, it is my pleasure to welcome Hiroyuki Katsura as Google Summer of Code 2019 student for libguestfs! He will work on adding Rust bindings, to allow using libguestfs in Rust applications. You can read the project submission here: https://summerofcode.withgoogle.com/projects/#6730007286644736 I'm the main mentor of this project, with Rich J...

From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> This patch includes Actions and their tests. Missing: - Events - Examples Rust bindings: Add create / close functions Rust bindings: Add 4 bindings tests Rust bindings: Add generator of structs Rust bindings: Add generator of structs for optional argume...

Thanks. I'll summarize the project and issue an outline of the implementation to the mailing list soon. (I'm not familiar with mailing lists so I'm sorry if this message is passed to a wrong place.) Hiroyuki Katsura

....g) }; let message = unsafe { utils::char_ptr_to_string(c_msg).unwrap() }; diff --git a/rust/src/event.rs b/rust/src/event.rs new file mode 100644 index 000000000..942feec69 --- /dev/null +++ b/rust/src/event.rs @@ -0,0 +1,158 @@ +/* libguestfs Rust bindings + * Copyright (C) 2019 Hiroyuki Katsura <hiroyuki.katsura.0513@gmail.com> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later v...

...r the late reply. Most of the work is definitely nice! There are few notes below, although they are not big issues. I will check this patch once more on monday, especially the rust parts. Otherwise, I'd say that we are close to merging this :) On Tuesday, 23 July 2019 10:37:17 CEST Hiroyuki Katsura wrote: > From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> > > Rust bindings: Add create / close functions > > Rust bindings: Add 4 bindings tests > > Rust bindings: Add generator of structs > > Rust bindings: Add generator of structs for optional argumen...

Hi Hiroyuki, On Tuesday, 30 July 2019 07:51:37 CEST Hiroyuki Katsura wrote: > This patch includes: > > - Event callback handlers > - Tests related to events(410-430) > --- Would it be possible to split the Handle -> Handle<'a> change in an own small patch? This way it can be documented why it was changed. > +pub fn event_to_string(e...

I fixed based on comments. I'll send these two patches to this mailing list. - Fix Handle -> Handle<'a> - Add events Regards, Hiroyuki 2019年8月1日(木) 0:01 Pino Toscano <ptoscano@redhat.com>: > Hi Hiroyuki, > > On Tuesday, 30 July 2019 07:51:37 CEST Hiroyuki Katsura wrote: > > This patch includes: > > > > - Event callback handlers > > - Tests related to events(410-430) > > --- > > Would it be possible to split the Handle -> Handle<'a> change in an own > small patch? This way it can be documented why it was ch...

...ins dependencies, versions, editions, crate name. It can be generated by shellscript which dumps such information. However, I think it may be not preferable. Regards, Hiroyuki 2019年7月4日(木) 19:39 Richard W.M. Jones <rjones@redhat.com>: > On Tue, Jul 02, 2019 at 10:09:00PM +0900, Hiroyuki Katsura wrote: > > I fixed the patch I submitted before based on comments, and there are > some > > commits which are merged or divided. So, I will re-send all the patches. > > I looked at the v2 patches and I think they're in reasonable > shape. > > There's been a lot...

...9;static str) -> Error { let c_msg = unsafe { guestfs_last_error(self.g) }; diff --git a/rust/src/event.rs b/rust/src/event.rs index c363e913a..752e73610 100644 --- a/rust/src/event.rs +++ b/rust/src/event.rs @@ -1,4 +1,150 @@ +/* libguestfs Rust bindings + * Copyright (C) 2019 Hiroyuki Katsura <hiroyuki.katsura.0513@gmail.com> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later v...

...markdown is usable or not for now... > IMHO it is better to produce the code directly following > the style conventions. OK. I'll send the formatting patch. Regards, Hiroyuki 2019年8月13日(火) 19:44 Pino Toscano <ptoscano@redhat.com>: > On Tuesday, 13 August 2019 05:17:10 CEST Katsura Hiroyuki wrote: > > > > > 2019/08/13 1:01、Pino Toscano <ptoscano@redhat.com>のメール: > > > > > > On Sunday, 11 August 2019 06:42:21 CEST Hiroyuki Katsura wrote: > > >> `cargo doc` will generate docs with long descriptions. > > > > > &gt...

> 2019/08/13 1:01、Pino Toscano <ptoscano@redhat.com>のメール: > > On Sunday, 11 August 2019 06:42:21 CEST Hiroyuki Katsura wrote: >> `cargo doc` will generate docs with long descriptions. > > This is a nice start, although most probably it will not look that good > though (since the plain text output may be misrendered as markdown). > > I remember we talked about converting the POD texts to markd...

`cargo doc` will generate docs with long descriptions. I did not add the settings of outputting these docs to `/website`. This is because - by publishing this crate to crates.io, users can see the docs in `docs.rs` like `https://docs.rs/guestfs/<version>/guestfs/`. It is easy to hold multiple documents corresponding to each version. - the style of the documents generated by `cargo doc`

On Fri, Jul 05, 2019 at 08:37:20AM +0100, Richard W.M. Jones wrote: >On Fri, Jul 05, 2019 at 01:28:12PM +0900, Hiroyuki Katsura wrote: >> > Have you decided whether we need to commit the generated files >> > (Cargo.toml, Cargo.lock)? It looks like in this series those files >> > are still included and not added to .gitignore. >> >> I'm sorry I forgot adding Cargo.lock to .gitignor...

On Tue, Jul 30, 2019 at 02:51:37PM +0900, Hiroyuki Katsura wrote: >This patch includes: > >- Event callback handlers >- Tests related to events(410-430) >--- > generator/rust.ml | 38 ++++++- > rust/src/base.rs | 24 +++-- > rust/src/error.rs | 8 +- > rust/src/event.rs...

...::leak, you can assure that they live until the handle closes. But the buffer will be freed when the guestfs is dropped. So, passing this pointer will not cause memory leak. 2019年7月30日(火) 17:52 Martin Kletzander <mkletzan@redhat.com>: > On Tue, Jul 30, 2019 at 02:51:37PM +0900, Hiroyuki Katsura wrote: > >This patch includes: > > > >- Event callback handlers > >- Tests related to events(410-430) > >--- > > generator/rust.ml | 38 ++++++- > > rust/src/base.rs | 24 +++-- > > rust/src/error.rs...

On Tue, Jul 02, 2019 at 10:14:19PM +0900, Hiroyuki Katsura wrote: >From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> > >--- > Makefile.am | 4 ++++ > configure.ac | 3 +++ > generator/Makefile.am | 3 +++ > generator/bindtests.ml | 3 +++ > generator/bindtests.mli | 1 + > generator/main.ml...

On Thu, Jun 27, 2019 at 06:27:05PM +0900, Hiroyuki Katsura wrote: > > I guess this is a stray debug message? > > Yes. I'm sorry... > > > we did *not* check them into git. > > Really? Does it mean that every time you build the library, Cargo.toml is > generated? That's how it has worked in nbdkit. Whether it's...

Hi, I'm Hiroyuki Katsura. I will contribute to libguestfs as a Google Summer of Code project. I'll start to develop from next week. I'm going to work on the project "Create Rust bindings for libguestfs." Project summary is available here. https://summerofcode.withgoogle.com/projects/#6730007286644736 N...

On Fri, Jul 05, 2019 at 01:28:12PM +0900, Hiroyuki Katsura wrote: > > Have you decided whether we need to commit the generated files > > (Cargo.toml, Cargo.lock)? It looks like in this series those files > > are still included and not added to .gitignore. > > I'm sorry I forgot adding Cargo.lock to .gitignore. I'll add it...

Dear Rich I waited for Pino’s response because I failed to divide this patch into two commits as Pino thought. Is it OK? Regards, Hiroyuki > On Aug 6, 2019, at 23:16, Richard W.M. Jones <rjones@redhat.com> wrote: > > > These look fine to me and they don't break the build so I have > pushed both. > > Thanks. > > Rich. > > -- > Richard Jones,