search for: jumtables

...re. Not a very big saving in my mind. And it is offset by having to touch ARMInstrInfo.td. Also note, that the generic code generator must make some assumptions about the format of each jumptable entry (e.g. 32bit absolute addresses) so this cannot be changed easily afterwards. Having the default jumtables and the out of line version diverge too much and have different code path may also not be such a good idea. > Using TargetAsmInfo::JumpTableDataSection is one piece of that, but there > is more. As a start, you could change ARMJITInfo::hasCustomJumpTables and > the "Custom" ar...

...; mind. > And it is offset by having to touch ARMInstrInfo.td. > Also note, that the generic code generator must make some assumptions > about the format of each jumptable entry (e.g. 32bit absolute > addresses) so this cannot be changed easily afterwards. > > Having the default jumtables and the out of line version diverge too > much > and have different code path may also not be such a good idea. I'm not so much concerned about savings in the quantity of code as I am in keeping the ARM backend from diverging too far from the other LLVM backends. Sometimes we have...

...my mind. > And it is offset by having to touch ARMInstrInfo.td. > Also note, that the generic code generator must make some assumptions > about the format of each jumptable entry (e.g. 32bit absolute addresses) so > this cannot be changed easily afterwards. > > Having the default jumtables and the out of line version diverge too much > and have different code path may also not be such a good idea. > > > I'm not so much concerned about savings in the quantity of code as I am in > keeping the ARM backend from diverging too far from the other LLVM backends. > Some...

Hi Robert, Evan asked me to review this patch, and I have some questions about it. I apologize for not following the discussion earlier and for hitting you with questions after you've already gone through several revisions. LLVM provides some default behavior for handling jump tables, with the tables emitted separately from the code that uses them. The ARM backend provides its

Evan: Sorry for the late follow up, I was out of town last week. Enclosed please find the updated patch including all your suggestions and a dejagnus test. Robert On Thu, Jun 11, 2009 at 2:27 PM, Evan Cheng <evan.cheng at apple.com> wrote: > > On Jun 8, 2009, at 2:42 PM, robert muth wrote: > > > On Sun, Jun 7, 2009 at 11:53 PM, Evan Cheng <evan.cheng at apple.com>