search for: json_optstring

...le’ to supply the path to the oVirt or RHV user’s ‘ca.pem’ file"); { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids } @@ -92,6 +90,10 @@ let nbdkit_python_plugin = Config.virt_v2v_nbdkit_python_plugin let pidfile_timeout = 30 let finalization_timeout = 5*60 +let json_optstring = function + | Some s -> JSON.String s + | None -> JSON.Null + class output_rhv_upload output_alloc output_conn output_password output_storage rhv_options = @@ -195,7 +197,7 @@ See also the virt-v2v-output-rhv(1) manual.") "o...

...let mp = Mkdtemp.temp_dir ~base_dir:tmpdir "v2v." in chmod mp 0o755; (* Try mounting it. *) diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml index 5c6c2611..40498ba3 100644 --- a/v2v/output_rhv_upload.ml +++ b/v2v/output_rhv_upload.ml @@ -153,13 +153,6 @@ let json_optstring = function class output_rhv_upload output_alloc output_conn output_password output_storage rhv_options = - (* Create a temporary directory which will be deleted on exit. *) - let tmpdir = - let base_dir = (open_guestfs ())#get_cachedir () in -...

Since this new temporary directory will contain UNIX sockets for communicating with nbdkit, then its path must not be too long. Use the existing directory that libguestfs exposes for this, i.e. sockdir. --- v2v/nbdkit.ml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml index 65317f9b..46b20c9d 100644 --- a/v2v/nbdkit.ml +++ b/v2v/nbdkit.ml