search for: journaldevice_

...bg, + int64_t blockscount) +{ + int r; + char *err = NULL; + const char *argv[MAX_ARGS]; + char blocksize_s[64]; + char fragsize_s[64]; + char blockspergroup_s[64]; + char numberofgroups_s[64]; + char bytesperinode_s[64]; + char inodesize_s[64]; + char journalsize_s[64]; + char journaldevice_s[256]; + char reservedblockspercentage_s[64]; + char numberofinodes_s[64]; + char mmpupdateinterval_s[84]; + char stridesize_s[74]; + char stripewidth_s[84]; + char maxonlineresize_s[74]; + char blockscount_s[64]; + size_t i = 0; + int feature = 0; + char features[256]; + + ADD_ARG (argv...

...t;)) { + if (is_device_parameter (journaldevice)) { if (is_root_device (journaldevice)) { reply_with_error ("%s: device not found", journaldevice); return -1; @@ -1068,7 +1068,7 @@ do_mke2fs (const char *device, /* 0 */ sprintf (journaldevice_s, "device=%s", journaldevice_translated); } - else { + else /* XXX check only UUID= or LABEL= should be used here */ { journaldevice_s = malloc (strlen (journaldevice) + 8); if (!journaldevice_s) { reply_with_perror ("malloc"); diff...

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1477623 The first two patches are cleanups. The third patch changes the way that we handle Device and Dev_or_Path parameters so that a parameter marked as such can really only contain a block device name (and not, for instance, a chardev). Using a chardev here caused hangs in the API. The next two patches fix API usage to conform to this new stricter