search for: joshtriplett

...r/run Product: Portable OpenSSH Version: 5.8p1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: ssh-agent AssignedTo: unassigned-bugs at mindrot.org ReportedBy: josh at joshtriplett.org ssh-agent creates $SSH_AUTH_SOCK within a temporary directory of the form /tmp/ssh-XXXXXXXXXXXX. These directories often stick around and don't get cleaned up. (Right now I have piles of them just from the past month.) These directories seem like a perfect fit for /var/run, rather than...

...forwarding Product: Portable OpenSSH Version: 5.8p1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: ssh AssignedTo: unassigned-bugs at mindrot.org ReportedBy: josh at joshtriplett.org ~$ ssh joshtriplett.org ssh-add -l Could not open a connection to your authentication agent. ~$ ssh -A joshtriplett.org ssh-add -l Could not open a connection to your authentication agent. The second connection made use of the backgrounded master connection opened by the first connection, wh...

On Mon, Oct 21, 2013 at 7:34 PM, Josh Triplett <josh at joshtriplett.org> wrote: > __set_tss_desc has a complex calculation of the TSS segment limit, > duplicating the quirky details of the I/O bitmap array length, and > requiring a complex comment to explain. Replace that calculation with a > simpler one based on the offsetof the "stack" f...

https://bugzilla.mindrot.org/show_bug.cgi?id=1594 Summary: please add an option to print the pid of -f backgrounded process Product: Portable OpenSSH Version: 5.2p1 Platform: Other OS/Version: Linux Status: NEW Severity: enhancement Priority: P2 Component: ssh AssignedTo:

On Mon, Oct 21, 2013 at 7:34 PM, Josh Triplett <josh at joshtriplett.org> wrote: > __set_tss_desc has a complex calculation of the TSS segment limit, > duplicating the quirky details of the I/O bitmap array length, and > requiring a complex comment to explain. Replace that calculation with a > simpler one based on the offsetof the "stack" f...

...t ID 85d9a1a -- -Gene On Sat, May 16, 2015 at 3:30 AM, Josh Triplett via Syslinux <syslinux at zytor.com> wrote: > Check if the first character matches the character to replace, rather > than skipping it and starting with the second. > > Signed-off-by: Josh Triplett <josh at joshtriplett.org> > --- > > I'm assuming, based on a look at the callers, that this is not > intentional, and that it just happened that none of the callers happened > to ever need to replace the first character. > > com32/lib/chrreplace.c | 2 +- > 1 file changed, 1 insertion(+)...

On Wed, Oct 29, 2014 at 09:59:25AM -0700, Kees Cook wrote: > On Wed, Oct 29, 2014 at 9:10 AM, Josh Triplett <josh at joshtriplett.org> wrote: > > --- a/arch/x86/kernel/process-io.h > > +++ b/arch/x86/kernel/process-io.h > > @@ -1,9 +1,17 @@ > > #ifndef _X86_KERNEL_PROCESS_IO_H > > #define _X86_KERNEL_PROCESS_IO_H > > > > +static inline void clear_thread_io_bitmap(struct task_stru...

On Wed, Oct 29, 2014 at 09:59:25AM -0700, Kees Cook wrote: > On Wed, Oct 29, 2014 at 9:10 AM, Josh Triplett <josh at joshtriplett.org> wrote: > > --- a/arch/x86/kernel/process-io.h > > +++ b/arch/x86/kernel/process-io.h > > @@ -1,9 +1,17 @@ > > #ifndef _X86_KERNEL_PROCESS_IO_H > > #define _X86_KERNEL_PROCESS_IO_H > > > > +static inline void clear_thread_io_bitmap(struct task_stru...

This patch series makes it possible to compile out the userspace IO system calls, iopl and ioperm. The first patch does some 32/64 unification in copy_thread to make subsequent changes easier. The second patch simplifies the complex calculation of the TSS segment limit, which also makes it easier to change in the last patch. Patches 3-9 introduce helpers to make it easier to compile out IO.

This patch series makes it possible to compile out the userspace IO system calls, iopl and ioperm. The first patch does some 32/64 unification in copy_thread to make subsequent changes easier. The second patch simplifies the complex calculation of the TSS segment limit, which also makes it easier to change in the last patch. Patches 3-9 introduce helpers to make it easier to compile out IO.

...:30 AM, Josh Triplett via Syslinux > > <syslinux at zytor.com> wrote: > > > Check if the first character matches the character to replace, rather > > > than skipping it and starting with the second. > > > > > > Signed-off-by: Josh Triplett <josh at joshtriplett.org> > > > --- > > > > > > I'm assuming, based on a look at the callers, that this is not > > > intentional, and that it just happened that none of the callers happened > > > to ever need to replace the first character. > > > > > &g...

> Check if the first character matches the character to replace, rather > than skipping it and starting with the second. > > Signed-off-by: Josh Triplett <josh at joshtriplett.org> > --- > > I'm assuming, based on a look at the callers, that this is not > intentional, and that it just happened that none of the callers happened > to ever need to replace the first character. > > com32/lib/chrreplace.c | 2 +- > 1 file changed, 1 insertion(...

...warning in virtio_balloon.c: > > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ?virtballoon_migratepage? [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com> > > Reviewed-by: Josh Triplett <josh at joshtriplett.org> Acked-by: Michael S. Tsirkin <mst at redhat.com> > > drivers/virtio/virtio_balloon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > index c444654....

...warning in virtio_balloon.c: > > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ?virtballoon_migratepage? [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com> > > Reviewed-by: Josh Triplett <josh at joshtriplett.org> Acked-by: Michael S. Tsirkin <mst at redhat.com> > > drivers/virtio/virtio_balloon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > index c444654....

Mark the function virtballoon_migratepage() as static in virtio_balloon.c because it is not used outside this file. This eliminates the following warning in virtio_balloon.c: drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ?virtballoon_migratepage? [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com> ---

Mark the function virtballoon_migratepage() as static in virtio_balloon.c because it is not used outside this file. This eliminates the following warning in virtio_balloon.c: drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ?virtballoon_migratepage? [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com> ---

...t because that error actually occurred when attempting to boot the kernel, but because errno has that value on entry to syslinux_boot_linux and nothing clears or sets it.) Fix the regression by handling the corner case of no protected-mode code explicitly. Signed-off-by: Josh Triplett <josh at joshtriplett.org> Signed-off-by: Burt Triplett <burt at pbjtriplett.org> --- This patch applies to the "elflink" branch for syslinux 5. Found because people started trying to use syslinux 5 to boot BITS, which uses lnxboot.img as kernel and core.img as initrd, and it failed to boot with the...

...t Product: Portable OpenSSH Version: 6.7p1 Hardware: Other OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: sshd Assignee: unassigned-bugs at mindrot.org Reporter: josh at joshtriplett.org "ssh -R 0:example.org:port" will forward a dynamically allocated port on the server to example.org:port from the client. The dynamically allocated port gets printed; however, as far as I can tell there's no way to access it programmatically from the server. I'd like to have...

...or handling. Clean up the error paths in both by moving the copy of > the I/O bitmap to the end, to eliminate the need to free it if > subsequent copy steps fail; move the resulting identical code to a > static inline in a common header. > > Signed-off-by: Josh Triplett <josh at joshtriplett.org> > --- > arch/x86/kernel/process-io.h | 22 ++++++++++++++++++++++ I don't particularly like this new file. It's also not in a proper place. > arch/x86/kernel/process_32.c | 29 ++++++++--------------------- > arch/x86/kernel/process_64.c | 26 +++++--------------------...

...or handling. Clean up the error paths in both by moving the copy of > the I/O bitmap to the end, to eliminate the need to free it if > subsequent copy steps fail; move the resulting identical code to a > static inline in a common header. > > Signed-off-by: Josh Triplett <josh at joshtriplett.org> > --- > arch/x86/kernel/process-io.h | 22 ++++++++++++++++++++++ I don't particularly like this new file. It's also not in a proper place. > arch/x86/kernel/process_32.c | 29 ++++++++--------------------- > arch/x86/kernel/process_64.c | 26 +++++--------------------...