search for: jni_version_info

...00644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -77,6 +77,9 @@ if HAVE_JAVA JAVAC_FLAGS = $(EXTRA_JAVAC_FLAGS) -encoding utf-8 JAVADOC_FLAGS = -encoding utf-8 +if !HAVE_JAVAH +JAVAC_FLAGS += -h . +endif # Java source. @@ -125,10 +128,18 @@ libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared BUILT_SOURCES = com_redhat_et_libguestfs_GuestFS.h +if HAVE_JAVAH + com_redhat_et_libguestfs_GuestFS.h: $(java_prefix)/GuestFS.class rm -f $@ $(JAVAH) -classpath $(srcdir):. com.redhat.et.libguestfs.GuestFS +else + +com_redhat_et_libguestfs_GuestFS.h: libguestfs-${VERSION}.jar...

From: Hilko Bengen <bengen at hilluzination.de> --- erlang/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/erlang/Makefile.am b/erlang/Makefile.am index f336375..2c9e359 100644 --- a/erlang/Makefile.am +++ b/erlang/Makefile.am @@ -32,7 +32,7 @@ erlang_bindir = $(libdir)/erlang/lib/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/ebin erlang_bin_DATA = guestfs.beam

...guestfs_jni_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(JNI_CFLAGS) -libguestfs_jni_la_LIBADD = $(top_builddir)/lib/libguestfs.la +libguestfs_jni_la_LIBADD = \ + $(top_builddir)/common/utils/libutils.la \ + $(top_builddir)/lib/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared -- 2.9.3

...S) $(WERROR_CFLAGS) \ > $(JNI_CFLAGS) > > -libguestfs_jni_la_LIBADD = $(top_builddir)/lib/libguestfs.la > +libguestfs_jni_la_LIBADD = \ > + $(top_builddir)/common/utils/libutils.la \ > + $(top_builddir)/lib/libguestfs.la > > libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared > > -- > 2.9.3 > > _______________________________________________ > Libguestfs mailing list > Libguestfs@redhat.com > https://www.redhat.com/mailman/listinfo/libguestfs -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my p...

* Pino Toscano: > @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then > AC_SUBST(JAR_INSTALL_DIR) > AC_SUBST(JNI_INSTALL_DIR) > AC_SUBST(JNI_VERSION_INFO) > + AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"]) > fi > > AM_CONDITIONAL([HAVE_JAVA],[test "x$with_java" != "xno" && test -n "$JAVAC"]) The AM_CONDITIONAL must be moved outside the if ... fi shell conditional, otherwise configu...

On Sun, May 06, 2018 at 04:11:36PM +0200, Hilko Bengen wrote: > * Pino Toscano: > > > @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then > > AC_SUBST(JAR_INSTALL_DIR) > > AC_SUBST(JNI_INSTALL_DIR) > > AC_SUBST(JNI_VERSION_INFO) > > + AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"]) > > fi > > > > AM_CONDITIONAL([HAVE_JAVA],[test "x$with_java" != "xno" && test -n "$JAVAC"]) > > The AM_CONDITIONAL must be moved outside the if ... fi shell...

...i_la_CFLAGS = \ libguestfs_jni_la_LIBADD = \ $(top_builddir)/common/structs/libstructs.la \ $(top_builddir)/common/utils/libutils.la \ - $(top_builddir)/lib/libguestfs.la + $(top_builddir)/lib/libguestfs.la \ + $(top_builddir)/gnulib/lib/libgnu.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared -- 2.18.0

Hi, this patch series fixes some issues discovered by Coverity. Most of them are memory leaks, usually on error; there are also invalid memory access issues. Thanks, Pino Toscano (11): java: link libguestfs_jni against libutils java: fix invalid memory access for FBuffer in struct lists daemon: tsk: properly use GUESTFS_MAX_CHUNK_SIZE edit: fix small memory leak on error java: fix

Avoids the warning: libtoolize: Remember to add 'LT_INIT' to configure.ac. This is the new name for AC_PROG_LIBTOOL, so I removed that. However to use this macro we must enable AC_USE_SYSTEM_EXTENSIONS. (AC_GNU_SOURCE was removed back in 2011). --- configure.ac | 5 +++++ m4/guestfs-progs.m4 | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

Patch 1/5 is a repost. Only change is title update. These fix parallel make on my machine, and additionally make building from subdirectories more correct.

...$(top_builddir)/src diff --git a/java/Makefile.am b/java/Makefile.am index 449f40b..5f6499b 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -79,7 +79,7 @@ libguestfs_jni_la_SOURCES = \ libguestfs_jni_la_LIBADD = $(top_builddir)/src/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared libguestfs_jni_la_CFLAGS = \ - -DGUESTFS_PRIVATE_FUNCTIONS=1 \ + -DGUESTFS_PRIVATE=1 \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ -I$(top_srcdir)/src -I$(top_builddir)/src \ $(JNI_CFLAGS) diff --git a/lua/Makefile.am b/lua/Makefile.am index 9b0f7de..621366e 100644 --- a/lua/Makefile.am +++ b...

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

...top_srcdir)/lib -I$(top_builddir)/lib @@ -117,6 +118,7 @@ libguestfs_jni_la_CFLAGS = \ libguestfs_jni_la_LIBADD = \ $(top_builddir)/common/utils/libutils.la \ + $(top_builddir)/common/cleanups/libcleanups.la \ $(top_builddir)/lib/libguestfs.la libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared diff --git a/lib/Makefile.am b/lib/Makefile.am index 360ce9c92..90c657514 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -138,6 +138,7 @@ libguestfs_la_CPPFLAGS = \ -I$(top_srcdir)/common/errnostring -I$(top_builddir)/common/errnostring \ -I$(top_srcdir)/common/protocol -I$(top_...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.