search for: jhash_1word

Displaying 20 results from an estimated 23 matches for "jhash_1word".

2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...*sk, > > > sizeof(struct frag_hdr)) & ~7; > > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > > ipv6_select_ident(&fhdr, rt); > > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > > + fhdr.identification); > > > > > > append: > > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > > > > I thought about mixing in the incoming interface identifier into the...
2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...*sk, > > > sizeof(struct frag_hdr)) & ~7; > > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > > ipv6_select_ident(&fhdr, rt); > > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > > + fhdr.identification); > > > > > > append: > > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > > > > I thought about mixing in the incoming interface identifier into the...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...sizeof(struct frag_hdr)) & ~7; > > > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > > > ipv6_select_ident(&fhdr, rt); > > > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > > > + fhdr.identification); > > > > > > > > append: > > > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > > > > > > > I thought about mixing in the inco...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...sizeof(struct frag_hdr)) & ~7; > > > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > > > ipv6_select_ident(&fhdr, rt); > > > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > > > + fhdr.identification); > > > > > > > > append: > > > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > > > > > > > I thought about mixing in the inco...
2017 Oct 28
5
[Bug 1199] New: nft_set_hash fast lookup broken for 2 byte keys
...com Hi, after an upgrade of the userspace nftables to v0.8, I found that my port sets suddenly stopped matching. After some searching, I tracked the issue down to nft_hash_key and nft_hash_lookup_fast - with v0.8, the kernel started preferring hashes instead of bitsets. nft_hash_lookup_fast uses jhash_1word, which always uses the hash initializer appropriate for keys of length == 4. This means it miscomputes the bucket location for 2-byte keys and the lookup fails. In addition, lookups for 4-byte keys will probably fail on big endian machines - the byte-wise jhash used everywhere else reads the u32s a...
2015 Jan 28
7
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...static inline int ip6_ufo_append_data(struct sock *sk, > sizeof(struct frag_hdr)) & ~7; > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > ipv6_select_ident(&fhdr, rt); > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > + fhdr.identification); > > append: > return skb_append_datato_frags(sk, skb, getfrag, from, > I thought about mixing in the incoming interface identifier into the frag id generation, but that could hurt us badly as soon as a VM has m...
2015 Jan 28
7
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...static inline int ip6_ufo_append_data(struct sock *sk, > sizeof(struct frag_hdr)) & ~7; > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > ipv6_select_ident(&fhdr, rt); > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > + fhdr.identification); > > append: > return skb_append_datato_frags(sk, skb, getfrag, from, > I thought about mixing in the incoming interface identifier into the frag id generation, but that could hurt us badly as soon as a VM has m...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._append_data(struct sock *sk, > > sizeof(struct frag_hdr)) & ~7; > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > ipv6_select_ident(&fhdr, rt); > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > + fhdr.identification); > > > > append: > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that c...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._append_data(struct sock *sk, > > sizeof(struct frag_hdr)) & ~7; > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > ipv6_select_ident(&fhdr, rt); > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > + fhdr.identification); > > > > append: > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that c...
2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...sock *sk, > >> sizeof(struct frag_hdr)) & ~7; > >> skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > >> ipv6_select_ident(&fhdr, rt); > >> - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > >> + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > >> + fhdr.identification); > >> > >> append: > >> return skb_append_datato_frags(sk, skb, getfrag, from, > >> > > > > I thought about mixing in the incoming interface identifier into the > &...
2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...sock *sk, > >> sizeof(struct frag_hdr)) & ~7; > >> skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > >> ipv6_select_ident(&fhdr, rt); > >> - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > >> + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > >> + fhdr.identification); > >> > >> append: > >> return skb_append_datato_frags(sk, skb, getfrag, from, > >> > > > > I thought about mixing in the incoming interface identifier into the > &...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
....c @@ -1092,7 +1092,8 @@ static inline int ip6_ufo_append_data(struct sock *sk, sizeof(struct frag_hdr)) & ~7; skb_shinfo(skb)->gso_type = SKB_GSO_UDP; ipv6_select_ident(&fhdr, rt); - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, + fhdr.identification); append: return skb_append_datato_frags(sk, skb, getfrag, from, -- MST
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
....c @@ -1092,7 +1092,8 @@ static inline int ip6_ufo_append_data(struct sock *sk, sizeof(struct frag_hdr)) & ~7; skb_shinfo(skb)->gso_type = SKB_GSO_UDP; ipv6_select_ident(&fhdr, rt); - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, + fhdr.identification); append: return skb_append_datato_frags(sk, skb, getfrag, from, -- MST
2015 Jan 28
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
Hello, On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > > > On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > > > > On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: > > > >> On Tue, Jan 27, 2015
2015 Jan 28
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
Hello, On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > > > On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > > > > On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: > > > >> On Tue, Jan 27, 2015
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...6_ufo_append_data(struct sock *sk, >> sizeof(struct frag_hdr)) & ~7; >> skb_shinfo(skb)->gso_type = SKB_GSO_UDP; >> ipv6_select_ident(&fhdr, rt); >> - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; >> + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, >> + fhdr.identification); >> >> append: >> return skb_append_datato_frags(sk, skb, getfrag, from, >> > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that could h...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...6_ufo_append_data(struct sock *sk, >> sizeof(struct frag_hdr)) & ~7; >> skb_shinfo(skb)->gso_type = SKB_GSO_UDP; >> ipv6_select_ident(&fhdr, rt); >> - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; >> + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, >> + fhdr.identification); >> >> append: >> return skb_append_datato_frags(sk, skb, getfrag, from, >> > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that could h...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._append_data(struct sock *sk, > > sizeof(struct frag_hdr)) & ~7; > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > ipv6_select_ident(&fhdr, rt); > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > + fhdr.identification); > > > > append: > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that c...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._append_data(struct sock *sk, > > sizeof(struct frag_hdr)) & ~7; > > skb_shinfo(skb)->gso_type = SKB_GSO_UDP; > > ipv6_select_ident(&fhdr, rt); > > - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; > > + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, > > + fhdr.identification); > > > > append: > > return skb_append_datato_frags(sk, skb, getfrag, from, > > > > I thought about mixing in the incoming interface identifier into the > frag id generation, but that c...
2015 Jan 28
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...gt;>> sizeof(struct frag_hdr)) & ~7; >>>> skb_shinfo(skb)->gso_type = SKB_GSO_UDP; >>>> ipv6_select_ident(&fhdr, rt); >>>> - skb_shinfo(skb)->ip6_frag_id = fhdr.identification; >>>> + skb_shinfo(skb)->ip6_frag_id = jhash_1word(skb_shinfo(skb)->ip6_frag_id, >>>> + fhdr.identification); >>>> >>>> append: >>>> return skb_append_datato_frags(sk, skb, getfrag, from, >>>> >>> >>> I thought about mixing in the incoming interface identi...