search for: jcline

On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > > > On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > <snip> > > > > > yeah, I think overall this file is a g...

On Thu, Sep 24, 2020 at 07:26:01PM +0200, Karol Herbst wrote: > On Thu, Sep 24, 2020 at 6:03 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > > > > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst...

On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs <skeggsb at gmail.com> wrote: > > On Thu, 13 Aug 2020 at 06:50, Jeremy Cline <jcline at redhat.com> wrote: > > > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > > new gp1xx temperature sensor") added support for reading finer-grain > > temperatures, but continued to report temperatures in 1 degree Celsius > > i...

...he out-of-tree driver (is it normal to send patches this way?) so it'll need adjustment if it's Cc'd to stable, but the easiest, most reliable way to make sure it's picked up is to add an explicit Cc: stable at vger.kernel.org tag to the commit. Also: Reviewed-by: Jeremy Cline <jcline at redhat.com> > > -dann > > > > > --- > > > drm/nouveau/nvkm/engine/device/base.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drm/nouveau/nvkm/engine/device/base.c b/drm/nouveau/nvkm/engine/device/base.c >...

On Fri, Nov 6, 2020 at 3:17 AM Jeremy Cline <jcline at redhat.com> wrote: > > Make use of the devm_drm_dev_alloc() API to bind the lifetime of > nouveau_drm structure to the drm_device. This is important because a > reference to nouveau_drm is accessible from drm_device, which is > provided to a number of DRM layer callbacks that c...

On Thu, Sep 24, 2020 at 6:03 PM Jeremy Cline <jcline at redhat.com> wrote: > > On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > > > &gt...

This series fixes a number of use-after-frees in nouveau's postclose() handler. It was discovered by pointing IGT's core_hotunplug tests at a nouveau device, but the steps to reproduce it are simple: 1. Open the device file 2. Unbind the driver or remove the device 3. Close the file opened in step 1. During the device removal, the nouveau_drm structure is de-allocated, but is

Op 23-09-2020 om 22:36 schreef Karol Herbst: > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: >> >> On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: >>> On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: >> >> <snip> >> >>> yeah, I think overall this file is a good idea...

On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: <snip> > yeah, I think overall this file is a good idea and being able to get a > quick overview over the driver is helpful. I think if we focus on the > user facing things first, like the hwmon or other things users > generally interact with would be he...

...crements via nvkm_therm_temp_get(). Rather than altering nvkm_therm_temp_get() to report finer-grain temperatures, which would be inconvenient for other users of the function, a second interface has been added to line up with hwmon's native unit of temperature. Signed-off-by: Jeremy Cline <jcline at redhat.com> --- .../drm/nouveau/include/nvkm/subdev/therm.h | 18 +++++++++++++ drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 +-- .../gpu/drm/nouveau/nvkm/subdev/therm/base.c | 16 ++++++++++++ .../gpu/drm/nouveau/nvkm/subdev/therm/gp100.c | 25 +++++++++++++++++-- .../gpu/drm/nouve...

On Thu, 13 Aug 2020 at 06:50, Jeremy Cline <jcline at redhat.com> wrote: > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > new gp1xx temperature sensor") added support for reading finer-grain > temperatures, but continued to report temperatures in 1 degree Celsius > increments via nvkm_therm_...

On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst <kherbst at redhat.com> wrote: > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline <jcline at redhat.com> wrote: > > > > The temp_get() function currently returns negative error numbers or a > > temperature. However, the thermal sensors can (in theory) measure > > negative temperatures. Some implementations of temp_get() correctly > > clamp negative tempe...

...tion to placeholder text. I'm interested in any and all feedback. Does the layout make sense, or would folks prefer a multi-page document. How much of the documentation I wrote is flat out wrong? If you want to see the HTML output, but don't want to build the docs, it's at https://www.jcline.org/docs/8fe0b0869644/gpu/nouveau.html. Signed-off-by: Jeremy Cline <jcline at redhat.com> --- Documentation/gpu/drivers.rst | 1 + Documentation/gpu/nouveau.rst | 129 ++++++++++++++ .../drm/nouveau/include/nvkm/engine/disp.h | 35 ++++ drivers/gpu/drm...

On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: > > Other gpu drivers have some driver-specific documentation, so it would > nice if nouveau did as well. > > This adds a bare-bones ReStructured Text document with sections for > module parameter documentation, an overview of the driver architecture, >...

On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > > On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: > > <snip> > > > yeah, I think overall this file is a good idea and being able to get a &g...

On Thu, Sep 24, 2020 at 3:06 PM Roy Spliet <nouveau at spliet.org> wrote: > > > Op 23-09-2020 om 22:36 schreef Karol Herbst: > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline <jcline at redhat.com> wrote: > >> > >> On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > >>> On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline <jcline at redhat.com> wrote: > >> > >> <snip> > >> > >>> yeah, I thin...

...istake them for errors, but some, like gp100_temp_get(), do not. Rather than relying on implementations remembering to clamp values, dedicate the function return value to error codes and accept a pointer to an integer where the temperature reading should be stored. Signed-off-by: Jeremy Cline <jcline at redhat.com> --- .../drm/nouveau/include/nvkm/subdev/therm.h | 2 +- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 12 ++++++------ .../gpu/drm/nouveau/nvkm/subdev/therm/base.c | 19 ++++++++++++++----- .../gpu/drm/nouveau/nvkm/subdev/therm/g84.c | 11 ++++++----- .../gpu/drm/nouveau/...

On Wed, Sep 09, 2020 at 10:22:14AM +0200, Karol Herbst wrote: > On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs <skeggsb at gmail.com> wrote: > > > > On Thu, 13 Aug 2020 at 06:50, Jeremy Cline <jcline at redhat.com> wrote: > > > > > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > > > new gp1xx temperature sensor") added support for reading finer-grain > > > temperatures, but continued to report temperatures in 1 degree...

...ronment using Xorg, then > moving the cursor on or off a window. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1571128 > Fixes: 9428088c90b6 ("drm/qxl: reapply cursor after resetting primary") > Cc: stable at vger.kernel.org > Signed-off-by: Jeremy Cline <jcline at redhat.com> Pushed to drm-misc-fixes. thanks, Gerd

On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline <jcline at redhat.com> wrote: > > The temp_get() function currently returns negative error numbers or a > temperature. However, the thermal sensors can (in theory) measure > negative temperatures. Some implementations of temp_get() correctly > clamp negative temperature readings to 0 so t...