search for: jcfaracco

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we imple...

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we imple...

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This fun...

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This fun...

Em seg, 7 de out de 2019 ?s 11:15, Julian Wiedmann <jwi at linux.ibm.com> escreveu: > > On 06.10.19 20:45, jcfaracco at gmail.com wrote: > > From: Julio Faracco <jcfaracco at gmail.com> > > > > For debug purpose of TX timeout events, a tx_timeout entry was added to > > monitor this special case: when dev_watchdog identifies a tx_timeout and > > throw an exception. We can both c...

Em seg, 7 de out de 2019 ?s 04:51, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > > From: Julio Faracco <jcfaracco at gmail.com> > > > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > > notifies the event in some specific que...

From: Julio Faracco <jcfaracco at gmail.com> To enable dev_watchdog, virtio_net should have a tx_timeout defined (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It notifies the event in some specific queue of device. This function still counts tx_timeout statistic and consider this event as an error (...

On Sun, Oct 06, 2019 at 03:45:13PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > Driver virtio_net is not handling error events for TX provided by > dev_watchdog. This event is reached when transmission queue is having > problems to transmit packets. To enable it, driver should have...

...a tx_timeout() function to guarantee that the driver will recover properly after receiving a timeout during a transmission of a packet. This patch add this feature and throw a timeout exception after 5 HZ. Considering some tests, this is the best time to use here. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 69 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 63c7810..75ac45c 100644 --- a/d...

...a tx_timeout() function to guarantee that the driver will recover properly after receiving a timeout during a transmission of a packet. This patch add this feature and throw a timeout exception after 5 HZ. Considering some tests, this is the best time to use here. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 69 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 63c7810..75ac45c 100644 --- a/d...

...iver will recover properly after receiving a timeout > > during a transmission of a packet. This patch add this feature and throw a > > timeout exception after 5 HZ. Considering some tests, this is the best > > time to use here. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Looks like a bunch of locks and flushes are missing in this patch. IMHO > that's just too painful with current hardware. IMO the right thing to > do here is to add ability to reset specific queues to hard...

...iver will recover properly after receiving a timeout > > during a transmission of a packet. This patch add this feature and throw a > > timeout exception after 5 HZ. Considering some tests, this is the best > > time to use here. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Looks like a bunch of locks and flushes are missing in this patch. IMHO > that's just too painful with current hardware. IMO the right thing to > do here is to add ability to reset specific queues to hard...

...s commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- v1-v2: Tag `net-next` was included to indentify where patch would be applied. --- drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- 1 file changed,...

...s commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- v1-v2: Tag `net-next` was included to indentify where patch would be applied. --- drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- 1 file changed,...

...t; during a transmission of a packet. This patch add this feature and > > > > throw a > > > > timeout exception after 5 HZ. Considering some tests, this is the best > > > > time to use here. > > > > > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > > > Looks like a bunch of locks and flushes are missing in this patch. IMHO > > > that's just too painful with current hardware. IMO the right thing to > > > do here...

...t; during a transmission of a packet. This patch add this feature and > > > > throw a > > > > timeout exception after 5 HZ. Considering some tests, this is the best > > > > time to use here. > > > > > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > > > Looks like a bunch of locks and flushes are missing in this patch. IMHO > > > that's just too painful with current hardware. IMO the right thing to > > > do here...

...e using C and set up Lisp to access those methods in C. This project was becoming a mess. The better scenario is using only Lisp. That's why I started to develop this bindings for Lisp. Now, I'm only using Lisp for it. For a while, I'm hosting this project on GitHub: https://github.com/jcfaracco/lispvirt But I'm planning to move it to common-lisp.net. There is still many things to do (callbacks, structures, some project decisions and planings, documentation, etc). Any contribution or suggestions would be helpful. The most important things to do now are test, test and test. Just shari...

...t; guarantee that the driver will recover properly after receiving a timeout > during a transmission of a packet. This patch add this feature and throw a > timeout exception after 5 HZ. Considering some tests, this is the best > time to use here. > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > Cc: Jason Wang <jasowang at redhat.com> Looks like a bunch of locks and flushes are missing in this patch. IMHO that's just too painful with current hardware. IMO the right thing to do here is to add ability to reset specific queues to hardware. > --- > dr...

...y after receiving a timeout > > > during a transmission of a packet. This patch add this feature and throw a > > > timeout exception after 5 HZ. Considering some tests, this is the best > > > time to use here. > > > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > > Cc: Jason Wang <jasowang at redhat.com> > > > > Looks like a bunch of locks and flushes are missing in this patch. IMHO > > that's just too painful with current hardware. IMO the right thing to > > do here is to add ability to rese...

...eues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues, including RX (because we don't have control of this). Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 83 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/n...