search for: jbd2_journal_begin_ordered_truncate

...e transaction after this function + * has been called but before a transaction for truncate is started (and + * furthermore it allows us to optimize the case where addition to orphan list + * happens in the same transaction as write - we don't have to write any data + * in such case). */ -int jbd2_journal_begin_ordered_truncate(struct jbd2_inode *inode, +int jbd2_journal_begin_ordered_truncate(journal_t *journal, + struct jbd2_inode *jinode, loff_t new_size) { - journal_t *journal; - transaction_t *commit_trans; + transaction_t *inode_trans, *commit_trans; int ret = 0; - if (!inode->i_transaction &&a...

Hi, I've looked at how OCFS2 call jbd2_journal_begin_ordered_truncate() (because I've been adding some comments about how is should be used) and noticed that OCFS2 has a potential race in truncate vs transaction commit leading to stale data in file. In particular: There is a race if someone writes new data and we start committing the transaction after jbd2_journa...

...able all possible OCFS2 kconfig options: > >> > >> > >> > >> In file included from fs/ocfs2/alloc.c:42: > >> fs/ocfs2/journal.h: In function 'ocfs2_begin_ordered_truncate': > >> fs/ocfs2/journal.h:451: warning: passing argument 1 of 'jbd2_journal_begin_ordered_truncate' from incompatible pointer type > >> fs/ocfs2/journal.h:451: warning: passing argument 2 of 'jbd2_journal_begin_ordered_truncate' makes integer from pointer without a cast > >> fs/ocfs2/journal.h:451: error: too many arguments to function 'jbd2_journal_begin_ordere...

...we could possibly dereference it. Proper locking requires the journal pointer (to access journal->j_list_lock), which we don't have. So we have to change the prototype of the function so that filesystem passes us the journal pointer. Also add a more detailed comment about why the function jbd2_journal_begin_ordered_truncate() does what it does and how it should be used. Thanks to Dan Carpenter <error27 at gmail.com> for pointing to the suspitious code. Signed-off-by: Jan Kara <jack at suse.cz> Signed-off-by: "Theodore Ts'o" <tytso at mit.edu> Acked-by: Joel Becker <joel.becker at o...

...we could possibly dereference it. Proper locking requires the journal pointer (to access journal->j_list_lock), which we don't have. So we have to change the prototype of the function so that filesystem passes us the journal pointer. Also add a more detailed comment about why the function jbd2_journal_begin_ordered_truncate() does what it does and how it should be used. Thanks to Dan Carpenter <error27 at gmail.com> for pointing to the suspitious code. Signed-off-by: Jan Kara <jack at suse.cz> Signed-off-by: "Theodore Ts'o" <tytso at mit.edu> Acked-by: Joel Becker <joel.becker at o...

An embedded and charset-unspecified text was scrubbed... Name: jbd2-avoid-possible-null-dereference-in-jbd2_journal_begin_ordered_truncate.patch Url: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20090314/e76983fe/attachment.pl

An embedded and charset-unspecified text was scrubbed... Name: jbd2-avoid-possible-null-dereference-in-jbd2_journal_begin_ordered_truncate.patch Url: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20090314/01c46374/attachment.pl

ocfs2 currently uses the Journaled Block Device (JBD) for its journaling. This is a very stable and tested codebase. However, JBD is limited by architecture to 32bit block numbers. This means an ocfs2 filesystem is limited to 2^32 blocks. With a 4K blocksize, that's 16TB. People want larger volumes. Fortunately, there is now JBD2. JBD2 adds 64bit block number support and some other

This version fixes three bugs in the 2nd patch of this series that caused kernel BUG when the system was under race. We weren't accounting with t_oustanding_credits correctly, and there were race conditions caused by the fact the I had overlooked the fact that __jbd2_log_wait_for_space() and jbd2_get_transaction() requires j_state_lock to be write locked. Theodore Ts'o (3): jbd2: Use