search for: jbacik

...ing operation we can starve out the committers which slows everybody out. To address this we want to add this functionality to see if our rwsem has anybody waiting to take a write lock so we can drop it and schedule for a bit to allow the commit to continue. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- I''ve cc''ed people who seemed like they may be in charge/familiar with this code, hopefully I got the right people. include/linux/rwsem.h | 1 + lib/rwsem.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a...

...makes us do mixed file block groups for btrfs, so these enospc tests will usually fail because we don''t have space for metadata, which is the case for this test. So jack the size up to 1.5gig so that btrfs can do its normal thing and pass the test. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- tests/generic/256 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/generic/256 b/tests/generic/256 index 4a53da8..cfe7237 100755 --- a/tests/generic/256 +++ b/tests/generic/256 @@ -165,7 +165,7 @@ _test_full_fs_punch() # Make a small file syst...

...ck(). Plus, check the return value of kmalloc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan <arjan@infradead.org> Cc: Chris Mason <chris.mason@oracle.com> Cc: Yan Zheng <zheng.yan@oracle.com> Cc: Sven Wegener <sven.wegener@stealer.net> Cc: Josef Bacik <jbacik@redhat.com> Cc: Jeff Mahoney <jeffm@suse.com> Cc: Tao Ma <tao.ma@oracle.com> --- diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7c3cd24..e7b0d81 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -944,14 +944,19 @@ static ssize_t btrfs_file_write(struct file *file, const ch...

...ck(). Plus, check the return value of kmalloc(). Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Arjan <arjan@infradead.org> Cc: Chris Mason <chris.mason@oracle.com> Cc: Yan Zheng <zheng.yan@oracle.com> Cc: Sven Wegener <sven.wegener@stealer.net> Cc: Josef Bacik <jbacik@redhat.com> Cc: Jeff Mahoney <jeffm@suse.com> --- diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7c3cd24..09ef5d6 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -944,14 +944,17 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf, if (count == 0)...

An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current updating device tree requires space from METADATA chunk, so we -may- need to do a recursive chunk allocation when adding/updating dev extent, that is where the deadlock comes from. If we use SYSTEM metadata to update device tree, we can avoid the recursive stuff. Reported-by: Jim Schutt

...RATCH_MNT, and then that test will fail because we can''t mkfs the device because it is busy. I reproduced this on a box that doesn''t use /etc/mtab by doing ./check btrfs/307 generic/015 and 015 would fail. With this patch it passes now. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- tests/btrfs/307 | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/btrfs/307 b/tests/btrfs/307 index 87314c6..15157b3 100644 --- a/tests/btrfs/307 +++ b/tests/btrfs/307 @@ -35,6 +35,7 @@ _cleanup() { cd / rm -f $tmp.* + umount $SCRATCH...

...the commit root and if they match just commit the transaction again, that way we get the changes from the orphan cleanup. With this patch the reproducer I made for this bugzilla no longer returns ESTALE when trying to do the send. Thanks, Cc: stable@vger.kernel.org Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/send.c | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index ff40f1c..ba9690b 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -4579,6 +4579,41 @@ long btrfs_ioctl_send(...

We still need to say we''re flushing if we''re limit flushing to keep somebody from coming in and stealing our reservation. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/extent-tree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index ad8786b..721efb8 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4004,7 +4004,7 @@ again: * We make th...

Hi everybody, I am using btrfs as my main fs for some time now, but I am experiencing severe performance drawbacks. I can''t qualify the circumstances, but sometimes during disc access the whole system freezes for some time. Maybe somebody could suggest some general things I could try to search for the problem? Thanks in advance, Florian --- Some background information: $ mount |

...nings with xfstest 83 because we have reservations outstanding. This is because we moved the orphan add outside of the truncate, but we don''t actually cleanup our reservation if something fails. This fixes the problem and I no longer see warnings. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/inode.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 73e9409..905297f 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -2538,6 +2538,8 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)...

Hello I think, I somewhat destroyed my btrfs filesystem on my Ubuntu 13.04 kernel 3.8.0-25-lowlatency system. It got destroyed, because the system was hanging for some other reason and I had to remove power... When I try to mount my filesystem (there''s only one, with a few subfilesystems), the system crashes. Also btrfsck dies; always like this: a@ask-home:~$ sudo

...issues with fsync()''ing directories and fsync()''ing after renames. These three new tests cover the 3 different issues we were seeing. This breaks out the dmflakey stuff into a common helper to be shared between generic/311 and generic/321. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- V1->V2: rename test to generic/321 -removed an extraneous command tests/generic/311 | 56 +++----------------- tests/generic/321 | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/321.out | 9 ++++ tests/generic/group | 1 + 4 files chan...

Hi all, Did someone have met this problem before. When doing the tests, I hit the WARN_ON. Is this log make sense or someone had fixed the problem. If needed, I can supply the detail log and the testcase source file. Version: the latest codes at linus git tree. [ 2140.981293] use_block_rsv: 336 callbacks suppressed [ 2140.981295] ------------[ cut here ]------------ [ 2140.981308]

Hello On my HP Compaq dc5800 with Ubuntu 13.04 and their 3.8.0-19-lowlatency kernel, I''ve got quite some kernel traces in the syslog. You can find them below or at http://pastebin.com/bLXPBX67 (to avoid line breaks…). These kernel traces all begin with: WARNING: at fs/btrfs/free-space-cache.c:921 __btrfs_write_out_cache+0x6b9/0x9a0 [btrfs]() Most of the time, it starts with: Call

...ver appear, can forget about it". " There is a performance penalty incured by the change, but deleting a subvolume is not a frequent operation and the tradeoff seems justified by getting the guarantee stated above. CC: Alex Lyakas <alex.btrfs@zadarastorage.com> CC: Josef Bacik <jbacik@fusionio.com> Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/ioctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index e407f75..4394632 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2268,7 +2268,7 @@...

...that the free space we are trying to remove from the bitmap is in fact there. This can probably go away after a while, but since this code is only used by the tree-logging stuff it would be nice to run with it for a while to make sure there are no problems. Thanks, Signed-off-by: Josef Bacik <jbacik@redhat.com> --- fs/btrfs/free-space-cache.c | 40 +++++++++++++++++++++++++++++++--------- 1 files changed, 31 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index af99b78..691ea95 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/f...

...lloc_start < *start and adjust it up, but not adjust delalloc_end up, so things go sideways. To fix this we need to not limit the max bytes in find_delalloc_range, but in find_lock_delalloc_range and that way we don''t end up with this confusion. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/extent_io.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index b48942f..2bf6f46 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -1491,10 +1491,8 @@ static noinline u64 find...

Hello, I was bored this weekend so I hacked up online dedup for Btrfs. It''s working quite well so I think it can be more widely tested. There are two ways to use it 1) Compatible mode - this is a bit slower but will handle being used by older kernels. We use the csum tree to find duplicate blocks. Since it is relatively easy to have crc32c collisions this also involves reading the

Hi, If i set strict allocate = yes in samba to speed up the transfer of a mssql database dump, then btrfs does not compress the file. I have tried it also by just copying a small file in Windows to the samba share and the same. I have tried btrfs mount options autodefrag and then btrfs fi defrag -c and the file still does not get compressed. I have tried kernels 3.6.11, 3.8 and 3.10.7 on FC16

...he transaction commit because the ordered flushers were waiting for more refs and were never woken up, so those smp_mb()''s are the most important. Everything else I added for correctness sake and to avoid getting bitten by this again somewhere else. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/compression.c | 1 + fs/btrfs/delayed-inode.c | 16 ++++++++++------ fs/btrfs/delayed-ref.c | 18 ++++++++++++------ fs/btrfs/disk-io.c | 11 ++++++++--- fs/btrfs/inode.c | 8 +++++--- fs/btrfs/volumes.c | 8 +++++--- 6 files cha...