search for: jb_drop

Danny Chan wrote: >Hi Jean and Steve, > >Can you tell me whether the jitter filter / buffer is adaptive type, I >saw the description of speex_jitter.h say it is "adaptive", anyone of >the group has implemented it and confirm it. > > I believe it is adaptive, but no, I haven't used it, because it's coupled only to the speex codec. We're working on a

> Yes. Jean-Marc has made the API more similar. > > Jean-Marc: Have you looked at the API we have for the > asterisk/iaxclient jitterbuffer? Just did. > It's pretty close to what you have now -- the major difference is that > your jb still assumes it can "own" the data passed in -- it copies it, > and it destroys it at will. With the API I put together,

...on become speex-independent. Instead of having speex_jitter_get call any particular speex_decode or speex_read_bits, etc functions, it could instead just return the "thing" it got, and a flag. I.e. #define JB_OK 0 #define JB_EMPTY 1 #define JB_NOFRAME 2 #define JB_DROP 3 JB_OK means here's the frame for the timestamp you asked for. JB_EMPTY means the jitterbuffer is empty, (we just started or whatnot) JB_NOFRAME means the caller should interpolate a frame JB_DROP means we'd like you to drop this frame, and try calling us again with the same t...

...ver >> cleanup is needed. > > Yeah, I wasn't sure about that one. The problem is what to do when you > need to discard. You seem to say you return it and ask the user to > destroy it (how?), but this seemed a bit error prone to me. We just return a frame with the return value JB_DROP, which tells the caller to drop this frame, and call jb_get again. When the caller is done with the jitterbuffer, it calls jb_getall() repeatedly, until it's empty, and then it can discard all the frames. > And it's not > like copying data is that expensive compared to decoding...

> We just return a frame with the return value JB_DROP, which tells the > caller to drop this frame, and call jb_get again. > > When the caller is done with the jitterbuffer, it calls jb_getall() > repeatedly, until it's empty, and then it can discard all the frames. Hmm, looks a bit error-prone to me. Especially considering I sti...

On May 3, 2006, at 9:12 PM, Jean-Marc Valin wrote: >> We just return a frame with the return value JB_DROP, which tells the >> caller to drop this frame, and call jb_get again. >> >> When the caller is done with the jitterbuffer, it calls jb_getall() >> repeatedly, until it's empty, and then it can discard all the frames. > > Hmm, looks a bit error-prone to me. Especial...