search for: janestreet

...atures in OCaml that we might want to use, in particular: - Make use of Bytes unconditional. Requires OCaml >= 4.02. - PPX extension points could be used to generate repetitive string_of_* functions. (OCaml >= 4.02) - ‘match’ can catch exceptions. (OCaml >= 4.02, https://blog.janestreet.com/pattern-matching-and-exception-handling-unite/) - Record fields and variant constructors can have the same name and the compiler sorts out the right struct/type intelligently. (OCaml >= 4.01, http://www.lexifi.com/blog/type-based-selection-label-and-constructors) - GADTs and fir...

...2). - Conditional on -runtime-variant _pic (added in OCaml 4.03). - Not being able to use ppx extension points, which means we have lots of repetitive string_of_* functions that could be mostly eliminated (needs OCaml >= 4.02). - Match + catch (needs OCaml >= 4.02) https://blog.janestreet.com/pattern-matching-and-exception-handling-unite/ - Warnings about "noalloc" (>= 4.03) and "Pervasives" (>= 4.07). I guess it's also the case that some dependencies that we require don't actually work on OCaml 4.01. Here are some common distros and the version...

Domain naming parsing wise, I couldn't find any code or any cases where the domain search option (119) is processed. Pointer loop handling: I agree that 32 is pretty arbitrary, the issue I was trying to prevent is a pointer at the end of a label pointing at the same label. This would still be backwards but infinite. However, this does suggest a solution: The pointer must be before the

...> finally:(unit -> unit) -> 'a +(** Execute [~f] and afterwards execute [~finally]. + + If [~f] throws an exception then [~finally] is run and the + original exception from [~f] is re-raised. + + If [~finally] throws an exception, then the original exception + is lost. (NB: Janestreet core {!Exn.protectx}, on which this + function is modelled, doesn't throw away the exception in this + case, but requires a lot more work by the caller. Perhaps we + will change this in future.) *) + +val failwithf : ('a, unit, string, 'b) format4 -> 'a +(** Like [failw...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid

Currently it appears that when PXE booting the domain search option is ignored and only the domain name option used for name resolution. The following patch adds support for domain search path usage when PXE booting: - adds parsing of the DHCP domain search option (119) - When resolving names via dns_resolv uses the search path if there's no dot in the name. - Reverts to the