search for: jaillet

If 'ioremap()' returns 0, 'gm20b_tegra_read_wpr()' will return 0 as well, which means success. Return -ENOMEM instead Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- Not sure that -ENOMEM is the best value. I've taken it because it is often used in such a case. --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/...

'iommu_domain_alloc()' returns NULL in case of error, not an error pointer. So test it accordingly. Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c index 9b638bd905ff..f2bc0b7d9b...

...rceforge.net> > Date: Mon, 15 Jul 2024 13:36:54 +0200 > > Single characters should be put into a sequence. > Thus use the corresponding function ?seq_putc? for one selected call. > > This issue was transformed by using the Coccinelle software. > > Suggested-by: Christophe Jaillet <christophe.jaillet at wanadoo.fr> > Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> > --- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b...

Hi Christophe, s/fix some error handling in 'ls_ucode_img_load_gr/plug memory leak in ls_ucode_img_load_gr() error path/ On 8 May 2017 at 08:46, Christophe JAILLET <christophe.jaillet at wanadoo.fr> wrote: > The last goto looks spurious because it releases less resources than the > previous one. > Add a new label in order to free the memory allocated by the 'kmemdup' > call. > > Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: a...

...rkus Elfring <elfring at users.sourceforge.net> Date: Mon, 15 Jul 2024 13:36:54 +0200 Single characters should be put into a sequence. Thus use the corresponding function ?seq_putc? for one selected call. This issue was transformed by using the Coccinelle software. Suggested-by: Christophe Jaillet <christophe.jaillet at wanadoo.fr> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouv...

On Tue, Jul 23, 2024 at 12:58?PM Christophe JAILLET <christophe.jaillet at wanadoo.fr> wrote: > > Le 15/07/2024 ? 15:15, Ilia Mirkin a ?crit : > > On Mon, Jul 15, 2024 at 7:49?AM Markus Elfring <Markus.Elfring at web.de> wrote: > >> > >> From: Markus Elfring <elfring at users.sourceforge.net> > >...

...Canillas <javierm at redhat.com> Cc: Jani Nikula <jani.nikula at intel.com> Cc: Thomas Zimmermann <tzimmermann at suse.de> Cc: Danilo Krummrich <dakr at redhat.com> Cc: Maxime Ripard <mripard at kernel.org> Cc: Kees Cook <keescook at chromium.org> Cc: Christophe JAILLET <christophe.jaillet at wanadoo.fr> Signed-off-by: Guenter Roeck <linux at roeck-us.net> --- v2: Use check_add_overflow() to calculate the allocation size and to check for overflows. drivers/gpu/drm/nouveau/nvif/object.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+)...

The last goto looks spurious because it releases less resources than the previous one. Add a new label in order to free the memory allocated by the 'kmemdup' call. Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- This fix is just a guess. I don't have the hardware to test it. At first, I just wanted to change the last 'goto free_data' into a 'goto free_img' in order to have a 'logical' goto layout. Then, I changed my mind and added ano...

The last goto looks spurious because it releases less resources than the previous one. Also free 'img->sig' if 'ls_ucode_img_build()' fails. Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- v2: update topic only free 'img->sig' if 'ls_ucode_img_build()' fails --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvk...

...== text data bss dec hex filename 5570 152 0 5722 165a drivers/gpu/drm/nouveau/nouveau_exec.o After: ===== text data bss dec hex filename 5630 112 0 5742 166e drivers/gpu/drm/nouveau/nouveau_exec.o Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- drivers/gpu/drm/nouveau/nouveau_exec.c | 2 +- drivers/gpu/drm/nouveau/nouveau_sched.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_exec.c b/dri...

...Mon, 15 Jul 2024 13:36:54 +0200 >> >> Single characters should be put into a sequence. >> Thus use the corresponding function ?seq_putc? for one selected call. >> >> This issue was transformed by using the Coccinelle software. >> >> Suggested-by: Christophe Jaillet <christophe.jaillet at wanadoo.fr> >> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> >> --- >> drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/n...

...Canillas <javierm at redhat.com> Cc: Jani Nikula <jani.nikula at intel.com> Cc: Thomas Zimmermann <tzimmermann at suse.de> Cc: Danilo Krummrich <dakr at redhat.com> Cc: Maxime Ripard <mripard at kernel.org> Cc: Kees Cook <keescook at chromium.org> Cc: Christophe JAILLET <christophe.jaillet at wanadoo.fr> Cc: Joe Perches <joe at perches.com> Reviewed-by: Kees Cook <keescook at chromium.org> Signed-off-by: Guenter Roeck <linux at roeck-us.net> --- v3: Split assignments from if conditions. v2: Use check_add_overflow() to calculate the allocati...

On Sat, May 18, 2024 at 06:54:36PM +0200, Christophe JAILLET wrote: > (adding linux-hardening at vger.kernel.org) > > > Le 18/05/2024 ? 16:37, Guenter Roeck a ?crit?: > > Trying to build parisc:allmodconfig with gcc 12.x or later results > > in the following build error. > > > > drivers/gpu/drm/nouveau/nvif/object.c: In...

On 5/18/24 10:32, Kees Cook wrote: > On Sat, May 18, 2024 at 06:54:36PM +0200, Christophe JAILLET wrote: >> (adding linux-hardening at vger.kernel.org) >> >> >> Le 18/05/2024 ? 16:37, Guenter Roeck a ?crit?: >>> Trying to build parisc:allmodconfig with gcc 12.x or later results >>> in the following build error. >>> >>> drivers/gpu/drm/...

(adding linux-hardening at vger.kernel.org) Le 18/05/2024 ? 16:37, Guenter Roeck a ?crit?: > Trying to build parisc:allmodconfig with gcc 12.x or later results > in the following build error. > > drivers/gpu/drm/nouveau/nvif/object.c: In function 'nvif_object_mthd': > drivers/gpu/drm/nouveau/nvif/object.c:161:9: error: > 'memcpy' accessing 4294967264 or more

Hi, in file 'drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c', error handling in 'gm20b_tegra_read_wpr()' seams to be broken. The code used is: mc = ioremap(TEGRA_MC_BASE, 0xd00); if (!mc) { nvkm_error(&sb->subdev, "..."); return PTR_ERR(mc); } so we always return '0', which means success. Best regards, CJ