search for: j_assert

The following 6 patches cleanup the jbd code and kill about 200 lines. First of 4 patches can apply to 2.6.13-git8 and 2.6.13-mm2. The rest of them can apply to 2.6.13-mm2. fs/jbd/checkpoint.c | 179 +++++++++++-------------------------------- fs/jbd/commit.c | 101 ++++++++++-------------- fs/jbd/journal.c | 11 +- fs/jbd/revoke.c | 158

...-warnings/fs/ext3/inode.c =================================================================== --- linux-2.6.10-bk11-warnings/fs/ext3/inode.c (revision 11) +++ linux-2.6.10-bk11-warnings/fs/ext3/inode.c (revision 12) @@ -803,7 +803,7 @@ if (create) { handle = ext3_journal_current_handle(); - J_ASSERT(handle != 0); + J_ASSERT(handle != NULL); } ret = ext3_get_block_handle(handle, inode, iblock, bh_result, create, 1); @@ -876,7 +876,7 @@ bh = sb_getblk(inode->i_sb, dummy.b_blocknr); if (buffer_new(&dummy)) { J_ASSERT(create != 0); - J_ASSERT(handle != 0); + J_ASSERT...

Hi Stephen, I'm one of developers of SnapFS, which based on Ext3. I got Assertion failure from SnapFS, at ext3_new_block() in fs/ext3/balloc.c: J_ASSERT (!test_and_set_bit(BH_Alloced, &bh->b_state)) If J_ASSERT is only use as debug, why it will modify data? I found the 'BH_Alloced' flag only occures at two place: one is balloc.c as above, the other is at journal_forget() in fs/jfs/transaction.c: J_ASSERT (!test_and_set_bit(BH_Free...

This version fixes three bugs in the 2nd patch of this series that caused kernel BUG when the system was under race. We weren't accounting with t_oustanding_credits correctly, and there were race conditions caused by the fact the I had overlooked the fact that __jbd2_log_wait_for_space() and jbd2_get_transaction() requires j_state_lock to be write locked. Theodore Ts'o (3): jbd2: Use

I get 2 rejects applying 2.2.19-ext3 to latest errata rh 2.2.19 kernel. 1) fs/buffer.c Should I put "J_ASSERT(buf->b_count > 0);" before or after " *(int *)0 = 0;"? ===== ext3 0.0.7a patch --- 934,946 ---- if (buf->b_count) { buf->b_count--; + if (!buf->b_count && + (buf->b_jlist != BJ_None && buf->b_jlist != BJ_Shadow &amp...

...is how I solved the 2 ext3 rejects 1) fs/buffer.c @@ -908,9 +933,13 @@ if (buf->b_count) { buf->b_count--; + if (!buf->b_count && + (buf->b_jlist != BJ_None && buf->b_jlist != BJ_Shadow && buf->b_jlis t != BJ_Data)) + J_ASSERT (!test_bit(BH_JWrite, &buf->b_state)); return; } printk("VFS: brelse: Trying to free free buffer\n"); + J_ASSERT(buf->b_count > 0); *(int *)0 = 0; <== This is RH specific, I chose to put J_ASSERT before it } 2) +1 to all added stuff include/li...

...d I've made all the ext3 filesystems with the -j option to create a hidden journal file. Everything works great ! But. When I plug the second disk in a start a reconstruction, sooner or later within seconds I get an 'ASSERT' failure at line 411 in journal.c. ! It's this line.... J_ASSERT(bh->b_jlist == 0 || bh->b_jlist == BJ_LogCtl || bh->b_jlist == BJ_IO || bh->b_jlist == BJ_Data); Anyone run into this using software raid ? Alan.

...h, Freed)) { JBUFFER_TRACE(jh, "add to new checkpointing trans"); __journal_insert_checkpoint(jh, commit_transaction); JBUFFER_TRACE(jh, "refile for checkpoint writeback"); __journal_refile_buffer(jh); } else { + clear_bit(BH_Freed, &bh->b_state); J_ASSERT_BH(bh, !buffer_dirty(bh)); J_ASSERT_JH(jh, jh->b_next_transaction == NULL); __journal_unfile_buffer(jh); --- ./fs/jbd/transaction.c 2002/05/26 23:13:05 1.2 +++ ./fs/jbd/transaction.c 2002/05/28 09:24:45 @@ -1834,6 +1834,7 @@ * running transaction if that is set, but nothing * els...

http://www.sample.banga.lt/crash.gif System - fully (except kernel) updated RedHat 7.3. Filesystems - ext3 in default ordered mode. What could be the cause of the crash? Kernel update will solve the problem? Thanks, Mindaugas

...rt_this_handle() succeeds, transaction->t_updates increases by 1 in it. But if start_this_handle() fails, transaction->t_updates does not increase. So, when commit the handle's transaction in jbd2_journal_stop(), the assertion is false, and then trigger a bug. The assertion is as follows: J_ASSERT(atomic_read(&transaction->t_updates) > 0) Signed-off-by: Younger Liu <younger.liu at huawei.com> --- fs/jbd2/transaction.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index 325bc01..9ddb444 100644 --- a/fs/jbd2/transactio...

Hi Steven, Hi ext3-users list! We encountered a reproduceable problem with ext3: When issuing a FIBMAP ioctl for a block written right before while the FS is under high load (RH build universe), the assertion !journal->j_running_transaction fails at the bottom of journal_flush() in fs/jbd/journal.c. We encountered this problem with the arch=s390x (64 bit big endian) bootloader zipl, I'll

Hello, We found that fsync and fdatasync syscalls sometimes don't sync data in an ext3 file system under the following conditions. 1. Kernel version is 2.6.6 or later (including 2.6.8.1 and 2.6.9-rc2). 2. Ext3's journalling mode is "data=journal". 3. Create a file (whose size is 1Mbytes) and execute umount/mount. 4. lseek to a random position within the file, write 8192 bytes

------------[ cut here ]------------ kernel BUG at fs/ext3/fsync.c:50! invalid operand: 0000 [#1] CPU: 0 EIP: 0060:[<b0187d38>] Not tainted VLI EFLAGS: 00010296 (2.6.13.1) EIP is at ext3_sync_file+0x58/0xf0 eax: 00000068 ebx: bf4a479c ecx: b03cffac edx: b03cffac esi: b0398cfc edi: b2b8f1c8 ebp: c13bcf60 esp: c13bcf18 ds: 007b es: 007b ss: 0068 Process aptitude

Hi, If this is a redundant post I apologize. I am running 2.4.20 on what has been a very stable Athlon machine for months, tried to move a 2 GB file from an ext2 partition to an ext3 and kjournald crashed. Here are the last reminants of my shell scrollback: [*ROOT* mofo /mnt/sda1/mysql/fd 641 ] ll oldmail/ total 2363288 -rw-rw---- 1 mysql mysql 2147483647 Jan 23 18:04 maillog.MYD