search for: item_local_change

...k: /* Not the right symlink (or not a symlink), so * delete it. */ if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_SYMLINK) != 0) @@ -1572,18 +1583,20 @@ set_file_attrs(fname, file, NULL, NULL, 0); if (itemizing) { itemize(fname, file, ndx, statret, &sx, - ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL); + ITEM_LOCAL_CHANGE|iflags, 0, NULL); } - if (code != FNONE && verbose) + if ((iflags & ITEM_REPORT_CHANGE) && code != FNONE && verbose) rprintf(code, "%s -> %s\n", fname, sl); #ifdef SUPPORT_HARD_LINKS if...

...fnametmp), full_fname(fname)); + goto cleanup; + } + if (itemizing) { + itemize(fname, file, ndx, statret, &sx, + ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL); + } + if (verbose) + rprintf(code, "%s -> %s\n", fname, sl); +#ifdef SUPPORT_HARD_LINKS + if (preserve_hard_links && F_I...

Hi again. I just spotted another peculiarity when inspecting the rsync log. When using --compare-dest, source files that have permissions that differ from the "comparables" are not logged, unless you're using -i. Here's a testing session: $ ls -lR .: total 12 drwxr-xr-x 2 vidar users 4096 2005-03-31 14:16 cmp/ drwxr-xr-x 2 vidar users 4096 2005-03-31 14:23 dst/

...been able to reduce it to a simple test case. But looking through the code there's an obvious issue. In generator.c recv_generator(), with just a few lines removed for clarity, we have: recv_generator() { ... 1373: itemize(fnamecmp, file, ndx, statret, &sx, statret ? ITEM_LOCAL_CHANGE : 0, 0, NULL); ... 1657: real_sx = sx; ... 1837: free_xattr(&real_sx); ... 1892: free_xattr(&sx); ... } With xattrs in play, the itemize() ends up mallocing bits of memory and attaching it to sx.xattr. The "real_sx = sx" does a copy of the t...

...172): remark #981: operands are evaluated in unspecified order else if (lp_syslog_facility(-1) != lp_syslog_facility(module_id)) ^ log.c(594): remark #810: conversion from "int" to "char" may lose significant bits n[0] = iflags & ITEM_LOCAL_CHANGE ^ log.c(598): remark #810: conversion from "int" to "char" may lose significant bits n[1] = S_ISDIR(file->mode) ? 'd' ^ log.c(602): remark #810: conversion from "int" to "char" may lose significant bits n[2] = !(ifla...