search for: istargetmingw

...on windows", so Windows + Mingw + Cygwin - isTargetWin64() is is basically 64-bit version of isTargetWin32(), but strictly speaking is slightly different This naming while being the historical artifact is extremely confusing. For me it seems the best solution will be something like this: - isTargetMingw() - with obvious meaning - isTargetMSVC() - with obvious meaning - isTargetWindows() which will include all the flavours (so only OS will matter here) - isTargetWindows() can be combined with existing 32/64 bit checks This way we'll end with something being non-ambiguos. -- With best regar...

...onfusing... > - isTargetWin64() is is basically 64-bit version of isTargetWin32(), > but strictly speaking is slightly different > > This naming while being the historical artifact is extremely > confusing. For me it seems the best solution will be something like > this: > - isTargetMingw() - with obvious meaning > - isTargetMSVC() - with obvious meaning > - isTargetWindows() which will include all the flavours (so only OS > will matter here) > - isTargetWindows() can be combined with existing 32/64 bit checks > This way we'll end with something being non-ambig...

...MSVC 32-bit ABI > > is used and false for Cygwin+MinGW. > FTR, there's already such a method but it is (mis?)used only in > lib/Target/X86/X86FrameLowering.cpp for segmented stacks. > Are segmented stacks actually used with MSVC or is it just the > conditions there should use isTargetMingw() && !is64Bit() instead? > > cc'ing graydon about segmented stacks because I know rust uses them. -eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130320/fec79a4d/attachment.html>

On Thu, Mar 28, 2013 at 12:19 PM, Óscar Fuentes <ofv at wanadoo.es> wrote: > Eric Christopher <echristo at gmail.com> writes: > > > In my opinion none of these are irrelevant. Mingw and cygwin are separate > > ABIs that deal with some C compatibility (problems mentioned in this > thread > > are important here too) and give you the ability to work with low

...in32 which is true if the MSVC 32-bit ABI > is used and false for Cygwin+MinGW. FTR, there's already such a method but it is (mis?)used only in lib/Target/X86/X86FrameLowering.cpp for segmented stacks. Are segmented stacks actually used with MSVC or is it just the conditions there should use isTargetMingw() && !is64Bit() instead? > c) We should add CC_X86_Win32_C and CC_X86_Win32_ThisCall and use them > only for MSVC 32-bit ABI. > d) Cygwin and MinGW should use the CC_X86_32_C > > This way, Clang takes care of setting the SRet attribute wherever appropriate > and LLVM take...

...;> > is used and false for Cygwin+MinGW. >> FTR, there's already such a method but it is (mis?)used only in >> lib/Target/X86/X86FrameLowering.cpp for segmented stacks. >> Are segmented stacks actually used with MSVC or is it just the >> conditions there should use isTargetMingw() && !is64Bit() instead? Attached is a patch that makes the proposed change to isTargetWin32 and also fixes all the previous uses of isTargetWin32. Can you please review it? -- Thanks, Timur > cc'ing graydon about segmented stacks because I know rust uses them. > > -eric &gt...

Anton, [+Eric, Nick, the e-mail thread context has been broken a few times, so you should probably look at the llvmdev archives. It all starts here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-October/053961.html ] So I've decided to make a new attempt to fix this issue. We've discussed my patches with Eric and came up with the following idea: a) IsTargetWindows should be true for

...ed and false for Cygwin+MinGW. >>> FTR, there's already such a method but it is (mis?)used only in >>> lib/Target/X86/X86FrameLowering.cpp for segmented stacks. >>> Are segmented stacks actually used with MSVC or is it just the >>> conditions there should use isTargetMingw() && !is64Bit() instead? > > Attached is a patch that makes the proposed change to isTargetWin32 > and also fixes all the previous uses of isTargetWin32. > Can you please review it? > > -- > Thanks, > Timur > >> cc'ing graydon about segmented stacks beca...

...ngw + Cygwin > - isTargetWin64() is is basically 64-bit version of isTargetWin32(), > but strictly speaking is slightly different > > This naming while being the historical artifact is extremely > confusing. For me it seems the best solution will be something like > this: > - isTargetMingw() - with obvious meaning > - isTargetMSVC() - with obvious meaning > - isTargetWindows() which will include all the flavours (so only OS > will matter here) > - isTargetWindows() can be combined with existing 32/64 bit checks > > This way we'll end with something being non-...

...win+MinGW. > >>> FTR, there's already such a method but it is (mis?)used only in > >>> lib/Target/X86/X86FrameLowering.cpp for segmented stacks. > >>> Are segmented stacks actually used with MSVC or is it just the > >>> conditions there should use isTargetMingw() && !is64Bit() instead? > > > > Attached is a patch that makes the proposed change to isTargetWin32 > > and also fixes all the previous uses of isTargetWin32. > > Can you please review it? > > > > -- > > Thanks, > > Timur > > > >&...

Eric Christopher <echristo at gmail.com> writes: > In my opinion none of these are irrelevant. Mingw and cygwin are separate > ABIs that deal with some C compatibility (problems mentioned in this thread > are important here too) and give you the ability to work with low level C > libraries on windows, but if you want true compatibility with the full > platform > those ABIs