search for: ispar

I was trying to troubleshoot "jumpy" Sortables and noticed that when the function Element.isParent is called from onHover (line 749 in dragdrop.js v. 1.7.1_beta3) and from onEmptyHover (line 781), the arguments seem to be in reverse order. Element.isParent (line 944) expects "child, element(parent)" but is called with "dropon(parent), element(child)", making it return FAL...

...[1:1002] 0.2238 0.177 0.1399 0.1111 0.0891 ... $ cv.crit : num 3.19e-09 $ pen.crit: num 3.03e-06 $ crit : num 3.19e-09 $ df : num 27 $ spar : num -0.457 $ lambda : num 1.01e-09 $ iparms : Named int [1:3] 1 0 14 ..- attr(*, "names")= chr [1:3] "icrit" "ispar" "iter" $ fit :List of 5 ..$ knot : num [1:31] 0 0 0 0 0.041 ... ..$ nk : num 27 ..$ min : num 0 ..$ range: num 12.6 ..$ coef : num [1:27] 2.88e-05 1.72e-01 5.19e-01 9.04e-01 1.05 ... ..- attr(*, "class")= chr "smooth.spline.fit" $ call : l...

...= [options.accept].flatten(); Element.makePositioned(element); // fix IE @@ -40,34 +40,34 @@ var Droppables = { this.drops.push(options); }, - + findDeepestChild: function(drops) { deepest = drops[0]; - + for (i = 1; i < drops.length; ++i) if (Element.isParent(drops[i].element, deepest.element)) deepest = drops[i]; - + return deepest; }, isContained: function(element, drop) { var containmentNode; if(drop.tree) { - containmentNode = element.treeNode; + containmentNode = element.treeNode; } else {...

Note that one of the 8 patches (#6) will be sent separately in reply to this email, as some of the replaced lines are too long, so git won't let me send the email. However, there is nothing wrong with that patch, and it should be applied in the sequence listed below. Note also that I assume this will be tested on a clean f11 install, rather than an upgrade of an existing ovirt server